Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 165
    • Issues 165
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !263

Use GTask based AsyncInitiables classes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Marco Trevisan requested to merge 3v1n0/NetworkManager:gtask-initables into master Sep 06, 2019
  • Overview 44
  • Commits 5
  • Pipelines 0
  • Changes 5

Use GTask thread to initialize objects asynchronously to prevent that blocking operations might affect the UI (as per issue #239 (closed)).

Ideally I imagine all the other GSimpleAsyncResult should be moved to GTask but this wasn't the point of this branch.

I moved all the objects to use GTask as well natively, although I think this part can even be optimized more by ensuring that the whole creation happens in a different thread and finally we finish on main thread. But for now, I'd prefer to keep things as this.

Edited Sep 10, 2019 by Marco Trevisan
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gtask-initables