Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 162
    • Issues 162
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !255

device: fix crash when master connection fails

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Beniamino Galvani requested to merge bg/rh1747998 into master Sep 02, 2019
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

When the master AC becomes ready, activate_stage1_device_prepare() is called in a idle handler. If the master AC fails in the meantime, it will change state to deactivating or deactivated. We must check for that condition before proceeding with slave activation. Note the the 'master_ready' flag of an AC is never cleared after it is set.

Fixes: 5b677d5a ('device: move check for master from nm_device_activate_schedule_stage2_device_config() to end of stage1')

https://bugzilla.redhat.com/show_bug.cgi?id=1747998

Edited Sep 03, 2019 by Beniamino Galvani
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bg/rh1747998