Skip to content

make `nmcli --ask c u` behave as intended

Amelia Miner requested to merge ameliamminer/NetworkManager:nmcli-ask-c-u into main

Summary

nmcli's do_connection_up now works with --ask. No other behavior is changed, as far as I am able to determine. unit tests pass with default build parameters. valgrind reports no new memory issues. I'm not yet familiar with our CI, could use a pointer or two there, looks like I'm not authorized to run it but I haven't looked into what it takes to get that privelege yet, will update this accordingly when I get around to it.

There may be a better or more elegant way to fix this than what I have here. I haven't figured out a way to avoid the errant increment to argv in the call chain where it happens (do_connection_up, get_connection, next_arg) instead of applying this sort of bandaid fix in do_connection_up. I'm curious to hear if this solution is fine or if I should try harder to get closer to the root cause of the issue.

Purpose

fixes #1618 (closed)

Checklist

Please read https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/CONTRIBUTING.md before opening the merge request. In particular, check that:

  • the subject for all commits is concise and explicative I hope this is the case, let me know if not
  • the message for all commits explains the reason for the change
  • the source is properly formatted
  • any relevant documentation is up to date
  • you have added unit tests if applicable

I have a strong interest in test automation, so I am interested in doing this but could use guidance, will probably get on IRC later and see if anyone wants to help me out.

  • the NEWS file is updated when the change deserves to be mentioned, for example for new features, behavior changes, API deprecations, etc.

I haven't taken a look at this file yet, but it seems like I ought to due to the behavior change.

Edited by Amelia Miner

Merge request reports