Skip to content

l3cfg: ensure the probing timeout is initialized on probe start

Beniamino Galvani requested to merge bg/acd-init-timeout into main

Summary

When handling event TIMEOUT, acd_data->probing_timeout_msec needs to be always initialized before jumping to handle_start_probing:; otherwise, an assertion failure is triggered at:

static void
_l3_acd_data_timeout_schedule_probing_restart(AcdData *acd_data, gint64 now_msec)
{
  ...
  nm_assert(acd_data->probing_timeout_msec > 0);

Even if the ACD data is already in state PROBE, that doesn't mean that the timeout is already initialized because the PROBE state can also be reached from a INSTANCE_RESET event; and depending on the previous state acd_data->probing_timeout_msec could be uninitialized.

Fixes: b8f9d7b5 ('l3cfg: rework ACD handling in NML3Cfg to support handling conflicts')

Resolves: https://issues.redhat.com/browse/RHEL-54088

Edited by Beniamino Galvani

Merge request reports