Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 197
    • Issues 197
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 23
    • Merge requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !1506

dns: consider the dns-type and the priority when hashing DNS configs

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Beniamino Galvani requested to merge bg/dns into main Jan 19, 2023
  • Overview 8
  • Commits 3
  • Pipelines 6
  • Changes 7

The dns-type must be hashed as well because it contributes to the generated composite configuration. Without this, when the type of a configuration changes (e.g. from DEFAULT to BEST), the DNS manager would determine that there was no change and it wouldn't call update_dns().

https://bugzilla.redhat.com/show_bug.cgi?id=2161957

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bg/dns