Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !1481

macsec: fix tracking of parent ifindex

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Beniamino Galvani requested to merge bg/macsec-parent into main Dec 15, 2022
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 3

For MACsec interfaces, kernel announces the parent ifindex in the generic IFLA_LINK netlink attribute, which we save in NMPlatformLink.parent. There is no need to have a dedicate member in NMPlatformLnkMacsec.

The dedicate member was never set and during a restart of NetworkManager the parent of the MACsec device could be unset leading to a failed assertion:

  act_stage2_config: assertion 'parent' failed

Fixes: 85103656 ('platform: add support for macsec links')

https://bugzilla.redhat.com/show_bug.cgi?id=2122564

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bg/macsec-parent