Skip to content

ppp-manager: ip6: fix dns not being used

Dominique Martinet requested to merge martinetd/NetworkManager:ppp-ip6-dns into main

ipv6 DNS received on ppp interface were being ignored because their priority was not set.
Fix this by using default priority in impl_ppp_manager_set_ip6_config(), as was done for ip4_config in b2e559fa ("core: initialize l3cd dns-priority for ppp and wwan")

Fixes: 58287cbc ('core: rework IP configuration in NetworkManager using layer 3 configuration')

#1022 (closed)


Thanks @bgalvani for the hints :-)

I've also noticed we likely had the same problem with mtu so drive-by fixed that -- I'm not sure it matters, but it doesn't seem to make things worse at least.

(Hopefully) last couple of questions:

  • will the first commit be backported for 1.38.1, or shall I open a MR for it once this is merged?
  • I've looked at stable release history for 1.36 and didn't notice a pattern, are there plans for a 1.38.1 release? I'm asking as I'd need the fix for the end of the month and wondering if I should do a local build, try to update alpine's package with just the patch, or wait for 1.38.1 and update alpine's package with that instead -- just considering my odds!

Merge request reports