Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 164
    • Issues 164
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !1221

[th/meson-prefix-dir] build/meson: honor prefix for udev_dir and don't use pkg-config

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Thomas Haller requested to merge th/meson-prefix-dir into main May 11, 2022
  • Overview 6
  • Commits 3
  • Pipelines 3
  • Changes 2

When building with mesond -Dprefix=/tmp/nm, then we would expect that udev files are installed there (wouldn't we?).

The user can already explicitly set "-Dudev_dir=", or even disable installing the files with "-Dudev_dir=no".

Note that meson be default pre-populates get_option("prefix"), so there is always something set. So we cannot just act on whether the user set a prefix. It seems to default to /usr/local.

Note that package builds from Fedora spec file pass "-Dprefix=/usr".

I think we should honor the prefix. However, then it seems wrong to also honor pkg-config at the same time. In particular, because pkg-config --variable=udevdir udev gives /usr/lib/udev. That means, if we would just prepend the default prefix "/usr" or "/usr/local" to "/usr/lib/udev" we get the wrong result.

Note that we already to the same for autotools.


See !1187 (comment 1365220)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: th/meson-prefix-dir