Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 171
    • Issues 171
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !1182

n-acd4: drop state DRAINING from connection

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Beniamino Galvani requested to merge bg/n-dhcp4-packet-socket into main Apr 06, 2022
  • Overview 6
  • Commits 2
  • Pipelines 2
  • Changes 4

The DRAINING state is supposed to keep the packet socket alive until the next I/O event, after the creation of the UDP socket. In normal conditions, the next I/O event happens on the UDP socket when the address is renewed. Therefore, the packet socket stays alive for a long time.

It's not clear to me why this state is needed. Once the BOUND client state is reached (so, after receiving the ACK), the packet socket can be closed immediately.

#974

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bg/n-dhcp4-packet-socket