Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • NetworkManager NetworkManager
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 165
    • Issues 165
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • NetworkManagerNetworkManager
  • NetworkManagerNetworkManager
  • Merge requests
  • !1129

[th/uuid-gen] glib-aux: avoid nm_crypto_md5_hash() in nm_uuid_generate_from_string()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Thomas Haller requested to merge th/uuid-gen into main Mar 01, 2022
  • Overview 3
  • Commits 1
  • Pipelines 3
  • Changes 1

What nm_uuid_generate_from_string() is pretty straight forward. What nm_crypto_md5_hash() does, is not.

Just directly use GChecksum, it seems to be clearer.

Also, it seems sometimes the compiler is really adamant to warn about uninitialized variables. The workaround from commit cb9ca679 ('glib-aux: workaround maybe-uninitialized warning with LTO in nm_uuid_generate_from_string_str()') seems to not always work (and was ugly anyway). Try to solve that this way.

Note that we have plenty of unit tests for our UUID generation. This is covered by tests.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: th/uuid-gen