NetworkManager merge requestshttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests2023-01-11T16:32:37Zhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1127platform: update bridge options via netlink message2023-01-11T16:32:37ZVojtech Bubelaplatform: update bridge options via netlink messageWhen updating bridge options (for example with `nmcli connection modify <bridge-name> ...`) we should use netlink
instead of sysfs (because it is old) when communicating changes to the kernel.
For that i added couple of functions to pla...When updating bridge options (for example with `nmcli connection modify <bridge-name> ...`) we should use netlink
instead of sysfs (because it is old) when communicating changes to the kernel.
For that i added couple of functions to platform and then edited code in nm-device-bridge to use these functions.Vojtech BubelaVojtech Bubelahttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1126platform: add the plumbing to get the CSME connection info2022-03-07T13:55:39ZEmmanuel Grumbachplatform: add the plumbing to get the CSME connection infoThis includes the Intel vendor commands (merged in kernel 5.17) and all the utils functions up the layer that hopefully will us this.
Tested with the following test code:
```
/* Log new killswitch state */
new_rfkilled = rstate...This includes the Intel vendor commands (merged in kernel 5.17) and all the utils functions up the layer that hopefully will us this.
Tested with the following test code:
```
/* Log new killswitch state */
new_rfkilled = rstate->hw_enabled && rstate->sw_enabled;
if (old_rfkilled != new_rfkilled) {
_LOGI(LOGD_RFKILL,
"rfkill: %s now %s by radio killswitch",
nm_rfkill_type_to_string(rtype),
new_rfkilled ? "enabled" : "disabled");
}
if (!rstate->os_owner) {
NMPlatformCsmeConnInfo conn_info;
NMDevice *device;
const CList *tmp_lst;
nm_manager_for_each_device(self, device, tmp_lst) {
if (nm_device_get_device_type(device) != NM_DEVICE_TYPE_WIFI)
continue;
if ( nm_platform_wifi_get_csme_conn_info(priv->platform,
nm_device_get_ifindex(device),
&conn_info)) {
_LOGW(LOGD_RFKILL,
"rfkill: CSME is associated to SSID %s on channel %d",
conn_info.ssid, conn_info.channel);
nm_platform_wifi_get_device_from_csme(priv->platform, nm_device_get_ifindex(device));
}
}
}
```https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1125[th/nmcli-wifi-in-use] determine "in-use" flag based on the AP instance and n...2022-03-04T09:10:44ZThomas Haller[th/nmcli-wifi-in-use] determine "in-use" flag based on the AP instance and not the BSSIDSee https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/929#note_1277817See https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/929#note_1277817https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1124[th/route-type-throw] all: add support for route type "throw"2022-03-07T13:41:25ZThomas Haller[th/route-type-throw] all: add support for route type "throw"After adding support for "blackhole", "unreachable" and "prohibit" route
types, let's also add support for "throw" type. It works basically the
same as the other types, so supporting it seems very straight forward.After adding support for "blackhole", "unreachable" and "prohibit" route
types, let's also add support for "throw" type. It works basically the
same as the other types, so supporting it seems very straight forward.https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1123nm-online: set the timeout upper limit to 2073600 seconds2022-03-07T13:49:31ZFernando Fernández Manceranm-online: set the timeout upper limit to 2073600 secondsIn some situations 3600 seconds is not enough. The upper limit should be
2073600 seconds, 24 days. In addition, this limit should be documented.In some situations 3600 seconds is not enough. The upper limit should be
2073600 seconds, 24 days. In addition, this limit should be documented.https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1122core: initialize l3cd dns-priority for ppp and wwan2022-03-04T07:40:25ZBeniamino Galvanicore: initialize l3cd dns-priority for ppp and wwanFor devices that configure IP by themselves (by returning
"->ready_for_ip_config() = TRUE" and implementing
->act_stage3_ip_config()), we skip manual configuration. Currently,
manual configuration is the only one that sets flag HAS_DNS_P...For devices that configure IP by themselves (by returning
"->ready_for_ip_config() = TRUE" and implementing
->act_stage3_ip_config()), we skip manual configuration. Currently,
manual configuration is the only one that sets flag HAS_DNS_PRIORITY
into the resulting l3cd.
So, the merged l3cd for such devices misses a dns-priority and is
ignored by the DNS manager.
Explicitly initialize the priority to 0; in this way, the default
value for the device will be set in the final l3cd during the merge.
Fixes: 58287cbcc0c8 ('core: rework IP configuration in NetworkManager using layer 3 configuration')
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/931https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1121connectivity,cloud-setup: restrict curl protocols to HTTP and HTTPS2022-03-10T08:46:03ZThomas Hallerconnectivity,cloud-setup: restrict curl protocols to HTTP and HTTPS- See-also: https://fedoraproject.org/wiki/Changes/CurlMinimal_as_Default#Benefit_to_Fedora
- See-also: https://github.com/systemd/systemd/commit/55b90ee00b78a449c8f187a5e8141f8ccb100bf4- See-also: https://fedoraproject.org/wiki/Changes/CurlMinimal_as_Default#Benefit_to_Fedora
- See-also: https://github.com/systemd/systemd/commit/55b90ee00b78a449c8f187a5e8141f8ccb100bf4https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1120ovsdb: set DPDK port MTU when creating them2022-02-23T17:07:06ZFernando Fernández Manceraovsdb: set DPDK port MTU when creating themThe DPDK port will not have a link after the devbind which is needed for
configuring an interface to be a DPDK port. The MTU is being committed
during the link change but for DPDK ports there is no link.
The DPDK port MTU should be set ...The DPDK port will not have a link after the devbind which is needed for
configuring an interface to be a DPDK port. The MTU is being committed
during the link change but for DPDK ports there is no link.
The DPDK port MTU should be set on ovsdb right after the interface is
added to ovsdb. This way the users will be able to set MTU for DPDK
ports and modify it.
Please see the following results:
```
port 2: iface0 (dpdk: configured_rx_queues=1, configured_rxq_descriptors=2048, configured_tx_queues=3,
configured_txq_descriptors=2048, lsc_interrupt_mode=false, mtu=2000, requested_rx_queues=1,
requested_rxq_descriptors=2048, requested_tx_queues=3, requested_txq_descriptors=2048, rx_csum_offload=true, tx_tso_offload=false)
```https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1119ovs-port: fix removal of ovsdb entry if the interface goes away2022-03-04T09:32:59ZLubomir Rintelovs-port: fix removal of ovsdb entry if the interface goes awayHope third time is the charm.
The idea here is to remove the OVSDB entry if the device actually went away
violently (like, the it was actually removed from the platform), but keep it if
we're shutting down.
Fixes-test: @ovs_nmstate
Fix...Hope third time is the charm.
The idea here is to remove the OVSDB entry if the device actually went away
violently (like, the it was actually removed from the platform), but keep it if
we're shutting down.
Fixes-test: @ovs_nmstate
Fixes: 966413e78f14 ('ovs-port: avoid removing the OVSDB entry if we're shutting down')
Fixes: ecc73eb239e6 ('ovs-port: always remove the OVSDB entry on slave release')
https://bugzilla.redhat.com/show_bug.cgi?id=2055665https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1118ovsdb: register a shutdown objects for in-flight calls2022-02-22T17:59:40ZLubomir Rintelovsdb: register a shutdown objects for in-flight callsOnce the shutdown logic is in place, we don't want to shut down until
the OVSDB calls are serviced.Once the shutdown logic is in place, we don't want to shut down until
the OVSDB calls are serviced.https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1117ovs-port: avoid removing the OVSDB entry if we're shutting down2022-02-22T17:59:38ZLubomir Rintelovs-port: avoid removing the OVSDB entry if we're shutting downSince commit ecc73eb239e6 ("ovs-port: always remove the OVSDB entry on
slave release"), ovs port were removing the ovsdb entry upon being
un-enslaved, no matter what the reason for un-enslavement was. The idea
was to remove the stale ovs...Since commit ecc73eb239e6 ("ovs-port: always remove the OVSDB entry on
slave release"), ovs port were removing the ovsdb entry upon being
un-enslaved, no matter what the reason for un-enslavement was. The idea
was to remove the stale ovsdb entry upon forcible device removal.
This cleanup is specific to OpenVSwitch, since for other device types,
the device master is the property of the slave and thus goes away along
with the device.
Turns out we're now removing the ovsdb entry even when the device
actually doesn't go away, but we're pretending it does because the
daemon is shutting down.
To add insult to injury, we generally end up removing one entry,
because the other ovsdb calls end up in a queue and don't get serviced
before the daemon shuts down. The result is a mess. (This patch
doesn't solve that -- if someone terminates the daemon with in-flight
ovsdb calls they're still out of luck).
Let's do the cleanup now only if the device was actually physically
removed.
https://bugzilla.redhat.com/show_bug.cgi?id=2055665
Fixed: commit ecc73eb239e6 ("ovs-port: always remove the OVSDB entry on slave release")https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1116rpm: split ifcfg-rh settings plugin into a separate package2022-03-06T10:42:55ZBeniamino Galvanirpm: split ifcfg-rh settings plugin into a separate packageSplit the ifcfg-rh settings plugin into a separate package, so that it
will not be in new installations.
https://bugzilla.redhat.com/show_bug.cgi?id=2045875Split the ifcfg-rh settings plugin into a separate package, so that it
will not be in new installations.
https://bugzilla.redhat.com/show_bug.cgi?id=2045875https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1115device: commit the l3cd changes via l3cfg during cleanup2022-02-24T13:04:54ZWen Liangdevice: commit the l3cd changes via l3cfg during cleanupIn `nm_device_cleanup()`, the routes and addresses are removed directly
by bypassing the l3cfg, which makes the l3cfg think that some addresses
are still configured but they are actually already disappeared from the
kernel already.
To f...In `nm_device_cleanup()`, the routes and addresses are removed directly
by bypassing the l3cfg, which makes the l3cfg think that some addresses
are still configured but they are actually already disappeared from the
kernel already.
To fix it, commit the l3cd changes through l3cfg instead of removing
the addresses/routes directly.
Signed-off-by: Wen Liang <liangwen12year@gmail.com>https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1114vapi: annotate finish function for DeviceWifi.request_scan_options_async2022-02-21T18:44:50ZVal Ochvapi: annotate finish function for DeviceWifi.request_scan_options_asyncFixes issue with `DeviceWifi.request_scan_options_async` not working in Vala.Fixes issue with `DeviceWifi.request_scan_options_async` not working in Vala.https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1113[th/shutdown-timeout-increase]: increase NM_SHUTDOWN_TIMEOUT_MAX_MSEC to 5000...2022-02-24T08:40:05ZThomas Haller[th/shutdown-timeout-increase]: increase NM_SHUTDOWN_TIMEOUT_MAX_MSEC to 5000 and cleanupsToday, when NetworkManager quits after SIGTERM, it synchronously performs some cleanup actions and quits.
That has problems, and in the future the shutdown needs to be reworked as described [in the TODO file](https://gitlab.freedesktop.o...Today, when NetworkManager quits after SIGTERM, it synchronously performs some cleanup actions and quits.
That has problems, and in the future the shutdown needs to be reworked as described [in the TODO file](https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/47ff99515f0ecbc791851f3c1a1c61fb7efc234c/TODO#L5).
While the `FIXME(shutdown)` work is not yet done, we already have various API and things in place, for those future changes (`nm_shutdown_wait_obj_*()` and `NM_SHUTDOWN_TIMEOUT_*`).
This branch cleans up some things related to `NM_SHUTDOWN_TIMEOUT*` macros. In particular, the shutdown grace period gets incremented to 5 seconds, so it can also cover the time it takes before killing pppd.
There is no actual change in behavior in this branch, instead, it is a preparation for the future work.https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1112udev: manage veths named eth*2022-03-09T13:25:48ZLubomir Rinteludev: manage veths named eth*This is intended to unbreak LXD by default.This is intended to unbreak LXD by default.https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1111cli: don't reset default values in interactive add2022-02-21T17:06:09ZBeniamino Galvanicli: don't reset default values in interactive addSince commit 40032f461415 ('cli: fix resetting values via property
alias'), nmcli sets NULL properties during interactive add (nmcli -a
connection add) when the user leaves the field blank. This can lead to
an invalid connection for prop...Since commit 40032f461415 ('cli: fix resetting values via property
alias'), nmcli sets NULL properties during interactive add (nmcli -a
connection add) when the user leaves the field blank. This can lead to
an invalid connection for properties that can't be empty like
infiniband.transport-mode; they should be left to the default value in
case of no value entered.
Fixes: 40032f461415 ('cli: fix resetting values via property alias')
Fixes-test: @inf_create_port_novice_mode
https://bugzilla.redhat.com/show_bug.cgi?id=2053603https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1110platform: use switch statement in _linktype_get_type() for better readability2022-02-22T08:13:24Zluokai01platform: use switch statement in _linktype_get_type() for better readabilitySigned-off-by: luokai01's avatarluokai <454728735@qq.com>Signed-off-by: luokai01's avatarluokai <454728735@qq.com>https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1109Draft: pactl: optimized code2022-02-21T07:59:31Zluokai01Draft: pactl: optimized codesome if statements are redundant, use switch instead of it.
Signed-off-by: luokai01's avatarluokai <454728735@qq.com>some if statements are redundant, use switch instead of it.
Signed-off-by: luokai01's avatarluokai <454728735@qq.com>https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1108libnm-crypto: add new option for no cryptography2022-02-21T18:13:11ZChristian Eggerslibnm-crypto: add new option for no cryptographyFor some embedded systems, no cryptography is required at all (e.g when
only using Ethernet).
Signed-off-by: Christian Eggers <ceggers@arri.de>For some embedded systems, no cryptography is required at all (e.g when
only using Ethernet).
Signed-off-by: Christian Eggers <ceggers@arri.de>