1. 20 Jan, 2022 1 commit
  2. 11 Jan, 2022 2 commits
    • Thomas Haller's avatar
      e0cdbd73
    • Thomas Haller's avatar
      CONTRIBUTING: clarify on the use/lack of curly braces around blocks · 9ab22dbc
      Thomas Haller authored
      This is the style we have ever since. Spell it out. With the difference
      that now single line statements may have braces.
      
      Recently we were already sloppy about allowing curly braces for single line
      statements. Maybe there was a point in that. Imagine you start with:
      
          if (condition)
              call(some, parameter);
      
      Afterwards you change the code so that the line becomes too long and
      clang-format wraps the line (requiring you to add braces):
      
          if (condition) {
              call(some,
                   call_another_function(hey));
          }
      
      The problem now is that this diff is larger than it would have been, if
      you added curly braces from the start. Also, it means you have to go
      back and forth to add/remove these braces, as clang-format reformats the
      code.
      
      Also, if you have if-else-if blocks, then mixing multi line statements
      with single line statements is also cumbersome, because when something
      needs to change, the diff is may be larger (and the change more
      cumbersome).
      
      So it might be convenient to just always add the braces, and the
      documented style now allows for that.
      9ab22dbc
  3. 06 Oct, 2021 1 commit
  4. 08 Sep, 2021 1 commit
    • Thomas Haller's avatar
      std-aux: add "libnm-std-aux/nm-linux-compat.h" header to avoid build errors · 2a070434
      Thomas Haller authored
      We have a copy of a few linux user space headers in `src/linux-headers`.
      The idea is that we want to use recent kernel API, and not depend on the
      kernel UAPI headers installed on the build system (and not need to
      workaround that).
      
      However, we may not be able to simply compile them, because they too
      have dependencies. For example,
      
        ../src/linux-headers/ethtool.h:1389:2: error: implicit declaration of function '__KERNEL_DIV_ROUND_UP' [-Werror=implicit-function-declaration]
          __u32 queue_mask[__KERNEL_DIV_ROUND_UP(MAX_NUM_QUEUE, 32)];
          ^
      
      As workaround, don't include headers from "linux-headers" directly,
      but only include the new "libnm-std-aux/nm-linux-compat.h" adapter
      header, which tries to solve these incompatibilities.
      
      Fixes: 34d48d25 ('platform: clear all BASE types when setting advertised modes for ethernet autoneg')
      2a070434
  5. 27 Aug, 2021 1 commit
  6. 26 Aug, 2021 2 commits
  7. 19 Aug, 2021 1 commit
  8. 07 Jun, 2021 1 commit
  9. 25 May, 2021 1 commit
  10. 11 May, 2021 1 commit
  11. 24 Mar, 2021 1 commit
  12. 16 Mar, 2021 2 commits
  13. 27 Oct, 2020 1 commit
  14. 06 Oct, 2020 1 commit
  15. 29 Sep, 2020 1 commit
  16. 05 Aug, 2020 1 commit
  17. 01 Oct, 2019 1 commit
    • Thomas Haller's avatar
      CONTRIBUTING: update comment about requiring LGPL-2.1+ license instead of LGPL-2.0+ · 3c362317
      Thomas Haller authored
      Historically, libnm claimed to be LGPL-2.0+ licensed. But as keep mixing that
      with LGPL-2.1+ code (e.g. from systemd), so probably even the parts that
      claimed to be LGPL-2.0+, were not entirely correctly doing so.
      
      Anyway, since we switched to SPDX license identifiers, we now claim
      everywhere that the right license is LGPL-2.1+. Update the comment to
      reflect that.
      3c362317
  18. 26 Jun, 2019 1 commit
  19. 24 Jun, 2019 1 commit
  20. 12 Jun, 2019 2 commits
  21. 16 May, 2019 1 commit
  22. 25 Jul, 2017 1 commit
  23. 04 Feb, 2016 1 commit
  24. 07 Oct, 2009 1 commit
  25. 19 Nov, 2008 1 commit
  26. 13 Aug, 2004 1 commit