1. 21 May, 2019 22 commits
  2. 21 Apr, 2019 3 commits
  3. 20 Apr, 2019 5 commits
  4. 19 Apr, 2019 3 commits
  5. 18 Apr, 2019 7 commits
    • Till Maas's avatar
      contrib/rpm: Provide list of units to %systemd_postun · 51aee380
      Till Maas authored
      %systemd_postun is meant to be run with arguments and Fedora Rawhide
      seems to enforce this now. Therefore provide the units there, too.
      
      https://github.com/NetworkManager/NetworkManager/pull/348
      (cherry picked from commit 7d62f81e)
      51aee380
    • Thomas Haller's avatar
      build/meson: fix location of introspection files · 69b8036f
      Thomas Haller authored
      With glib < 2.51.3, gdbus-codegen does not understand "--output-directory" [1].
      Hence, the generated files are like
      
          "build/dbus-org.freedesktop.NetworkManager.Device.WifiP2P.xml"
      
      instead of
      
          "build/introspection/dbus-org.freedesktop.NetworkManager.Device.WifiP2P.xml"
      
      But gnome.gdbus_codegen() returns a path as if it would be inside
      "build/introspection". Hack around that, by patching the correct path
      otherwise. This is still ugly, because repeated "ninja -C build" calls
      will always try to rebuild this target (because the wrong file name
      is considered).
      
      See also [2].
      
      [1] https://gitlab.gnome.org/GNOME/glib/commit/ee09bb704fe9ccb24d92dd86696a0e6bb8f0dc1a
      [2] https://github.com/mesonbuild/meson/blob/2e93ed58c30d63da8527ff16375ff9e0642e7533/mesonbuild/modules/gnome.py#L1170
      
      (cherry picked from commit ad9e5995)
      69b8036f
    • Thomas Haller's avatar
      platform: fix nm_platform_lnk_gre_to_string() for tap links · ed88c71f
      Thomas Haller authored
      Why didn't we get a compiler warning about this bug?
      At least clang (3.8.0-2ubuntu4, Ubuntu 16.04) warns:
      
          CC       src/platform/src_libNetworkManagerBase_la-nm-platform.lo
        ../src/platform/nm-platform.c:5389:14: error: data argument not used by format string [-Werror,-Wformat-extra-args]
                            lnk->remote ? nm_sprintf_buf (str_remote, " remote %s", nm_utils_inet4_ntop (lnk->remote, str_remote1)) : "",
                            ^
      
      Fixes: 4c2862b9 ('platform: add gretap tunnels support')
      (cherry picked from commit dfb899f4)
      ed88c71f
    • Thomas Haller's avatar
      shared: merge branch 'th/shared-library-refactoring' · 0e2abc02
      Thomas Haller authored
      !113
      
      (cherry picked from commit 9740bd6d)
      0e2abc02
    • Thomas Haller's avatar
      build/meson: rename "nm_core_dep" to "libnm_core_dep" · e7836cd1
      Thomas Haller authored
      The library is called "libnm_core". So the dependency should be called
      "libnm_core_dep", like in all other cases.
      
      (cherry picked from commit c27ad37c)
      e7836cd1
    • Thomas Haller's avatar
      shared: build helper "libnm-libnm-core-{intern|aux}.la" library for libnm-core · 284ac92e
      Thomas Haller authored
      "libnm-core" implements common functionality for "NetworkManager" and
      "libnm".
      
      Note that clients like "nmcli" cannot access the internal API provided
      by "libnm-core". So, if nmcli wants to do something that is also done by
      "libnm-core", , "libnm", or "NetworkManager", the code would have to be
      duplicated.
      
      Instead, such code can be in "libnm-libnm-core-{intern|aux}.la".
      Note that:
      
        0) "libnm-libnm-core-intern.la" is used by libnm-core itsself.
           On the other hand, "libnm-libnm-core-aux.la" is not used by
           libnm-core, but provides utilities on top of it.
      
        1) they both extend "libnm-core" with utlities that are not public
           API of libnm itself. Maybe part of the code should one day become
           public API of libnm. On the other hand, this is code for which
           we may not want to commit to a stable interface or which we
           don't want to provide as part of the API.
      
        2) "libnm-libnm-core-intern.la" is statically linked by "libnm-core"
           and thus directly available to "libnm" and "NetworkManager".
           On the other hand, "libnm-libnm-core-aux.la" may be used by "libnm"
           and "NetworkManager".
           Both libraries may be statically linked by libnm clients (like
           nmcli).
      
        3) it must only use glib, libnm-glib-aux.la, and the public API
           of libnm-core.
           This is important: it must not use "libnm-core/nm-core-internal.h"
           nor "libnm-core/nm-utils-private.h" so the static library is usable
           by nmcli which couldn't access these.
      
      Note that "shared/nm-meta-setting.c" is an entirely different case,
      because it behaves differently depending on whether linking against
      "libnm-core" or the client programs. As such, this file must be compiled
      twice.
      
      (cherry picked from commit af07ed01)
      284ac92e
    • Thomas Haller's avatar
      shared: move "nm-dbus-compat.h" header to "nm-std-aux/nm-dbus-compat.h" · 87f7e684
      Thomas Haller authored
      (cherry picked from commit 81833358)
      87f7e684