1. 21 Mar, 2014 9 commits
    • Dan Winship's avatar
      tui: add some comments to nmt-newt-form.c · f8b4ee04
      Dan Winship authored
      f8b4ee04
    • Dan Winship's avatar
      tui: fix using Escape from main menu · 96a5ad51
      Dan Winship authored
      We weren't checking whether the form closed because the menu was
      activated or because the user hit Escape
      96a5ad51
    • Jiří Klimeš's avatar
    • Dan Winship's avatar
      tui: fix binding of some int/uint properties (rh #1078281) · f6e2b652
      Dan Winship authored
      GLib registers number->string value transforms (meaning that
      number-valued properties like NMSettingVlan:id or NMSettingWired:mtu
      get loaded into their NmtNewtEntries correctly), but not the
      corresponding string->number transforms (meaning changes made in the
      entries don't get propagated back to the settings, and due to
      http://bugzilla.gnome.org/show_bug.cgi?id=726574, there's no warning
      about this). Fix this by registering our own transforms.
      f6e2b652
    • Dan Winship's avatar
      tui: fix quitting from "nmtui edit CONN-ID" · 941ce352
      Dan Winship authored
      If you launched nmtui directly into the editor for a specific
      connection, it would hang with a blank screen when you quit.
      
      Fix this by changing the way startup works a bit, and have the created
      toplevel NmtNewtForm get returned all the way to nmtui.c, which can
      then connect to the "quit" signal on it and quit (rather than having
      the different subprograms trying to guess whether they're supposed to
      quit-on-exit or not).
      941ce352
    • Dan Winship's avatar
      tui: fix selection bugs after deleting a connection · bbc6434e
      Dan Winship authored
      nmt_newt_listbox_clear() did not reset active and active_key, which in
      the case of NmtEditConnectionList meant that after the connection list
      was rebuilt, the selection would appear to be in the same place, but
      active_key would still point to the connection that used to be in that
      row, rather than the one currently in that row, so if you immediately
      hit Edit or Delete, you'd get unexpected results. (It also meant that
      it was possible for the selection to land on a header row instead of a
      connection row.)
      
      This was particularly bad in the case of the Delete button, since
      active_key would be left pointing to a freed NMConnection in that
      case.
      
      Fix NmtNewtListbox, and then add code to NmtEditConnectionList to
      preserve the selection itself when rebuilding the list.
      bbc6434e
    • Dan Winship's avatar
      devices: send ARPs when configuring static IPv4 addresses (rh #1073447) · 01f41506
      Dan Winship authored
      After applying a configuration with static IPv4 addresses, call
      /sbin/arping to announce the new addresses to the host's neighbors.
      (Basic idea copied from Fedora ifup-eth.)
      01f41506
    • Jiří Klimeš's avatar
      core: improve ifname matching of existing x generated connections (rh #1077743) · 7ff7df76
      Jiří Klimeš authored
      DEVICE="ens3"
      ONBOOT=yes
      NETBOOT=yes
      UUID="23466771-f5fa-4ca9-856f-eaf4a8e20c3f"
      BOOTPROTO=none
      IPADDR="10.0.0.2"
      PREFIX="24"
      GATEWAY="10.0.0.1"
      HWADDR="52:54:00:12:34:56"
      TYPE=Ethernet
      NAME="ens3"
      
      This ifcfg file results in connection.interface-name=ens3.
      However, device-generated connection didn't set interface-name property.
      
      Fix that by setting interface-name property when generating a connection. Also
      allow matching connections if interface-name is not set in a connection.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1077743
      7ff7df76
    • Dan Williams's avatar
      core: export ActiveConnection before handing it to the device (bgo #723783) · e4bcfc20
      Dan Williams authored
      The AC doesn't get a D-Bus path until it's exported, but that happens after
      it's handed to the Device it will be activated on.  The Device emits a
      PropertyChanged event when it's handed the AC, but it ignores ACs that
      aren't exported yet.  Thus when activating, the Device doesn't emit the
      AC's path at all in the ActiveConnection property because it's NULL.
      
      Fix that by exporting the AC immediately before starting activation
      with it.
      
      Second, move the notification of the Device.ActiveConnection property
      to be emitted along with the state change to PREPARE instead of long
      before it.  While we don't guarantee signal ordering in general, this
      seems like a more correct ordering.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=723783
      e4bcfc20
  2. 19 Mar, 2014 2 commits
    • Dan Winship's avatar
      core: warn if multiple plugins for the same type are installed · 39808064
      Dan Winship authored
      If we find multiple plugins for the same type (eg, because the user
      previously installed the "atm" and "bt" plugins, and didn't delete
      them), log a warning.
      39808064
    • Dan Winship's avatar
      devices: rename "atm" plugin to "adsl", and "bt" to "bluetooth" · a18248dd
      Dan Winship authored
      The atm/adsl plugin really is a generic ATM plugin but (a) it needs a
      bit of work to do IPoATM rather than just PPPoATM and PPPoEoATM, and
      (b) most people currently using NM's ATM support are using DSL devices
      not actual ATM cards anyway, and have no idea what "ATM" even means.
      If we add the necessary IPoATM support later we can rename the plugin
      back to -atm
      a18248dd
  3. 18 Mar, 2014 2 commits
  4. 17 Mar, 2014 5 commits
  5. 14 Mar, 2014 4 commits
    • Dan Williams's avatar
      platform: fix crash if link has no name after 5e935dfd · 893735c8
      Dan Williams authored
      When a VPN goes down, like at suspend, and the link has already
      disappeared, the new platform logging code tries to print the
      link information using a link object with only the ifindex filled
      in.  When adding/removing/changing links, internal code often fills
      in just the ifindex (becuase that's all you need).  Thus
      to_string_link() will always fail if that operation fails.
      
          at platform/nm-linux-platform.c:688
          at platform/nm-linux-platform.c:1835
          at vpn-manager/nm-vpn-connection.c:274
      
      Work around that for now and live with the warnings until
      we decide what to actually do about to_string_link().
      893735c8
    • Dan Williams's avatar
      libnm-util: fix Bridge priority default (rh #1073664) · 13c348dc
      Dan Williams authored
      Due to a misread of the kernel code, the bridge priority default
      when STP was enabled was 0x80 instead of 0x8000.
      13c348dc
    • Thomas Haller's avatar
      trivial: fix invalid code comment · b73783b4
      Thomas Haller authored
      
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      b73783b4
    • Thomas Haller's avatar
      libnm-util: remove assert to nm_utils_ip4_netmask_to_prefix · 2f67105a
      Thomas Haller authored
      Commit 240c92dd
      
       added an assert
      to check that the input netmask is valid. Revert that commit for
      the most part, some changes to the test function are not reverted.
      
      We don't want to assert for a valid netmask, because it's
      common to read the netmask from (untrusted) user input, so we
      don't want to assert against it.
      
      The caller *could* validate the netmask from untrusted sources, but
      with the assert in place it cannot validate it in the most obvious way:
      
          prefix = nm_utils_ip4_netmask_to_prefix (netmask);
          if (netmask != nm_utils_ip4_prefix_to_netmask (prefix))
              goto fail;
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      2f67105a
  6. 13 Mar, 2014 10 commits
  7. 12 Mar, 2014 8 commits