1. 18 Mar, 2019 1 commit
    • Thomas Haller's avatar
      contrib/checkpatch: avoid command injection in checkpatch.pl script · d66a1ace
      Thomas Haller authored
      The capture variables, $1, etc, are not valid unless the match
      succeeded, and they're not cleared, either.
      
          $ git checkout -B C origin/master && \
              echo XXXXX > f.txt && \
              git add f.txt && \
              git commit -m 'this commit does something()'
          Branch 'C' set up to track remote branch 'master' from 'origin'.
          Reset branch 'C'
          Your branch is up to date with 'origin/master'.
          sh: -c: line 0: syntax error near unexpected token `('
          sh: -c: line 0: `git log --abbrev=12 --pretty=format:"%h ('%s')" -1 does something() 2>/dev/null'
      
          >>> VALIDATE "a169a98e14 this commit does something()"
          (commit message):4: Commit 'does something()' does not seem to exist:
          > Subject: [PATCH] this commit does something()
      
          (commit message):4: Refer to the commit id properly: :
          > Subject: [PATCH] this commit does something()
      
          The patch does not validate.
      d66a1ace
  2. 15 Mar, 2019 9 commits
  3. 13 Mar, 2019 21 commits
  4. 12 Mar, 2019 1 commit
  5. 11 Mar, 2019 8 commits
    • Thomas Haller's avatar
      shared/systemd: fix gettid() compat implementation shadowing function from glibc · cfb970b2
      Thomas Haller authored
      On Fedora rawhide we get the following build failure:
      
          In file included from shared/systemd/src/basic/alloc-util.c:3:
          ./shared/systemd/sd-adapt-shared/nm-sd-adapt-shared.h:114:21: error: static declaration of 'gettid' follows non-static declaration
            114 | static inline pid_t gettid(void) {
                |                     ^~~~~~
          In file included from /usr/include/unistd.h:1170,
                           from /usr/include/glib-2.0/gio/gcredentials.h:32,
                           from /usr/include/glib-2.0/gio/gio.h:46,
                           from ./shared/nm-utils/nm-macros-internal.h:31,
                           from ./shared/nm-default.h:293,
                           from ./shared/systemd/sd-adapt-shared/nm-sd-adapt-shared.h:22,
                           from shared/systemd/src/basic/alloc-util.c:3:
          /usr/include/bits/unistd_ext.h:34:16: note: previous declaration of 'gettid' was here
             34 | extern __pid_t gettid (void) __THROW;
                |                ^~~~~~
      
      glibc supports now gettid() call ([1]) which conflicts with our compat
      implementation. Rename it.
      
      [1] https://sourceware.org/git/?p=glibc.git;a=commit;h=1d0fc213824eaa2a8f8c4385daaa698ee8fb7c92
      
      (cherry picked from commit 10276322)
      cfb970b2
    • Thomas Haller's avatar
      shared/systemd: fix gettid() compat implementation shadowing function from glibc · 10276322
      Thomas Haller authored
      On Fedora rawhide we get the following build failure:
      
          In file included from shared/systemd/src/basic/alloc-util.c:3:
          ./shared/systemd/sd-adapt-shared/nm-sd-adapt-shared.h:114:21: error: static declaration of 'gettid' follows non-static declaration
            114 | static inline pid_t gettid(void) {
                |                     ^~~~~~
          In file included from /usr/include/unistd.h:1170,
                           from /usr/include/glib-2.0/gio/gcredentials.h:32,
                           from /usr/include/glib-2.0/gio/gio.h:46,
                           from ./shared/nm-utils/nm-macros-internal.h:31,
                           from ./shared/nm-default.h:293,
                           from ./shared/systemd/sd-adapt-shared/nm-sd-adapt-shared.h:22,
                           from shared/systemd/src/basic/alloc-util.c:3:
          /usr/include/bits/unistd_ext.h:34:16: note: previous declaration of 'gettid' was here
             34 | extern __pid_t gettid (void) __THROW;
                |                ^~~~~~
      
      glibc supports now gettid() call ([1]) which conflicts with our compat
      implementation. Rename it.
      
      [1] https://sourceware.org/git/?p=glibc.git;a=commit;h=1d0fc213824eaa2a8f8c4385daaa698ee8fb7c92
      10276322
    • Thomas Haller's avatar
      96be30cb
    • Thomas Haller's avatar
      ifcfg-rh: avoid duplicate cache lookup in is_wifi_device() · 9294b42b
      Thomas Haller authored
      (cherry picked from commit 6580f293)
      9294b42b
    • Frédéric Danis's avatar
      tests: Fix variant_from_dbus() for arrays of UInt32 · 10502f17
      Frédéric Danis authored
      Using test-networkmanager-servic.py, I get the following error when
      trying to add manual config with a dns address:
      
          Error: g-io-error-quark: Traceback (most recent call last):
            File "/usr/lib/python2.7/dist-packages/dbus/service.py", line 707, in _message_cb
              retval = candidate_method(self, *args, **keywords)
            File "tools/test-networkmanager-service.py", line 1727, in AddConnection
              return self.add_connection(con_hash)
            File "tools/test-networkmanager-service.py", line 1731, in add_connection
              con_inst = Connection(self.c_counter, con_hash, do_verify_strict)
            File "tools/test-networkmanager-service.py", line 1601, in __init__
              NmUtil.con_hash_verify(con_hash, do_verify_strict=do_verify_strict)
            File "tools/test-networkmanager-service.py", line 497, in con_hash_verify
              BusErr.raise_nmerror(e)
            File "tools/test-networkmanager-service.py", line 419, in raise_nmerror
              raise e
          Exception: Unsupported value ipv4.dns = dbus.Array([dbus.UInt32(168430090L), dbus.UInt32(218893066L)], signature=dbus.Signature('u'), variant_level=1) (Cannot convert array element to type 'u': Must be number, not Variant)
      
      https://mail.gnome.org/archives/networkmanager-list/2019-March/msg00013.html
      (cherry picked from commit 9a71d7d2)
      10502f17
    • Thomas Haller's avatar
      core: assert for valid NM_DEVICE_DEVICE_TYPE setting · 355cbbfb
      Thomas Haller authored
      (cherry picked from commit 7dd44d6d)
      355cbbfb
    • Lubomir Rintel's avatar
      all: codespell fixes · 4251f4e4
      Lubomir Rintel authored
      Codespel run with the same arguments as described in
      commit 58510ed5 ('docs: misc. typos pt2').
      
      (cherry picked from commit bf0c4e6a)
      4251f4e4
    • Lubomir Rintel's avatar
      all: codespell fixes · bf0c4e6a
      Lubomir Rintel authored
      Codespel run with the same arguments as described in
      commit 58510ed5 ('docs: misc. typos pt2').
      bf0c4e6a