1. 03 Jun, 2014 3 commits
  2. 02 Jun, 2014 6 commits
    • Dan Williams's avatar
      core: properly initialize unmanaged_flags and handle carrier_changed() for unmanaged devices · ffd961fe
      Dan Williams authored
      Fixes the following g_warn():
          #0  0x0000003370c504e9 in g_logv () from /lib64/libglib-2.0.so.0
          #1  0x0000003370c5063f in g_log () from /lib64/libglib-2.0.so.0
          #2  0x0000003370c50956 in g_warn_message () from /lib64/libglib-2.0.so.0
          #3  0x0000000000439962 in carrier_changed (device=0x1d94300, carrier=1) at devices/nm-device.c:1021
          #4  0x0000000000488f12 in carrier_changed (device=0x1d94300, carrier=1) at devices/nm-device-ethernet.c:1646
          #5  0x0000000000434c94 in nm_device_set_carrier (device=device@entry=0x1d94300, carrier=1) at devices/nm-device.c:1104
          #6  0x0000000000434dd5 in check_carrier (device=device@entry=0x1d94300) at devices/nm-device.c:1298
          #7  0x0000000000434ef8 in constructed (object=0x1d94300) at devices/nm-device.c:550
          #8  0x0000003371c15d87 in g_object_new_internal () from /lib64/libgobject-2.0.so.0
          #9  0x0000003371c17814 in g_object_new_valist () from /lib64/libgobject-2.0.so.0
          #10 0x0000003371c17c11 in g_object_new () from /lib64/libgobject-2.0.so.0
          #11 0x000000000048bc2e in nm_device_ethernet_new (platform_device=platform_device@entry=0x1d82e58) at devices/nm-device-ethernet.c:336
          #12 0x000000000047c600 in platform_link_added (self=0x1d70150, ifindex=ifindex@entry=2, plink=plink@entry=0x1d82e58, reason=reason@entry=NM_PLATFORM_REASON_INTERNAL) at nm-manager.c:1954
          #13 0x000000000047c7db in platform_link_cb (platform=<optimized out>, ifindex=2, plink=0x1d82e58, change_type=<optimized out>, reason=NM_PLATFORM_REASON_INTERNAL, user_data=0x1d70150) at nm-manager.c:2038
          #14 0x0000003371805d8c in ffi_call_unix64 () from /lib64/libffi.so.6
          #15 0x00000033718056bc in ffi_call () from /lib64/libffi.so.6
          #16 0x0000003371c10ad8 in g_cclosure_marshal_generic () from /lib64/libgobject-2.0.so.0
          #17 0x0000003371c10298 in g_closure_invoke () from /lib64/libgobject-2.0.so.0
          #18 0x0000003371c2235d in signal_emit_unlocked_R () from /lib64/libgobject-2.0.so.0
          #19 0x0000003371c2a0f2 in g_signal_emit_valist () from /lib64/libgobject-2.0.so.0
          #20 0x0000003371c2a3af in g_signal_emit () from /lib64/libgobject-2.0.so.0
          #21 0x000000000044f6ba in nm_platform_query_devices () at platform/nm-platform.c:330
          #22 0x000000000047de4c in nm_manager_start (self=0x1d70150) at nm-manager.c:4025
          #23 0x0000000000429d31 in main (argc=1, argv=0x7fffb4c31628) at main.c:654
      
      https://mail.gnome.org/archives/networkmanager-list/2014-June/msg00000.htmlSigned-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      ffd961fe
    • Jiří Klimeš's avatar
      d7b8aeea
    • Jiří Klimeš's avatar
    • Thomas Haller's avatar
      core/logging: remove thread-safe initialization guard for nm_logging_syslog_openlog() · 48b4d0ea
      Thomas Haller authored
      The logging routines are not thread-safe in general, so there is no
      need for trying to make nm_logging_syslog_openlog() thread-safe.
      Also nm_logging_syslog_openlog() is only called by the main() routine.
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      48b4d0ea
    • Thomas Haller's avatar
      core/firewall: fix accessing non-existing connection for device in firewall_started() · 7ac7249f
      Thomas Haller authored
      When starting firewall, NMPolicy would fail the following assertion:
      
          NetworkManager[1462]: <debug> [1401708294.250829] [firewall-manager/nm-firewall-manager.c:218] name_owner_changed(): firewall started
          (NetworkManager:1462): libnm-util-CRITICAL **: nm_connection_get_setting_connection: assertion 'NM_IS_CONNECTION (connection)' failed
      
          #0  0x0000003370c504e9 in g_logv () from /lib64/libglib-2.0.so.0
          #1  0x0000003370c5063f in g_log () from /lib64/libglib-2.0.so.0
          #2  0x00007f306f960e11 in nm_connection_get_setting_connection (connection=0x0) at nm-connection.c:1441
          #3  0x0000000000482319 in firewall_started (manager=<optimized out>, user_data=<optimized out>) at nm-policy.c:1881
          #4  0x0000003371c104c7 in _g_closure_invoke_va () from /lib64/libgobject-2.0.so.0
          #5  0x0000003371c29749 in g_signal_emit_valist () from /lib64/libgobject-2.0.so.0
          #6  0x0000003371c2a3af in g_signal_emit () from /lib64/libgobject-2.0.so.0
          #7  0x0000000000445d39 in name_owner_changed (dbus_mgr=<optimized out>, name=<optimized out>, old_owner=0x1452660 "", new_owner=0x1536720 ":1.175", user_data=<optimized out>) at firewall-manager/nm-firewall-manager.c:220
          ...
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      7ac7249f
    • Thomas Haller's avatar
      build: fix installing network-online.target for existing link · 16d34bfe
      Thomas Haller authored
      When reinstalling NM on the same location, it would fail with
      
          Making install in data
          make[1]: Entering directory `/home/data/src/NetworkManager/data'
          make[2]: Entering directory `/home/data/src/NetworkManager/data'
          install -d /opt/test/lib/systemd/system/network-online.target.wants
          ln -s /opt/test/lib/systemd/system/NetworkManager-wait-online.service /opt/test/lib/systemd/system/network-online.target.wants
          ln: failed to create symbolic link ‘/opt/test/lib/systemd/system/network-online.target.wants/NetworkManager-wait-online.service’: File exists
          make[2]: *** [install-exec-local] Error 1
      
      https://bugzilla.gnome.org/show_bug.cgi?id=728965Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      16d34bfe
  3. 31 May, 2014 4 commits
  4. 30 May, 2014 27 commits