1. 16 Jul, 2019 1 commit
    • Thomas Haller's avatar
      settings: rework tracking settings connections and settings plugins · d35d3c46
      Thomas Haller authored
      Completely rework how settings plugin handle connections and how
      NMSettings tracks the list of connections.
      
      Previously, settings plugins would return objects of (a subtype of) type
      NMSettingsConnection. The NMSettingsConnection was tightly coupled with
      the settings plugin. That has a lot of downsides.
      
      Change that. When changing this basic relation how settings connections
      are tracked, everything falls appart. That's why this is a huge change.
      Also, since I have to largely rewrite the settings plugins, I also
      added support for multiple keyfile directories, handle in-memory
      connections only by keyfile plugin and (partly) use copy-on-write NMConnection
      instances. I don't want to spend effort rewriting large parts while
      preserving the old way, that anyway should change. E.g. while rewriting ifcfg-rh,
      I don't want to let it handle in-memory connections because that's not right
      long-term.
      
      --
      
      If the settings plugins themself create subtypes of NMSettingsConnection
      instances, then a lot of knowledge about tracking connections moves
      to the plugins.
      Just try to follow the code what happend during nm_settings_add_connection().
      Note how the logic is spread out:
       - nm_settings_add_connection() calls plugin's add_connection()
       - add_connection() creates a NMSettingsConnection subtype
       - the plugin has to know that it's called during add-connection and
         not emit NM_SETTINGS_PLUGIN_CONNECTION_ADDED signal
       - NMSettings calls claim_connection() which hocks up the new
         NMSettingsConnection instance and configures the instance
         (like calling nm_settings_connection_added()).
      This summary does not sound like a lot, but try to follow that code. The logic
      is all over the place.
      
      Instead, settings plugins should have a very simple API for adding, modifying,
      deleting, loading and reloading connections. All the plugin does is to return a
      NMSettingsStorage handle. The storage instance is a handle to identify a profile
      in storage (e.g. a particular file). The settings plugin is free to subtype
      NMSettingsStorage, but it's not necessary.
      There are no more events raised, and the settings plugin implements the small
      API in a straightforward manner.
      NMSettings now drives all of this. Even NMSettingsConnection has now
      very little concern about how it's tracked and delegates only to NMSettings.
      
      This should make settings plugins simpler. Currently settings plugins
      are so cumbersome to implement, that we avoid having them. It should not be
      like that and it should be easy, beneficial and lightweight to create a new
      settings plugin.
      
      Note also how the settings plugins no longer care about duplicate UUIDs.
      Duplicated UUIDs are a fact of life and NMSettings must handle them. No
      need to overly concern settings plugins with that.
      
      --
      
      NMSettingsConnection is exposed directly on D-Bus (being a subtype of
      NMDBusObject) but it was also a GObject type provided by the settings
      plugin. Hence, it was not possible to migrate a profile from one plugin to
      another.
      However that would be useful when one profile does not support a
      connection type (like ifcfg-rh not supporting VPN). Currently such
      migration is not implemented except for migrating them to/from keyfile's
      run directory. The problem is that migrating profiles in general is
      complicated but in some cases it is important to do.
      
      For example checkpoint rollback should recreate the profile in the right
      settings plugin, not just add it to persistent storage. This is not yet
      properly implemented.
      
      --
      
      Previously, both keyfile and ifcfg-rh plugin implemented in-memory (unsaved)
      profiles, while ifupdown plugin cannot handle them. That meant duplication of code
      and a ifupdown profile could not be modified or made unsaved.
      This is now unified and only keyfile plugin handles in-memory profiles (bgo #744711).
      Also, NMSettings is aware of such profiles and treats them specially.
      In particular, NMSettings drives the migration between persistent and non-persistent
      storage.
      
      Note that a settings plugins may create truly generated, in-memory profiles.
      The settings plugin is free to generate and persist the profiles in any way it
      wishes. But the concept of "unsaved" profiles is now something explicitly handled
      by keyfile plugin. Also, these "unsaved" keyfile profiles are persisted to file system
      too, to the /run directory. This is great for two reasons: first of all, all
      profiles from keyfile storage in fact have a backing file -- even the
      unsaved ones. It also means you can create "unsaved" profiles in /run
      and load them with `nmcli connection load`, meaning there is a file
      based API for creating unsaved profiles.
      The other advantage is that these profiles now survive restarting
      NetworkManager. It's paramount that restarting the daemon is as
      non-disruptive as possible. Persisting unsaved files to /run improves
      here significantly.
      
      --
      
      In the past, NMSettingsConnection also implemented NMConnection interface.
      That was already changed a while ago and instead users call now
      nm_settings_connection_get_connection() to delegate to a
      NMSimpleConnection. What however still happened was that the NMConnection
      instance gets never swapped but instead the instance was modified with
      nm_connection_replace_settings_from_connection(), clear-secrets, etc.
      Change that and treat the NMConnection instance immutable. Instead of modifying
      it, reference/clone a new instance. This changes that previously when somebody
      wanted to keep a reference to an NMConnection, then the profile would be cloned.
      Now, it is supposed to be safe to reference the instance directly and everybody
      must ensure not to modify the instance. nmtst_connection_assert_unchanging()
      should help with that.
      The point is that the settings plugins may keep references to the
      NMConnection instance, and so does the NMSettingsConnection. We want
      to avoid cloning the instances as long as they are the same.
      Likewise, the device's applied connection can now also be referenced
      instead of cloning it. This is not yet done, and possibly there are
      further improvements possible.
      
      --
      
      Also implement multiple keyfile directores /usr/lib, /etc, /run (rh #1674545,
      bgo #772414).
      
      It was always the case that multiple files could provide the same UUID
      (both in case of keyfile and ifcfg-rh). For keyfile plugin, if a profile in
      read-only storage in /usr/lib gets modified, then it gets actually stored in
      /etc (or /run, if the profile is unsaved).
      
      --
      
      While at it, make /etc/network/interfaces profiles for ifupdown plugin reloadable.
      
      --
      
      https://bugzilla.gnome.org/show_bug.cgi?id=772414
      https://bugzilla.gnome.org/show_bug.cgi?id=744711
      https://bugzilla.redhat.com/show_bug.cgi?id=1674545
      d35d3c46
  2. 17 Mar, 2017 1 commit
  3. 23 Nov, 2016 1 commit
  4. 02 Sep, 2016 1 commit
  5. 05 Apr, 2016 2 commits
  6. 26 Mar, 2016 1 commit
  7. 10 Aug, 2015 1 commit
  8. 23 Jan, 2014 3 commits
  9. 15 Nov, 2013 1 commit
  10. 14 Jun, 2013 1 commit
    • Dan Winship's avatar
      core: add monitor-connection-files=false and ReloadConnections · 1f818510
      Dan Winship authored
      Add a "monitor-connection-files" config option, which can be set to
      "false" to disable automatic reloading of connections on file change.
      
      To go with this, add a new ReloadConnections method on
      o.fd.NM.Settings that can be used to manually reload connections, and
      add an nm-cli command to call it.
      1f818510
  11. 28 May, 2013 1 commit
    • Dan Williams's avatar
      settings: implement ability to add connections without saving them to disk · 8a79fb1d
      Dan Williams authored
      We don't always want to immediately write new connections to disk, to
      facilitate "runtime" or "temporary" connections where an interface's
      runtime config isn't backed by on-disk config.  Also, just because
      an interface's configuration is changed doesn't necessarily mean
      that new configuration should be written to disk either.
      
      Add D-Bus methods for adding new connections and for updating existing
      connections that don't immediately save the connection to disk.
      
      Also add infrastructure to indicate to plugins that the new connection
      shouldn't be immediately saved if the connection was added with the
      new method.
      8a79fb1d
  12. 10 Apr, 2013 1 commit
  13. 06 Aug, 2011 1 commit
  14. 22 Apr, 2011 1 commit
    • Dan Williams's avatar
      settings: add a GetConnectionByUuid method · 4cae0bb0
      Dan Williams authored
      If the client knows the UUID, add a convenience function to get
      the connection path directly, instead of having to iterate the
      whole connection list and get each connection's details and then
      check the UUID.
      4cae0bb0
  15. 29 Oct, 2010 1 commit
  16. 26 Aug, 2010 1 commit
    • Dan Williams's avatar
      core: consolidate all permissions checking into main D-Bus interface · 3945f75b
      Dan Williams authored
      Moves the system settings permissions checking into the core service's
      permissions checking, which at the same time enables 3-way permission
      reporting (yes, no, auth) instead of the old yes/no that we had for
      system settings permissions before.  This allows UI to show a lock
      icon or such when the user could authenticate to gain the permission.
      
      It also moves the wifi-create permissions' namespace to the main
      namespace (not .settings) since they really should be checked before
      starting a shared wifi connection, rather than having anything to do
      with the settings service.
      3945f75b
  17. 07 Aug, 2010 1 commit
    • Daniel Gnoutcheff's avatar
      NetworkMangerSettings -> NetworkManager.Settings · f98e2528
      Daniel Gnoutcheff authored
      Just for consistency, make settings related stuff live under the
      org.freedesktop.NetworkManager namespace, rather than its own
      org.freedesktop.NetworkManagerSettings namespace. Renames are done for
      DBus interface names, DBus object paths, and polkit actions.
      f98e2528
  18. 06 Aug, 2010 1 commit
    • Daniel Gnoutcheff's avatar
      nm-glib/DBus: merge nm-settings{,-system} iface · da6816a0
      Daniel Gnoutcheff authored
      Much as with nm-remote-settings and nm-remote-settings-system, the
      removal of user settings services means there is no more need for
      separate interfaces for user and system settings services.
      
      In libnm-glib, this commit merges everything in
      nm-settings-system-interface into nm-settings-interface.  Alongside with
      that, we merge everything in the
      org.freedesktop.NetworkManagerSettings.System DBus interface into
      org.freedesktop.NetworkManagerSettings.
      da6816a0
  19. 13 Jul, 2010 1 commit
  20. 02 Jul, 2010 1 commit
  21. 24 Aug, 2009 1 commit
  22. 23 Jul, 2009 1 commit
    • Dan Williams's avatar
      libnm-glib: implement new settings interfaces · 0d69dfe3
      Dan Williams authored
      The old NMExportedConnection was used for both client and server-side classes,
      which was a mistake and made the code very complicated to follow.  Additionally,
      all PolicyKit operations were synchronous, and PK operations can block for a
      long time (ie for user input) before returning, so they need to be async.  But
      NMExportedConnection and NMSysconfigConnection didn't allow for async PK ops
      at all.
      
      Use this opportunity to clean up the mess and create GInterfaces that both
      server and client objects implement, so that the connection editor and applet
      can operate on generic objects like they did before (using the interfaces) but
      can perform specific operations (like async PK verification of callers) depending
      on whether they are local or remote or whatever.
      0d69dfe3
  23. 04 Apr, 2008 1 commit
  24. 28 Feb, 2008 1 commit
  25. 09 Sep, 2007 1 commit
    • Dan Williams's avatar
      2007-09-09 Dan Williams <dcbw@redhat.com> · b1872d9a
      Dan Williams authored
      	Stupid mistake on my part; object path and interface for settings service
      	and connection objects can be the same, only the service name must be
      	different for the system and user settings services.
      
      	* include/NetworkManager.h
      	  src/nm-manager.c
      	  introspection/nm-settings-connection.xml
      	  introspection/nm-settings.xml
      	  libnm-glib/nm-settings.c
      		- (nm_connection_settings_init, query_user_connections,
      		   new_connection_cb): Unify NetworkManagerSettings and Connection
      		   interface name and object path
      
      
      
      git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@2772 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
      b1872d9a
  26. 29 Aug, 2007 1 commit
  27. 03 Aug, 2007 1 commit