1. 01 Aug, 2014 6 commits
    • Dan Winship's avatar
      libnm: add NetworkManager.h, disallow including individual headers · d0b05b34
      Dan Winship authored
      Add NetworkManager.h, which includes all of the other NM header, and
      require all external users of libnm to use that rather than the
      individual headers.
      (An exception is made for nm-dbus-interface.h,
      nm-vpn-dbus-interface.h, and nm-version.h, which can be included
    • Dan Winship's avatar
      libnm: make the the use of GInitable mandatory · 258e74eb
      Dan Winship authored
      Remove _nm_object_ensure_inited(), etc; objects that implement
      GInitable are now mandatory-to-init().
      Remove constructor() implementations that sometimes return NULL; do
      all the relevant checking in init() instead.
      Make nm_client_new() and nm_remote_settings_new() take a GCancellable
      and a GError**.
    • Dan Winship's avatar
      libnm, core, cli, tui: fix the capitalization of various types · 3ac0f528
      Dan Winship authored
      GLib/Gtk have mostly settled on the convention that two-letter
      acronyms in type names remain all-caps (eg, "IO"), but longer acronyms
      become initial-caps-only (eg, "Tcp").
      NM was inconsistent, with most long acronyms using initial caps only
      (Adsl, Cdma, Dcb, Gsm, Olpc, Vlan), but others using all caps (DHCP,
      PPP, PPPOE, VPN). Fix libnm and src/ to use initial-caps only for all
      three-or-more-letter-long acronyms (and update nmcli and nmtui for the
      libnm changes).
    • Dan Winship's avatar
      all: port everything to libnm · a7c4d53d
      Dan Winship authored
      Since the API has not changed at this point, this is mostly just a
      matter of updating Makefiles, and changing references to the library
      name in comments.
      NetworkManager cannot link to libnm due to the duplicated type/symbol
      names. So it links to libnm-core.la directly, which means that
      NetworkManager gets a separate copy of that code from libnm.so.
      Everything else links to libnm.
    • Thomas Haller's avatar
      cli: fix warning about uninitialized value · f0d40201
      Thomas Haller authored
      gcc warns:
          make[4]: Entering directory `./NetworkManager/cli/src'
            CC       connections.o
          connections.c: In function ‘complete_connection_by_type’:
          connections.c:4235:18: error: ‘mtu_int’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
               g_object_set (s_wired, NM_SETTING_WIRED_MTU, mtu_int, NULL);
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
    • Thomas Haller's avatar
      cli: remove unused static struct nmc_mobile_settings · 996b31ec
      Thomas Haller authored
      clang warns:
          make[4]: Entering directory `./NetworkManager/cli/src'
            CC       connections.o
          connections.c:2206:23: error: unused variable 'nmc_mobile_settings' [-Werror,-Wunused-const-variable]
          static const NameItem nmc_mobile_settings [] = {
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
  2. 30 Jul, 2014 1 commit
    • Dan Winship's avatar
      clients: reorganize source tree, put all the installed clients together · 3d25d704
      Dan Winship authored
      Create a new clients/ subdirectory at the top level, and move cli/ and
      tui/ into it, as well as nm-online.c (which was previously in test/,
      which made no sense).
      cli/ was split into two subdirectories, src/ and completion/. While
      this does simplify things (given that the completion file and the
      binary both need to be named "nmcli"), it bloats the source tree, and
      we can work around it by just renaming the completion file at install
      time. Then we can combine the two directories into one and just have
      it all under clients/cli/.
  3. 24 Jun, 2014 1 commit
  4. 19 Jun, 2014 3 commits
  5. 06 Jun, 2014 3 commits
  6. 04 Jun, 2014 7 commits
  7. 30 May, 2014 1 commit
  8. 28 May, 2014 2 commits
  9. 23 May, 2014 1 commit
  10. 15 May, 2014 1 commit
  11. 22 Apr, 2014 1 commit
    • Jiří Klimeš's avatar
      nmcli: improve setting connection.secondaries property · 645f0204
      Jiří Klimeš authored
      - check if the values being set are existing connections
      - also allow specifying connections by names, translating them transparently
         to UUIDs.
      - nmcli-specific section for 'describe' command added
      (We use a global nm_cli variable in nmc_property_connection_set_secondaries())
  12. 03 Apr, 2014 1 commit
  13. 31 Mar, 2014 1 commit
  14. 17 Mar, 2014 1 commit
  15. 12 Mar, 2014 2 commits
  16. 28 Feb, 2014 6 commits
    • Jiří Klimeš's avatar
      cli: update 'nmcli con modify' help · ebb60130
      Jiří Klimeš authored
    • Jiří Klimeš's avatar
      cli: update 'remove' command description for 'nmcli con edit' · a5673d11
      Jiří Klimeš authored
      to reflect that user can specify a value or index to remove values.
    • Jiří Klimeš's avatar
      cli: support removing items from container-type properties in 'nmcli con modify' · c1ace1b5
      Jiří Klimeš authored
      nmcli con modify -<property>.<setting> <value>
      'value' can be empty ("") to remove the whole property value value (in this
      case the behaviour is the same as without '-').
      Or the 'value' is an index of the item to remove, or an option name (for a few
      properties that have option names, like bond.options or ethernet.s390-options).
      $ nmcli con mod myeth ipv4.dns ""
      ---> ipv4.dns:,,,
      $ nmcli con mod myeth -ipv4.dns 1
      ---> ipv4.dns:,,
      ---> bond.options: mode=balance-rr
      $ nmcli con mod bond0 +bond.options "mii=500, downdelay=800"
      ---> bond.options: downdelay=800,miimon=500,mode=balance-rr
      $ nmcli con mod bond0 -bond.options downdelay
      ---> bond.options: miimon=500,mode=balance-rr
    • Jiří Klimeš's avatar
      cli: allow modifying multiple properties by 'nmcli con modify' · a1c3021a
      Jiří Klimeš authored
      This is necessary especially for cases where properties depend on each other.
      So you need to set them in one command, else the profile won't validate.
      nmcli con mod em1-1 ipv4.method manual ipv4.addr ","
      nmcli con mod profile ipv4.method link-local ipv4.addr ""
    • Jiří Klimeš's avatar
      cli: set vs. append property value by 'nmcli con modify' (rh #1044027) · 431b7582
      Jiří Klimeš authored
      Previously 'nmcli con modify' appended values for multi-value properties.
      This commit makes 'nmcli con modify' overwrite the whole value. You can
      choose appending values by prefixing the setting.property with '+' sign.
      For simple (not container) properties the behaviour is the same both with
      and without the '+', of course.
        nmcli connection modify [+]<setting>.<property <value>
      ---> ipv4.dns =
      $ nmcli connection modify my-em1 ipv4.dns
      ---> ipv4.dns =
      $ nmcli connection modify my-em1 +ipv4.dns
      ---> ipv4.dns =
    • Jiří Klimeš's avatar
      cli: allow temporary connection modification by 'nmcli con modify' · a8e6094e
      Jiří Klimeš authored
      nmcli connection modify [--temporary] ...
  17. 27 Feb, 2014 1 commit
    • Thomas Haller's avatar
      trivial: more wrong compiler warnings · 7d73ee75
      Thomas Haller authored
        connection_parser.c: In function 'make_ip4_setting':
        connection_parser.c:660:33: error: 'method' may be used uninitialized in this function [-Werror=maybe-uninitialized]
          if (!is_static_block && strstr (method, "dhcp")) {
        connections.c: In function ‘load_cmd_line_edit_lib’:
        connections.c:5744:17: error: ‘module’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
          g_module_close (module);
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
  18. 13 Feb, 2014 1 commit