1. 01 Aug, 2014 9 commits
    • Dan Winship's avatar
      libnm: add NetworkManager.h, disallow including individual headers · d0b05b34
      Dan Winship authored
      Add NetworkManager.h, which includes all of the other NM header, and
      require all external users of libnm to use that rather than the
      individual headers.
      
      (An exception is made for nm-dbus-interface.h,
      nm-vpn-dbus-interface.h, and nm-version.h, which can be included
      separately.)
      d0b05b34
    • Dan Winship's avatar
      libnm: make the the use of GInitable mandatory · 258e74eb
      Dan Winship authored
      Remove _nm_object_ensure_inited(), etc; objects that implement
      GInitable are now mandatory-to-init().
      
      Remove constructor() implementations that sometimes return NULL; do
      all the relevant checking in init() instead.
      
      Make nm_client_new() and nm_remote_settings_new() take a GCancellable
      and a GError**.
      258e74eb
    • Dan Winship's avatar
      libnm, core, cli, tui: fix the capitalization of various types · 3ac0f528
      Dan Winship authored
      GLib/Gtk have mostly settled on the convention that two-letter
      acronyms in type names remain all-caps (eg, "IO"), but longer acronyms
      become initial-caps-only (eg, "Tcp").
      
      NM was inconsistent, with most long acronyms using initial caps only
      (Adsl, Cdma, Dcb, Gsm, Olpc, Vlan), but others using all caps (DHCP,
      PPP, PPPOE, VPN). Fix libnm and src/ to use initial-caps only for all
      three-or-more-letter-long acronyms (and update nmcli and nmtui for the
      libnm changes).
      3ac0f528
    • Dan Winship's avatar
      libnm: remove all deprecated functions and types · 054c12ea
      Dan Winship authored
      Remove deprecated functions and enum types.
      
      For now, deprecated properties are still around, because removing them
      would cause warnings when talking to older implementations.
      054c12ea
    • Dan Winship's avatar
      all: port everything to libnm · a7c4d53d
      Dan Winship authored
      Since the API has not changed at this point, this is mostly just a
      matter of updating Makefiles, and changing references to the library
      name in comments.
      
      NetworkManager cannot link to libnm due to the duplicated type/symbol
      names. So it links to libnm-core.la directly, which means that
      NetworkManager gets a separate copy of that code from libnm.so.
      Everything else links to libnm.
      a7c4d53d
    • Thomas Haller's avatar
      cli: fix warning in parse_output_fields() about strict-overflow · ef242731
      Thomas Haller authored
      gcc warns:
      
          make[4]: Entering directory `./NetworkManager/cli/src'
            CC       utils.o
          utils.c: In function ‘parse_output_fields’:
          utils.c:707:7: error: assuming signed overflow does not occur when simplifying conditional to constant [-Werror=strict-overflow]
              if (found) {
                 ^
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      ef242731
    • Thomas Haller's avatar
      cli: fix warning about uninitialized value · f0d40201
      Thomas Haller authored
      gcc warns:
      
          make[4]: Entering directory `./NetworkManager/cli/src'
            CC       connections.o
          connections.c: In function ‘complete_connection_by_type’:
          connections.c:4235:18: error: ‘mtu_int’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
               g_object_set (s_wired, NM_SETTING_WIRED_MTU, mtu_int, NULL);
                            ^
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      f0d40201
    • Thomas Haller's avatar
      cli: remove unused static struct nmc_mobile_settings · 996b31ec
      Thomas Haller authored
      clang warns:
      
          make[4]: Entering directory `./NetworkManager/cli/src'
            CC       connections.o
          connections.c:2206:23: error: unused variable 'nmc_mobile_settings' [-Werror,-Wunused-const-variable]
          static const NameItem nmc_mobile_settings [] = {
                                ^
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      996b31ec
    • Thomas Haller's avatar
      all: add compatibility macros to ignore deprecation warnings for clang · b461bf54
      Thomas Haller authored
      For clang, the defines G_GNUC_BEGIN_IGNORE_DEPRECATIONS and
      G_GNUC_END_IGNORE_DEPRECATIONS are not working. Redefine them
      for clang in our glib compatibility wrapper.
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      b461bf54
  2. 30 Jul, 2014 1 commit
    • Dan Winship's avatar
      clients: reorganize source tree, put all the installed clients together · 3d25d704
      Dan Winship authored
      Create a new clients/ subdirectory at the top level, and move cli/ and
      tui/ into it, as well as nm-online.c (which was previously in test/,
      which made no sense).
      
      cli/ was split into two subdirectories, src/ and completion/. While
      this does simplify things (given that the completion file and the
      binary both need to be named "nmcli"), it bloats the source tree, and
      we can work around it by just renaming the completion file at install
      time. Then we can combine the two directories into one and just have
      it all under clients/cli/.
      3d25d704