1. 06 Jun, 2018 2 commits
  2. 05 Jun, 2018 3 commits
  3. 01 Jun, 2018 6 commits
    • Thomas Haller's avatar
      cli: rework printing of general active-connection properties · 68fa68b3
      Thomas Haller authored
      use nmc_print() for the job.
      Also, localize non-terse output.
      Also, fix bug with
        $ nmcli c s /org/freedesktop/NetworkManager/ActiveConnection/1
      if active connection #1 is invisible to the user.
      Also, previously, fill_output_active_connection() wrongly tries to
      write to a field that doesn't exist:
        set_val_strc (arr, 13-idx_start, s_con ? nm_setting_connection_get_slave_type (s_con) : NULL);
    • Thomas Haller's avatar
      cli: sort active-connection for `nmcli connection show $PROFILE` output · b990cee0
      Thomas Haller authored
      There might be multiple active connections. Output them in a defined order.
    • Thomas Haller's avatar
      cli: rework printing of `nmcli connection` for multiple active connections · a1b25a47
      Thomas Haller authored
      The output of `nmcli connection show` contains also information about
      whether the profile is currently active, for example the device and
      the current (activation) state.
      Even when a profile can be activated only once (without supporting
      mutiple activations at the same time), there are moments when a
      connection is activating and still deactivating on another device.
      NetworkManager ensures in the case with single activations that
      a profile cannot be in state "activated" multiple times. But that
      doesn't mean, that one profile cannot have multiple active connection
      which reference it. That was already handled wrongly before, because
      `nmcli connection show` would only search the first matching
      active-connection. That is, it would arbitrarily pick an active
      connection in case there were multiple and only show activation
      state about one.
      Furthermore, we will soon also add the possibility, that a profile can be
      active multiple times (at the same time). Especially then, we need to
      extend the output format to show all the devices on which the profile is
      currently active.
      Rework printing the connection list to use nmc_print(), and fix various
      - as discussed, a profile may have multiple active connections at each time.
        There are only two possibilities: if a profile is active multiple
        times, show a line for each activation, or otherwise, show the
        information about multiple activations combined in one line, e.g. by
        printing "DEVICE eth0,eth1". This patch, does the former.
        We will now print a line for each active connection, to show
        all the devices and activation states in multiple lines.
        Yes, this may result in the same profile being printed multiple times.
        That is a change in behavior, and inconvenient if you do something
           for UUID in $(nmcli connection show | awk '{print$2}'); do ...
        However, above is anyway wrong because it assumes that there are no
        spaces in the connection name. The proper way to do this is like
           for UUID in $(nmcli -g UUID connection show); do ...
        In the latter case, whenever a user selects a subset of fields
        (--fields, --get) which don't print information about active connections,
        these multiple lines are combined. So, above still works as expected,
        never returning duplicate UUIDs.
      - if a user has no permissions to see a connection, we previously
        would print "<invisible> $NAME". No longer do this but just print
        the ID was it is reported by the active-connection. If the goal
        of this was to prevent users from accidentally access the non-existing
        connection by $NAME, then this was a bad solution, because a script
        would instead try to access "<invisible> $NAME". This is now solved
        better by hiding the active connection if the user selects "-g NAME".
      - the --order option now sorts according to how the fields are shown.
        For example, with --terse mode, it will evaluate type "802-11-wireless"
        but with pretty mode it will consider "wifi". This may change the
        ordering in which connections are shown. Also, for sorting the name,
        we use g_utf8_collate() because it's unicode.
    • Thomas Haller's avatar
    • Thomas Haller's avatar
      clients/tests: add test for showing invisible connection in nmcli · 3645be64
      Thomas Haller authored
      It also shows how we handle invisible connections wrongly, when we have
      multiple active-connections that reference them.
    • Thomas Haller's avatar
  4. 28 May, 2018 3 commits
    • Thomas Haller's avatar
      clients/tests: run nmcli commands in parallel · baaab522
      Thomas Haller authored
      Most nmcli calls from clients/tests don't change the server's state.
      Hence, they can easily run in parallel.
      Run tests in parallel. No longer handle one nmcli invocation after the other.
      Instead, spawn groups of processes in parallel, and track the pending jobs.
      Only at certain synchronization points we call self.async_wait() to
      wait for all previous jobs to complete.
      This reduces the test time on my machine from 7 to 3 seconds. Arguably,
      that matters less during a full `make check -j 8`, because the entire
      set of tests anyway takes longer than 7 seconds. So when running the
      entire test suite, the machine is kept busy anyway. It matters however
      for manual invocations.
    • Beniamino Galvani's avatar
      cli: fix property matching · 1f7780cb
      Beniamino Galvani authored
      @ret was not initialized when there was only one partial match.
      Also, refactor the code to return all matching values.
      Fixes: 3fd9bf9d
    • Thomas Haller's avatar
      clients/tests: refactor by moving replace-text helper function · 78e877ee
      Thomas Haller authored
      Have less logic in TestNmcli.
  5. 27 May, 2018 1 commit
    • Thomas Haller's avatar
      clients/tests: generate Makefile.am for expected files · ee85151a
      Thomas Haller authored
      The developer can re-generate .expected files with
       $ NM_TEST_REGENERATE=1 ./clients/tests/test-client.py
      Note that these files are also dist-ed, so that the tests also work
      from a source-tarball. For that, we need to add them to EXTRA_DIST.
      Previously, this was done manually in the base Makefile.am file. This
      was cumbersome, because when adding a new test, the developer would need
      to manually add the files.
      Now, let the test (with NM_TEST_REGENERATE=1) also generate a makefile
  6. 25 May, 2018 2 commits
  7. 24 May, 2018 7 commits
  8. 14 May, 2018 4 commits
  9. 11 May, 2018 1 commit
    • Thomas Haller's avatar
      clients/tests: add python test script for nmcli tests · d4093a3a
      Thomas Haller authored
      Add a test which runs nmcli against our stub NetworkManager
      service and compares the output.
      The output formats of nmcli are complicated and not easily understood.
      For example how --mode tabular|multiline interacts with selecting
      output-fields (--fields) and output modes ([default]|--terse|--pretty).
      Also, there are things like `nmcli connection show --order $FIELD_SPEC`.
      We need unit tests to ensure that we don't change the output