1. 17 Dec, 2019 1 commit
  2. 16 Dec, 2019 2 commits
  3. 14 Dec, 2019 2 commits
    • Beniamino Galvani's avatar
      device: don't reapply IP configuration if the ifindex is missing · a3ed90bd
      Beniamino Galvani authored
      Assertions will fail in ip_config_merge_and_apply() if the device
      doesn't have an ifindex. Reproducible with:
      
       $ nmcli connection add type ovs-bridge ifname ovs0 ipv4.method disabled ipv6.method disabled
       Connection 'ovs-bridge-ovs0' (1d5e794b-10ad-4b2b-aa7c-5ca7e34b0a55) successfully added
      
       $ nmcli device reapply ovs0
       Error: Reapplying connection to device '(null)' (/org/freedesktop/NetworkManager/Devices/16) failed: Remote peer disconnected
      
       $ journalctl -u NetworkManager -e
       ...
       NetworkManager[73824]: nm_ip4_config_add_dependent_routes: assertion 'ifindex > 0' failed
       systemd[1]: NetworkManager.service: Main process exited, code=dumped, status=5/TRAP
       ...
      
      (cherry picked from commit 6d6e1402)
      (cherry picked from commit f1d48539)
      a3ed90bd
    • Beniamino Galvani's avatar
      ovs: check state before starting ip configuration after link change · 65d37a3b
      Beniamino Galvani authored
      When the link becomes available, check that the device is in the
      ip-config state before starting ip configuration. Also, reset the
      'waiting_for_interface' flag when the device deactivates.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1781165
      !358
      (cherry picked from commit 0738c104)
      (cherry picked from commit 33812995)
      65d37a3b
  4. 11 Dec, 2019 4 commits
  5. 09 Dec, 2019 2 commits
  6. 05 Dec, 2019 1 commit
  7. 29 Nov, 2019 2 commits
  8. 27 Nov, 2019 2 commits
  9. 25 Nov, 2019 3 commits
  10. 22 Nov, 2019 6 commits
  11. 21 Nov, 2019 2 commits
  12. 20 Nov, 2019 3 commits
  13. 19 Nov, 2019 1 commit
    • Thomas Haller's avatar
      libnm: fix annotation for out arguments of nm_bridge_vlan_get_vid_range() · 8b4f7a9e
      Thomas Haller authored
      Workaround:
      
      def br_get_vid_range(bridge_vlan):
          try:
              (is_range, vid_start, vid_end) = bridge_vlan.get_vid_range()
          except TypeError as e:
              s = bridge_vlan.to_str()
              s = s.split(' ', 1)
              s = s[0]
              s = s.split('-', 2)
              vid_start = int(s[0])
              if len(s) == 2:
                  vid_end = int(s[1])
              else:
                  vid_end = vid_start
              is_range = (vid_start == vid_end)
          return (vid_start, vid_end)
      
      Fixes: da204257 ('all: support bridge vlan ranges')
      (cherry picked from commit c68c199e)
      8b4f7a9e
  14. 18 Nov, 2019 9 commits