We don't have vala-tools in Fedora Rawhide (not sure when it went
away) but we need vapigen which is in vala rpm in Rawhide now.

Filip Pokryvka authored Jan 10, 2022 and Thomas Haller committed Jan 10, 2022

Signed-off-by: Filip Pokryvka <fpokryvk@redhat.com>

41937748

Copr environment doesn't have ip_gre module which is in fact not
needed as if missing tests are skipped anyway.

Due to a bug we would wrongly skip over patches that should
be backported. Fix it.

The existing find-backports.sh script seems to not work well.
For example, it does not include fixes for patches that are in
the common history of the current branch and upstream. This script is
supposed to work better.

!498

Fernando Fernández Mancera authored May 04, 2020 and Thomas Haller committed May 04, 2020

Environments like Copr cannot install the dependencies during the script
execution. In order to solve this, this patch introduces
"INSTALL_DEPENDENCIES" environment variable.

Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>

!490

Fetch both from github and gitlab, and also fetch the references for the
merge-requests/pull-requests.

In practice is github just a mirror of gitlab, so seemingly it wouldn't
make sense to fetch from there. However:

  - by adding github as a remote, we can preferably fetch from there.
    I think that is faster than our gitlab at freedesktop.org. Thank
    you, Microsoft!

  - pull requests against github are indeed not found in gitlab.

We need to fetch all kinds of remote references, so that the referenced
commits are in the git repository. Also, we need to fetch them under
various name, so that these references are available to CI.

For example, when someone opens a merge-request from their fork on
gitlab/github, the commit is usually not not referenced by regular
branches on gitlab/github. Hence, we couldn't schedule CI for those
commit. Also fetch the special references for these.

Also, don't use `timeout` to fetch the repository.

Vladimír Beneš authored Sep 27, 2019 and Thomas Haller committed Sep 27, 2019

When compiling on Fedora with 2GB large tmpfs there is not enough
space for it. We need to switch to some larger partition.

!294

On RHEL 7.7 python3 is available but doesn't have gobject-introspection.

!125

Don't enable all repos. It fails with Fedora:

    + yum install 'perl(XML::Parser)' 'perl(YAML)' /usr/bin/dbus-launch ModemManager-glib-devel audit-libs-devel automake bluez-libs-devel dbus-devel dbus-glib-devel dbus-python dhclient gettext-devel git glib2-devel gnutls-devel gobject-introspection-devel gtk-doc intltool iptables jansson-devel libasan libcurl-devel libgudev1-devel libndp-devel libnl3-devel libpsl-devel libselinux-devel libsoup-devel libubsan libudev-devel libuuid-devel newt-devel nss-devel pkgconfig polkit-devel ppp-devel pygobject3-base python3 readline-devel rpm-build strace systemd teamd-devel vala-tools valgrind wireless-tools-devel '--enablerepo=*' --skip-broken -y
    Fedora 30 openh264 (From Cisco) - x86_64        195  B/s | 543  B     00:02
    Fedora 30 openh264 (From Cisco) - x86_64        228 kB/s | 1.6 kB     00:00
    Importing GPG key 0xCFC659B9:
     Userid     : "Fedora (30) <fedora-30-primary@fedoraproject.org>"
     Fingerprint: F1D8 EC98 F241 AAF2 0DF6 9420 EF3C 111F CFC6 59B9
     From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-30-x86_64
    Fedora 30 openh264 (From Cisco) - x86_64        1.7 kB/s | 5.1 kB     00:03
    Fedora 30 openh264 (From Cisco) - x86_64 - Debu 206  B/s | 543  B     00:02
    Fedora 30 openh264 (From Cisco) - x86_64 - Debu 1.6 MB/s | 1.6 kB     00:00
    Importing GPG key 0xCFC659B9:
     Userid     : "Fedora (30) <fedora-30-primary@fedoraproject.org>"
     Fingerprint: F1D8 EC98 F241 AAF2 0DF6 9420 EF3C 111F CFC6 59B9
     From       : /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-30-x86_64
    Fedora 30 openh264 (From Cisco) - x86_64 - Debu 446  B/s | 1.7 kB     00:03
    Fedora Modular 30 - x86_64 - Debug              222 kB/s | 843 kB     00:03
    Fedora Modular 30 - Source                       44 kB/s | 145 kB     00:03
    Fedora - Modular Rawhide - Developmental packag 157 kB/s | 661 kB     00:04
    Fedora - Modular Rawhide - Debug                113 kB/s | 313 kB     00:02
    Fedora - Modular Rawhide - Source                45 kB/s | 145 kB     00:03
    Fedora - Rawhide - Developmental packages for t 211 kB/s | 1.2 MB     00:06
    Failed to synchronize cache for repo 'rawhide'
    Error: Failed to synchronize cache for repo 'rawhide'

Only enable "rhel-8-buildroot" on RHEL8.

See-also: 72191bbe

find-backports.sh only works because we craft commit messages with
necessary information. In particular the "Fixes" and cherry-picked-from
messages. That means, it relies on our git history to maintained in
a suitable manner so that the script can gather the necessary
information.

Likewise, we have a particular scheme how we do releases, how versions
are numbered, how stable branches and release tags are called, etc.

Exploit that, to allow for simpler calling convention for
find-backports.sh script:

  $ contrib/rh-utils/find-backports.sh 1.14

will automatically complete to

  $ contrib/rh-utils/find-backports.sh 1.14.0 nm-1-14 master

On rhel-8, python2 is available and in the path, but it doesn't
actually work because required modules are missing.

- moves installing libubsan to the previous yum-install.
  Since we already pass --skip-broken, we don't need the
  "|| true".
- also, sort the packages
- also, combine "set" lines

Fix installing also noarch packages. I think they were omitted wrongly
before, and installing them now might break existing assumptions during
CI (like, which packages are installed and which not).

But since the script anyway didn't ensure which RPMs are installed
prevoiusly, it was very likely that packages like NetworkManager-config-server
was already installed. CI needs to always anticipate that such packages
may be installed and act accordingly. Usually, this just means to
explicitly overwrite the configuration snippets provided by these
packages.

This is needed to build on RHEL8 where some packages are in the
buildroot repo and not all dependencies are available.

It is needed on RHEL8

  $ contrib/rh-utils/find-backports.sh 1.12.0 origin/nm-1-12 origin/master origin/nm-1-14

During the test build we enabled "--with-netconfig=yes".

Since commit "5b36585a build/autotools: fail configure if
netconfig/resolveconf tool is not found", when specifying
"--with-netconfig=yes" the user is required to have netconfig
installed (so that the path can be detected). Otherwise it fails
with

    checking for netconfig... no
    configure: error: cannot find netconfig in path. Set the path explicitly via --with-netconfig=PATH.

The correct way is to explicitly specify the path. In that
case, it's OK that the file doesn't actually exist.

In the final version which was merged, the check is non-fatal and
has to be enabled explicitly to fail. See "aa8a7559 build: merge
branch 'th/check-gtk-doc-behavior'".

This reverts commit cd8b1cc2.

For libnm, we use opaque types. gtk-doc has/had an issue parsing
this code, and generates suboptimal documentation.

There is a merge request against gtk-doc to address that [1].

However, there is also a `make check` test, which tries to determine
whether gtk-doc is suitable [2].

When building for beaker, we don't need this check. Also, because likely
beaker is not up to the task.

[1] https://gitlab.gnome.org/GNOME/gtk-doc/merge_requests/2
[2] https://github.com/NetworkManager/NetworkManager/pull/196