1. 29 May, 2019 7 commits
    • Thomas Haller's avatar
      build: disable "-Wunknown-pragmas" warning · a307bd6e
      Thomas Haller authored
      clang on CentOS 7.6 (3.4.2-9.el7) warns:
      
            CC       clients/tui/newt/clients_tui_newt_libnmt_newt_a-nmt-newt-button.o
          In file included from ../clients/tui/newt/nmt-newt-button.c:26:
          In file included from ../shared/nm-default.h:280:
          ../shared/nm-glib-aux/nm-macros-internal.h:1617:2: error: unknown warning group -Wstringop-truncation, ignored [-Werror,-Wunknown-pragmas]
                  NM_PRAGMA_WARNING_DISABLE ("-Wstringop-truncation");
                  ^
          ../shared/nm-glib-aux/nm-macros-internal.h:419:9: note: expanded from macro NM_PRAGMA_WARNING_DISABLE
                  _Pragma(_NM_PRAGMA_WARNING_DO(warning))
                  ^
          <scratch space>:109:25: note: expanded from here
           GCC diagnostic ignored "-Wstringop-truncation"
                                  ^
      
      This warning totally defeats the purpose of why we use the pragma in the
      first place.
      a307bd6e
    • Thomas Haller's avatar
      clients/tests: increase timeout waiting for stub D-Bus service · 7af1fc80
      Thomas Haller authored
      I saw this timeout reached in our gitlab-ci. I think it was due to the machine
      being busy and taking more than 2 seconds. Assuming the timeout was just too short,
      increase it to 4 seconds.
      7af1fc80
    • Thomas Haller's avatar
      platform: avoid compiler error passing NMP_OBJECT_CAST_OBJ_WITH_IFINDEX() to nm_hash_update_vals() · 5113c5bd
      Thomas Haller authored
      Clang (3.4.2-9.el7) on CentOS 7.6 fails related to nm_hash_update_vals().
      
      Clang seems to dislike passing certain complex arguments to typeof().
      I'd prefer to fix nm_hash_update_vals() to not have this problem,
      but I don't know how.
      
      This works around the issue.
      5113c5bd
    • Thomas Haller's avatar
      platform: make nm_platform_kernel_support_get() macro an inline function · ad06cc78
      Thomas Haller authored
      clang (3.4.2-9.el7) on CentOS 7.6 fails related to nm_hash_update_vals().
      
      I am not even quoting the error message, it's totally non-understandable.
      
      nm_hash_update_vals() uses typeof(), and in some obscure cases, clang dislikes
      when the argument itself is some complex macro. I didn't fully understand why,
      but this works around it.
      
      I would prefer to fix nm_hash_update_vals() to not have this limitation.
      But I don't know how.
      
      There is probably no downside to have this an inline function instead of
      a macro.
      ad06cc78
    • Thomas Haller's avatar
      shared: fix _NM_ENSURE_TYPE_CONST() for const pointers with clang · 3d42b2f1
      Thomas Haller authored
      Clang 3.4.2-9.el7 on CentOS7.6 complains about missing generic type match:
      
          ../dispatcher/nm-dispatcher.c:243:2: error: controlling expression type 'const Request *const' (aka 'const struct Request *const') not compatible with any generic association type
                  _LOG_R_D (request, "start running ordered scripts...");
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
      Fixes: 17dc6a9d ('shared: add _NM_ENSURE_TYPE_CONST()')
      3d42b2f1
    • Thomas Haller's avatar
    • Thomas Haller's avatar
      ifcfg-rh: drop unused "nm-inotify-helper.h" · 15d87f2d
      Thomas Haller authored
      This code is now unused.
      
      Also, it does not seem state of the art to me
      anymore.
      
      Drop it, it could always be resurrected if need by, but maybe
      GFileMonitor could be used instead.
      15d87f2d
  2. 28 May, 2019 25 commits
  3. 27 May, 2019 8 commits