1. 17 Mar, 2014 2 commits
  2. 14 Mar, 2014 4 commits
    • Dan Williams's avatar
      platform: fix crash if link has no name after 5e935dfd · 893735c8
      Dan Williams authored
      When a VPN goes down, like at suspend, and the link has already
      disappeared, the new platform logging code tries to print the
      link information using a link object with only the ifindex filled
      in.  When adding/removing/changing links, internal code often fills
      in just the ifindex (becuase that's all you need).  Thus
      to_string_link() will always fail if that operation fails.
          at platform/nm-linux-platform.c:688
          at platform/nm-linux-platform.c:1835
          at vpn-manager/nm-vpn-connection.c:274
      Work around that for now and live with the warnings until
      we decide what to actually do about to_string_link().
    • Dan Williams's avatar
      libnm-util: fix Bridge priority default (rh #1073664) · 13c348dc
      Dan Williams authored
      Due to a misread of the kernel code, the bridge priority default
      when STP was enabled was 0x80 instead of 0x8000.
    • Thomas Haller's avatar
      trivial: fix invalid code comment · b73783b4
      Thomas Haller authored
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
    • Thomas Haller's avatar
      libnm-util: remove assert to nm_utils_ip4_netmask_to_prefix · 2f67105a
      Thomas Haller authored
      Commit 240c92dd
       added an assert
      to check that the input netmask is valid. Revert that commit for
      the most part, some changes to the test function are not reverted.
      We don't want to assert for a valid netmask, because it's
      common to read the netmask from (untrusted) user input, so we
      don't want to assert against it.
      The caller *could* validate the netmask from untrusted sources, but
      with the assert in place it cannot validate it in the most obvious way:
          prefix = nm_utils_ip4_netmask_to_prefix (netmask);
          if (netmask != nm_utils_ip4_prefix_to_netmask (prefix))
              goto fail;
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
  3. 13 Mar, 2014 10 commits
  4. 12 Mar, 2014 21 commits
  5. 11 Mar, 2014 1 commit
    • Thomas Haller's avatar
      core: refactor delete_on_deactivate in nm-device · 066ce42c
      Thomas Haller authored
      Instead of only passing the ifindex to the callback, pack
      additional data. This allows for better logging by also
      writing the g_idle_add id which allows to associate the scheduling
      with cancel calls.
      Also, this fixes that the callback could not clear the
      @delete_on_deactivate_id of the device, so that a following
      delete_on_deactivate_unschedule() would think that there is
      still something to cancel.
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
  6. 10 Mar, 2014 1 commit
  7. 07 Mar, 2014 1 commit