1. 18 Jan, 2018 1 commit
  2. 21 Sep, 2017 1 commit
  3. 29 Mar, 2017 2 commits
  4. 19 Feb, 2016 1 commit
    • Thomas Haller's avatar
      all: cleanup includes and let "nm-default.h" include "config.h" · 8bace23b
      Thomas Haller authored
      - All internal source files (except "examples", which are not internal)
        should include "config.h" first. As also all internal source
        files should include "nm-default.h", let "config.h" be included
        by "nm-default.h" and include "nm-default.h" as first in every
        source file.
        We already wanted to include "nm-default.h" before other headers
        because it might contains some fixes (like "nm-glib.h" compatibility)
        that is required first.
      
      - After including "nm-default.h", we optinally allow for including the
        corresponding header file for the source file at hand. The idea
        is to ensure that each header file is self contained.
      
      - Don't include "config.h" or "nm-default.h" in any header file
        (except "nm-sd-adapt.h"). Public headers anyway must not include
        these headers, and internal headers are never included after
        "nm-default.h", as of the first previous point.
      
      - Include all internal headers with quotes instead of angle brackets.
        In practice it doesn't matter, because in our public headers we must
        include other headers with angle brackets. As we use our public
        headers also to compile our interal source files, effectively the
        result must be the same. Still do it for consistency.
      
      - Except for <config.h> itself. Include it with angle brackets as suggested by
        https://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
      8bace23b
  5. 13 Nov, 2014 1 commit
    • Dan Winship's avatar
      all: consistently include config.h · 3bfb163a
      Dan Winship authored
      config.h should be included from every .c file, and it should be
      included before any other include. Fix that.
      
      (As a side effect of how I did this, this also changes us to
      consistently use "config.h" rather than <config.h>. To the extent that
      it matters [which is not much], quotes are more correct anyway, since
      we're talking about a file in our own build tree, not a system
      include.)
      3bfb163a
  6. 04 Sep, 2014 1 commit
    • Dan Winship's avatar
      examples: port dbus-glib-based examples to gdbus · 9e5ddb58
      Dan Winship authored
      Port the dbus-glib-based examples to GDBus.
      
      Also, don't use libnm in them at all; there's not much point in
      examples that use the D-Bus API directly if they're just going to fall
      back to libnm for the hard stuff... (And also, this avoids the problem
      that GDBus uses GVariant, while the libnm-core APIs currently still
      use GHashTables.)
      
      Also fix up some comment grammar and copyright style, and add emacs
      modelines where missing.
      
      Also rename the existing GDBus-based examples to have names ending in
      "-gdbus", not "-GDBus", since there's no reason to gratuitously
      capitalize here.
      9e5ddb58