1. 18 Jan, 2018 1 commit
  2. 14 Nov, 2017 1 commit
  3. 19 Feb, 2016 1 commit
    • Thomas Haller's avatar
      all: cleanup includes and let "nm-default.h" include "config.h" · 8bace23b
      Thomas Haller authored
      - All internal source files (except "examples", which are not internal)
        should include "config.h" first. As also all internal source
        files should include "nm-default.h", let "config.h" be included
        by "nm-default.h" and include "nm-default.h" as first in every
        source file.
        We already wanted to include "nm-default.h" before other headers
        because it might contains some fixes (like "nm-glib.h" compatibility)
        that is required first.
      
      - After including "nm-default.h", we optinally allow for including the
        corresponding header file for the source file at hand. The idea
        is to ensure that each header file is self contained.
      
      - Don't include "config.h" or "nm-default.h" in any header file
        (except "nm-sd-adapt.h"). Public headers anyway must not include
        these headers, and internal headers are never included after
        "nm-default.h", as of the first previous point.
      
      - Include all internal headers with quotes instead of angle brackets.
        In practice it doesn't matter, because in our public headers we must
        include other headers with angle brackets. As we use our public
        headers also to compile our interal source files, effectively the
        result must be the same. Still do it for consistency.
      
      - Except for <config.h> itself. Include it with angle brackets as suggested by
        https://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
      8bace23b
  4. 05 Aug, 2015 2 commits
  5. 24 Jul, 2015 1 commit
    • Dan Winship's avatar
      all: rename nm-glib-compat.h to nm-glib.h, use everywhere · 3452ee2a
      Dan Winship authored
      Rather than randomly including one or more of <glib.h>,
      <glib-object.h>, and <gio/gio.h> everywhere (and forgetting to include
      "nm-glib-compat.h" most of the time), rename nm-glib-compat.h to
      nm-glib.h, include <gio/gio.h> from there, and then change all .c
      files in NM to include "nm-glib.h" rather than including the glib
      headers directly.
      
      (Public headers files still have to include the real glib headers,
      since nm-glib.h isn't installed...)
      
      Also, remove glib includes from header files that are already
      including a base object header file (which must itself already include
      the glib headers).
      3452ee2a
  6. 01 Aug, 2014 1 commit
  7. 30 Jul, 2014 1 commit
    • Dan Winship's avatar
      clients: reorganize source tree, put all the installed clients together · 3d25d704
      Dan Winship authored
      Create a new clients/ subdirectory at the top level, and move cli/ and
      tui/ into it, as well as nm-online.c (which was previously in test/,
      which made no sense).
      
      cli/ was split into two subdirectories, src/ and completion/. While
      this does simplify things (given that the completion file and the
      binary both need to be named "nmcli"), it bloats the source tree, and
      we can work around it by just renaming the completion file at install
      time. Then we can combine the two directories into one and just have
      it all under clients/cli/.
      3d25d704
  8. 24 Mar, 2014 1 commit
    • Dan Winship's avatar
      tui: allow ^Z to suspend the app · ce26445b
      Dan Winship authored
      This way if we end up with bugs that make it otherwise impossible to
      kill nmtui, you can at least ^Z and then kill it from the command
      line.
      ce26445b
  9. 13 Feb, 2014 1 commit
    • Dan Winship's avatar
      build: improve our use of glib's version macros to catch more bugs · 64c5395c
      Dan Winship authored
      We were setting GLIB_VERSION_MAX_ALLOWED to 2.34, since we provide
      reimplementations of a few 2.34 functions in nm-glib-compat.h. But
      this was turning off warnings for the 2.34+ APIs we *didn't* have
      compat versions of too.
      
      Fix this by setting MAX_ALLOWED to 2.32 (same as MIN_REQUIRED), and
      defining macros to wrap calls to compat-ified functions and disable
      deprecation warnings around them.
      
      This points out several places where we were accidentally using 2.34
      APIs without noticing, which need to be fixed now.
      64c5395c
  10. 16 Jan, 2014 3 commits
  11. 13 Dec, 2013 1 commit