1. 13 Sep, 2018 21 commits
  2. 12 Sep, 2018 11 commits
  3. 11 Sep, 2018 3 commits
    • Thomas Haller's avatar
      ppp-manager: avoid crash with nonexisting link in impl_ppp_manager_set_ifindex() · 7c50748d
      Thomas Haller authored
      Fixes: dd98ada3
      (cherry picked from commit 30a469e0)
    • Frederic Danis's avatar
      ppp-manager: fix pppd not exiting correctly on modem hangup · b3ca8abe
      Frederic Danis authored
      When unplugging an USB 3G modem device, pppd does not exit correctly and
      we have the following traces:
      Sep 10 07:58:24.616465 ModemManager[1158]: <info>  (tty/ttyUSB0): released by device '/sys/devices/pci0000:00/0000:00:1c.0/0000:01:00.0/usb4/4-1'
      Sep 10 07:58:24.620314 pppd[2292]: Modem hangup
      Sep 10 07:58:24.621368 ModemManager[1158]: <info>  (tty/ttyUSB1): released by device '/sys/devices/pci0000:00/0000:00:1c.0/0000:01:00.0/usb4/4-1'
      Sep 10 07:58:24.621835 ModemManager[1158]: <warn>  (ttyUSB1): could not re-acquire serial port lock: (5) Input/output error
      Sep 10 07:58:24.621358 NetworkManager[1871]: <debug> ppp-manager: set-ifindex 4
      Sep 10 07:58:24.621369 NetworkManager[1871]: <warn>  ppp-manager: can't change the ifindex from 4 to 4
      Sep 10 07:58:24.623982 NetworkManager[1871]: <info>  device (ttyUSB0): state change: activated -> unmanaged (reason 'removed', sys-iface-state: 'removed')
      Sep 10 07:58:24.624411 NetworkManager[1871]: <debug> kill child process 'pppd' (2292): wait for process to terminate after sending SIGTERM (15) (send SIGKILL in 1500 milliseconds)...
      Sep 10 07:58:24.624440 NetworkManager[1871]: <debug> modem-broadband[ttyUSB0]: notifying ModemManager about the modem disconnection
      Sep 10 07:58:24.626591 NetworkManager[1871]: <debug> modem-broadband[ttyUSB0]: notifying ModemManager about the modem disconnection
      Sep 10 07:58:24.681016 NetworkManager[1871]: <warn>  modem-broadband[ttyUSB0]: failed to disconnect modem: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface 'org.freedesktop.ModemManager1.Modem.Simple' on object at path /org/freedesktop/ModemManager1/Modem/0
      Sep 10 07:58:26.126817 NetworkManager[1871]: <debug> kill child process 'pppd' (2292): process not terminated after 1502368 usec. Sending SIGKILL signal
      Sep 10 07:58:26.128121 NetworkManager[1871]: <info>  device (ppp0): state change: disconnected -> unmanaged (reason 'unmanaged', sys-iface-state: 'removed')
      Sep 10 07:58:26.135571 NetworkManager[1871]: <debug> kill child process 'pppd' (2292): terminated by signal 9 (1511158 usec elapsed)
      This is due to nm-ppp-plugin waiting on SetIfIndex call until timeout,
      which is longer than termination process timeout.
      Calling g_dbus_method_invocation_return_value() on error fixes this.
      Fixes: dd98ada3
      (cherry picked from commit e66e4d0e)
    • Andrew Zaborowski's avatar
      wifi/iwd: handle new GetOrderedNetworks() return type · 592ee02e
      Andrew Zaborowski authored
      The Station.GetOrderedNetworks dbus method's return type has changed in
      IWD commit 0a42f63d42be903a46c595693884772c1c84d39f as the last incompatible
      API change before IWD 0.8 (docs change was made earlier in
      0453308134a3aadb6a2ec6a78ea642e19427704c) so that network names and
      types are no longer included in the reply.  Expect this new reply
      signature although still handle the old signature if we're using the
      Device interface for IWD <= 0.7 compatibility.
      It may be good idea to eventually pass the object manager instance from
      nm-iwd-manager.c to nm-device-iwd.c to avoid using g_dbus_proxy_new_sync
      and g_dbus_proxy_new_for_bus_sync in act_stage2_config, which possibly
      generates a lot of DBus property queries.
      (cherry picked from commit 32506c87)
  4. 10 Sep, 2018 5 commits