1. 11 Dec, 2017 27 commits
  2. 08 Dec, 2017 11 commits
    • Thomas Haller's avatar
      libnm: use nm_utils_named_values_from_str_dict() · b11eac1a
      Thomas Haller authored
      Make use of NMUtilsNamedValue in nm_utils_format_variant_attributes().
      This avoids creating a GList and sorting it.
      Also, reuse nm_utils_named_values_from_str_dict() in
    • Thomas Haller's avatar
      shared: add nm_utils_named_values_from_str_dict() · 097bd72e
      Thomas Haller authored
      NMUtilsNamedValue's purpose is precisely to create
      a list and sort by entires.
      Add nm_utils_named_values_from_str_dict() as helper
      function to do that.
    • Thomas Haller's avatar
      cli: fix integer types in get-functions to match libnm origin · e7d18548
      Thomas Haller authored
      The num/i variables are initialized from libnm API and used
      back at them. The integer types should match.
    • Thomas Haller's avatar
      libnm: adjust symbol versioning after backporting team API to 1.10.2 · ae5af6b3
      Thomas Haller authored
      The team API was backported to nm-1-10 branch.
      It will be released both as 1.12.0 and 1.10.2.
      To ensure the upgrade path from 1.10.2+ to 1.12+ works, the symbols
      in libnm must be present on both versions.
      Usually, we would duplicate the symbols on master via
      NM_BACKPORT_SYMBOL() macro.
      However, as we are sure that we will release 1.10.2 before 1.12.0,
      we can just update the linker version of these symbols. So, although
      the symbols will be first released on major release 1.12.0, their linker
      version tag is libnm_1_10_2, to ease upgrade and to avoid duplicating the
    • Thomas Haller's avatar
    • Thomas Haller's avatar
    • Thomas Haller's avatar
      build: don't link libnm against libjansson when building --without-json-validation · 79d5a06c
      Thomas Haller authored
      Also, don't add the CFLAGS for libjansson to dflt_cppflags_libnm_core.
      dflt_cppflags_libnm_core is used also by core and libnm. But those
      components do not (directly) link against libjansson. The cannot use
      these flags.
    • Thomas Haller's avatar
      Revert "Makefile: rework team compilation flags" · b1c65d32
      Thomas Haller authored
      I don't think we should do this.
      - renamining/dropping configure options is still an annoyance,
        because it requires to different ./configure options depending
        on the version. The rename from --enable-teamctl to --enable-team
        might be theoretically nice, but more annoying then helpful.
      - There is no strict dependency between --enable-team and
        --enable-json-validation. At most, one could argue that
        when enabling the team plugin (--enable-teamctl), then
        libnm must also be build with --enable-json-validation.
        But in fact, the team plugin will happily work with a
        libnm that doesn't link against libjansson.
        That is --enable-teamctl --disable-json-validation will work
        in practice just fine.
        On the other hand, libnm is a client library to create connection
        profiles, fully supporting team profiles also makes sense if the
        actual plugin is not installed (or build). Thus, --disable-teamctl
        --enable-json-validation certainly makes sense.
      At this point, one might ask whether libnm is even still complete without
      libjansson. Maybe libnm should *require* --enable-json-validation.
      But that is not what the patch was doing, and it would also need
      some careful consideration before doing so.
      This reverts commit 9d5cd7ea.
    • Thomas Haller's avatar
      libnm/tests: fix memleak in test · af6f62be
      Thomas Haller authored
    • Thomas Haller's avatar
      gitignore: readd removed libnm-core/tests/test-setting* programs · d5d4911b
      Thomas Haller authored
      Although removed, they show up whenever switching to an
      old branch. Keep ignoring them.
    • Thomas Haller's avatar
      keyfile: reject team properties in parser · 1b8ae839
      Thomas Haller authored
      We don't properly coordinate reading the team properties from keyfile.
      They must be ignored, at least for now.
  3. 07 Dec, 2017 2 commits