1. 12 Jan, 2015 1 commit
  2. 13 Nov, 2014 1 commit
    • Dan Winship's avatar
      all: consistently include config.h · 3bfb163a
      Dan Winship authored
      config.h should be included from every .c file, and it should be
      included before any other include. Fix that.
      
      (As a side effect of how I did this, this also changes us to
      consistently use "config.h" rather than <config.h>. To the extent that
      it matters [which is not much], quotes are more correct anyway, since
      we're talking about a file in our own build tree, not a system
      include.)
      3bfb163a
  3. 18 Sep, 2014 2 commits
    • Dan Winship's avatar
      libnm: port to GDBus · 6793a32a
      Dan Winship authored
      Port libnm-core/libnm to GDBus.
      
      The NetworkManager daemon continues to use dbus-glib; the
      previously-added connection hash/variant conversion methods are now
      moved to NetworkManagerUtils (along with a few other utilities that
      are now only needed by the daemon code).
      6793a32a
    • Dan Winship's avatar
      libnm-core: change connection hash tables to variants in API · acf86f68
      Dan Winship authored
      In preparation for porting to GDBus, make nm_connection_to_dbus(),
      etc, represent connections as GVariants of type 'a{sa{sv}}' rather
      than as GHashTables-of-GHashTables-of-GValues.
      
      This means we're constantly converting back and forth internally, but
      this is just a stepping stone on the way to the full GDBus port, and
      all of that code will go away again later.
      acf86f68
  4. 04 Sep, 2014 1 commit
    • Dan Winship's avatar
      libnm-core: rename NMConnection to/from_hash methods · 773d3f0a
      Dan Winship authored
      Rename nm_connection_to_hash() to nm_connection_to_dbus(), and
      nm_connection_new_from_hash() to nm_connection_new_from_dbus(). In
      addition to clarifying that this is specifically the D-Bus
      serialization format, these names will also work better in the
      GDBus-based future where the serialization format is GVariant, not
      GHashTable.
      
      Also, move NMSettingHashFlags to nm-connection.h, and rename it
      NMConnectionSerializationFlags.
      773d3f0a
  5. 01 Aug, 2014 2 commits
    • Dan Winship's avatar
      libnm: consistently use "INTERFACE" rather than "IFACE" in macros · f441cf2b
      Dan Winship authored
      Most D-Bus interface name macros used "INTERFACE" in their name (eg,
      NM_DBUS_INTERFACE), but a few used "IFACE" instead (eg,
      NM_DBUS_IFACE_SETTINGS). Make them consistent.
      f441cf2b
    • Dan Winship's avatar
      libnm, core, cli, tui: fix the capitalization of various types · 3ac0f528
      Dan Winship authored
      GLib/Gtk have mostly settled on the convention that two-letter
      acronyms in type names remain all-caps (eg, "IO"), but longer acronyms
      become initial-caps-only (eg, "Tcp").
      
      NM was inconsistent, with most long acronyms using initial caps only
      (Adsl, Cdma, Dcb, Gsm, Olpc, Vlan), but others using all caps (DHCP,
      PPP, PPPOE, VPN). Fix libnm and src/ to use initial-caps only for all
      three-or-more-letter-long acronyms (and update nmcli and nmtui for the
      libnm changes).
      3ac0f528
  6. 23 Jul, 2014 1 commit
    • Dan Winship's avatar
      core: fill in nm-types.h, clean out other headers · b28f6526
      Dan Winship authored
      Clean up some of the cross-includes between headers (which made it so
      that, eg, if you included NetworkManagerUtils.h in a test program, you
      would need to build the test with -I$(top_srcdir)/src/platform, and if
      you included nm-device.h you'd need $(POLKIT_CFLAGS)) by moving all
      GObject struct definitions for src/ and src/settings/ into nm-types.h
      (which already existed to solve the NMDevice/NMActRequest circular
      references).
      
      Update various .c files to explicitly include the headers they used to
      get implicitly, and remove some now-unnecessary -I options from
      Makefiles.
      b28f6526
  7. 20 Jun, 2014 1 commit
    • Thomas Haller's avatar
      dispatcher: suppress log warning when nm-dispatcher is disabled in systemd · 0d45284a
      Thomas Haller authored
      When 'nm-dispatcher' is not running because its systemd service
      'NetworkManager-dispatcher.service' is not enabled, any calls to the dispatcher
      will fail with an error of typ DBUS_ERROR:DBUS_GERROR_REMOTE_EXCEPTION (32):
      
        "Unit dbus-org.freedesktop.nm-dispatcher.service failed to load: No such file or directory."
      
      This clutters the logfile with warnings, although the user probably
      disabled the service on purpose.
      
      Special case this particular (recurring) failure and downgrade the warning
      to debug level.
      Signed-off-by: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      0d45284a
  8. 16 Jun, 2014 6 commits
  9. 11 Jun, 2014 1 commit
  10. 06 Jun, 2014 9 commits
    • Dan Williams's avatar
      dispatcher: bump overall timeout to 10 minutes (rh #982734) (rh #1048345) · 02252224
      Dan Williams authored
      Since NM now handles long-running dispatcher scripts better, allow them
      to run for really long times.
      02252224
    • Dan Williams's avatar
      dispatcher: enhance debug logging · df601ad6
      Dan Williams authored
      Attach a request ID to every request, and print that out in the debug
      messages so you can see which results match up with which dispatcher
      requests.
      df601ad6
    • Dan Williams's avatar
      dispatcher: use separate directories for pre-up/pre-down events · 1383f4bc
      Dan Williams authored
      To ensure that NetworkManager does not block needlessly for events
      which have no scripts, require scripts that respond to blocking
      events to opt into the action.
      1383f4bc
    • Dan Williams's avatar
      dispatcher: convert action_to_string to a table · 27cb927d
      Dan Williams authored
      Oddly, this increases the compiled+stripped size of the object file
      by 24 bytes (8296 -> 8320), but I think it produces more readable code.
      27cb927d
    • Dan Williams's avatar
      dispatcher: add PRE_UP states · 19d7386b
      Dan Williams authored
      This event runs before a connection/device is announced as
      "activated" or "connected", to enable scripts to do things
      before applications begin using connectivity.  For example,
      this could be used to manage /etc/resolv.conf outside of
      NetworkManager and ensure that resolv.conf had correct
      information before DNS is used.
      
      Note that this is different than the Debian or Gentoo "pre-up"
      event used in /etc/network/interfaces, as that event runs before
      any L2 configuration has started.  If we really need an event
      like that, we'll add it later as "lower-up".
      19d7386b
    • Dan Williams's avatar
      dispatcher: robustify canceling dispatcher calls · 286e926e
      Dan Williams authored
      Thomas pointed out that using the address of the DispatcherInfo
      structure as the dispatcher call ID could cause a mis-cancelation
      if malloc re-used the same block in the future.  While the code
      should be correctly clearing call IDs after the callback runs
      or is canceled, just use numeric IDs to avoid potential crashses.
      286e926e
    • Dan Williams's avatar
      dispatcher: add synchronous dispatcher calls · 90b747fa
      Dan Williams authored
      On shutdown we can't defer the response to a callback, so we need to
      use synchronous D-Bus calls.  Second, sometimes we want to block on
      the dispatcher response, like for pre-down.
      90b747fa
    • Dan Williams's avatar
      dispatcher: only dispatch if scripts exist · 5150cb88
      Dan Williams authored
      If there are no dispatcher scripts, don't bother dispatching any
      events.  This saves some time configuring networking if the event
      would have no effect anyway.
      5150cb88
    • Dan Williams's avatar
      4cc13bef
  11. 18 Apr, 2014 2 commits
    • Dan Winship's avatar
      dispatcher: add better debugging · 3b197de5
      Dan Winship authored
      Add LOGD_DISPATCH, and if it's set to DEBUG, tell nm-dispatcher to log
      additional information about each script it runs.
      3b197de5
    • Dan Winship's avatar
      dispatcher: bump script timeout up to 20 seconds (rh #1048345) · d9334503
      Dan Winship authored
      The dispatcher would kill scripts after 3 seconds, but on
      heavily-loaded machines, that was sometimes too short even for simple
      scripts. Bump the timeout up to 20 seconds instead (and change the
      10-second quit-on-idle timer to not run when a script is running).
      
      Also change the D-Bus call timeout in the daemon to 30 seconds, so
      that it only triggers if something goes really wrong and the action
      timeout fails.
      d9334503
  12. 24 Jan, 2014 1 commit
  13. 13 Nov, 2013 1 commit
  14. 21 Jun, 2013 1 commit
  15. 20 May, 2013 1 commit
  16. 27 Feb, 2013 1 commit
  17. 26 Feb, 2013 1 commit
  18. 11 Oct, 2012 1 commit
  19. 11 Sep, 2012 4 commits