1. 05 Sep, 2017 1 commit
  2. 29 May, 2017 1 commit
    • Thomas Haller's avatar
      dnsmasq: fix generating shared IPv4 address range · d512ed9f
      Thomas Haller authored
      Change behavior for the network-address and broadcast-address.
      Users should not specify such addresses, but if they do, generate
      something more sensible.
      
      Also, if the address was in network larger then /24, the
      generated address range was rather unexpected. Change behavior
      here.
      
      There are no particularly strong reasons for the chosen range.
      It just seems suitable. The decision to hand out at most a /24
      is because it is likely to be plenty, and because that is what
      the previous code did -- at least, if the address was in the
      first /24 of the subnet. See how the result for 192.168.0.1/20
      is unchanged, but 192.168.1.1/20 changes.
      d512ed9f
  3. 21 Nov, 2016 2 commits
    • Thomas Haller's avatar
      build: don't add subdirectories to include search path but require qualified include · 44ecb415
      Thomas Haller authored
      Keep the include paths clean and separate. We use directories to group source
      files together. That makes sense (I guess), but then we should use this
      grouping also when including files. Thus require to #include files with their
      path relative to "src/".
      
      Also, we build various artifacts from the "src/" tree. Instead of having
      individual CFLAGS for each artifact in Makefile.am, the CFLAGS should be
      unified. Previously, the CFLAGS for each artifact differ and are inconsistent
      in which paths they add to the search path. Fix the inconsistency by just
      don't add the paths at all.
      44ecb415
    • Thomas Haller's avatar
      build: rename "src/dnsmasq-manager" to "src/dnsmasq" · 8c7f5e26
      Thomas Haller authored
      The dnsmasq directory does not only contain the manager
      instance, but various files related to dnsmasq.
      
      Rename.
      8c7f5e26
  4. 11 Apr, 2016 1 commit
  5. 19 Feb, 2016 1 commit
    • Thomas Haller's avatar
      all: cleanup includes and let "nm-default.h" include "config.h" · 8bace23b
      Thomas Haller authored
      - All internal source files (except "examples", which are not internal)
        should include "config.h" first. As also all internal source
        files should include "nm-default.h", let "config.h" be included
        by "nm-default.h" and include "nm-default.h" as first in every
        source file.
        We already wanted to include "nm-default.h" before other headers
        because it might contains some fixes (like "nm-glib.h" compatibility)
        that is required first.
      
      - After including "nm-default.h", we optinally allow for including the
        corresponding header file for the source file at hand. The idea
        is to ensure that each header file is self contained.
      
      - Don't include "config.h" or "nm-default.h" in any header file
        (except "nm-sd-adapt.h"). Public headers anyway must not include
        these headers, and internal headers are never included after
        "nm-default.h", as of the first previous point.
      
      - Include all internal headers with quotes instead of angle brackets.
        In practice it doesn't matter, because in our public headers we must
        include other headers with angle brackets. As we use our public
        headers also to compile our interal source files, effectively the
        result must be the same. Still do it for consistency.
      
      - Except for <config.h> itself. Include it with angle brackets as suggested by
        https://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
      8bace23b
  6. 13 Nov, 2014 1 commit
    • Dan Winship's avatar
      all: consistently include config.h · 3bfb163a
      Dan Winship authored
      config.h should be included from every .c file, and it should be
      included before any other include. Fix that.
      
      (As a side effect of how I did this, this also changes us to
      consistently use "config.h" rather than <config.h>. To the extent that
      it matters [which is not much], quotes are more correct anyway, since
      we're talking about a file in our own build tree, not a system
      include.)
      3bfb163a
  7. 31 Jan, 2014 1 commit
  8. 23 Jan, 2014 1 commit
    • Dan Williams's avatar
      core: allow custom IP address ranges for Shared connections (bgo #675973) · 32a001f5
      Dan Williams authored
      Given an IPv4 address and prefix for a shared config, figure out
      the DHCP address range automatically.  To keep things simple we
      allow a max of 252 addresses (not including network address,
      broadcast address, and the hotspot) no matter what prefix you use,
      so if the address is 10.0.10.1, you still only get a range of
      10.0.10.2 -> 10.0.10.254.
      
      But we also leave some addresses available above the host address
      for static stuff, like we did before.  This is done on a sliding
      scale from 0 to 8 addresses, where about 1/10th the number of
      available addresses are reserved.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=675973
      32a001f5