1. 26 Sep, 2019 1 commit
  2. 11 Sep, 2019 1 commit
  3. 06 Aug, 2019 1 commit
  4. 29 Jul, 2019 2 commits
  5. 03 Jul, 2019 1 commit
  6. 20 Jun, 2019 1 commit
    • Thomas Haller's avatar
      settings: drop ibft settings plugin · 74641be8
      Thomas Haller authored
      The functionality of the ibft settings plugin is now handled by
      nm-initrd-generator. There is no need for it anymore, drop it.
      
      Note that ibft called iscsiadm, which requires CAP_SYS_ADMIN to work
      ([1]). We really want to drop this capability, so the current solution
      of a settings plugin (as it is implemented) is wrong. The solution
      instead is nm-initrd-generator.
      
      Also, on Fedora the ibft was disabled and probably on most other
      distributions as well. This was only used on RHEL.
      
      [1] https://bugzilla.redhat.com/show_bug.cgi?id=1371201#c7
      74641be8
  7. 14 Jun, 2019 1 commit
  8. 04 Jun, 2019 1 commit
  9. 29 May, 2019 1 commit
    • Thomas Haller's avatar
      build: disable "-Wunknown-pragmas" warning · a307bd6e
      Thomas Haller authored
      clang on CentOS 7.6 (3.4.2-9.el7) warns:
      
            CC       clients/tui/newt/clients_tui_newt_libnmt_newt_a-nmt-newt-button.o
          In file included from ../clients/tui/newt/nmt-newt-button.c:26:
          In file included from ../shared/nm-default.h:280:
          ../shared/nm-glib-aux/nm-macros-internal.h:1617:2: error: unknown warning group -Wstringop-truncation, ignored [-Werror,-Wunknown-pragmas]
                  NM_PRAGMA_WARNING_DISABLE ("-Wstringop-truncation");
                  ^
          ../shared/nm-glib-aux/nm-macros-internal.h:419:9: note: expanded from macro NM_PRAGMA_WARNING_DISABLE
                  _Pragma(_NM_PRAGMA_WARNING_DO(warning))
                  ^
          <scratch space>:109:25: note: expanded from here
           GCC diagnostic ignored "-Wstringop-truncation"
                                  ^
      
      This warning totally defeats the purpose of why we use the pragma in the
      first place.
      a307bd6e
  10. 17 May, 2019 1 commit
  11. 14 May, 2019 1 commit
  12. 03 May, 2019 1 commit
  13. 21 Apr, 2019 1 commit
  14. 19 Apr, 2019 1 commit
  15. 16 Apr, 2019 3 commits
  16. 14 Apr, 2019 4 commits
    • Thomas Haller's avatar
      Squashed 'shared/n-acd/' changes from 9eb7bf7173..5470816839 · 90a0edce
      Thomas Haller authored
      5470816839 test: increase timeout on test-veth
      d44dfa1ba7 build: update c-stdaux
      26b10b6514 build: pull in submodule updates
      7817fc0a95 n-acd: switch to c-stdaux
      5033b2ecdd n-acd: include dependency headers
      aaf2a66788 build: update README
      b9448eff98 build: pull in c-stdaux
      8ac364e9a3 test: raise MEMLOCK if possible
      3cd197162e ci: drop root
      0289a33412 test: allow running without root
      67a343fe87 build: update email address
      3c364ba95f build: bump version
      d0f7d71fa1 build: document build configuration options
      014b00cd27 build: fill in NEWS
      180990288a n-acd: document API
      79904585df build: update submodules
      8185e6ed89 build: reduce boilerplate
      
      git-subtree-dir: shared/n-acd
      git-subtree-split: 54708168399f1662c652b5931608e5077ef462f6
      90a0edce
    • Thomas Haller's avatar
      Squashed 'shared/c-siphash/' changes from 211cfc5abc..7c42c59258 · 085b4e03
      Thomas Haller authored
      7c42c59258 build: use c-stdaux
      d81d68ff83 build: sync with c-util
      e858efbc45 build: pull in c-stdaux
      
      git-subtree-dir: shared/c-siphash
      git-subtree-split: 7c42c592581906fef19458372b8db2b643278211
      085b4e03
    • Thomas Haller's avatar
      Squashed 'shared/c-rbtree/' changes from bf627e0c32..b46392d25d · 7d5c09c3
      Thomas Haller authored
      b46392d25d build: use c-stdaux
      61f21750be build: pull in c-stdaux
      31fcf75afe build: sync with c-util
      fec7b8f2da ci: add run with -DNDEBUG
      
      git-subtree-dir: shared/c-rbtree
      git-subtree-split: b46392d25de7a7bab67d48ef18bf8350b429cff5
      7d5c09c3
    • Thomas Haller's avatar
      Squashed 'shared/c-stdaux/' content from commit 11930d2592 · 21141429
      Thomas Haller authored
      git-subtree-dir: shared/c-stdaux
      git-subtree-split: 11930d259212605a15430523472ef54e0c7654ee
      21141429
  17. 13 Apr, 2019 2 commits
  18. 09 Apr, 2019 2 commits
  19. 03 Apr, 2019 2 commits
  20. 19 Mar, 2019 1 commit
    • Lubomir Rintel's avatar
      all: goodbye libnm-glib · 1de8383a
      Lubomir Rintel authored
      This removes libnm-glib, libnm-glib-vpn, and libnm-util for good.
      The it has been replaced with libnm since NetworkManager 1.0, disabled
      by default since 1.12 and no up-to-date distributions ship it for years
      now.
      
      Removing the libraries allows us to:
      
      * Remove the horrible hacks that were in place to deal with accidental use
        of both the new and old library in a single process.
      * Relief the translators of maintenance burden of similar yet different
        strings.
      * Get rid of known bad code without chances of ever getting fixed
        (libnm-glib/nm-object.c and libnm-glib/nm-object-cache.c)
      * Generally lower the footprint of the releases and our workspace
      
      If there are some really really legacy users; they can just build
      libnm-glib and friends from the NetworkManager-1.16 distribution. The
      D-Bus API is stable and old libnm-glib will keep working forever.
      
      https://github.com/NetworkManager/NetworkManager/pull/308
      1de8383a
  21. 15 Mar, 2019 1 commit
  22. 11 Mar, 2019 1 commit
  23. 23 Feb, 2019 3 commits
    • Thomas Haller's avatar
      a537e0dc
    • Thomas Haller's avatar
      11f02622
    • Thomas Haller's avatar
      build/meson: increase timeouts for some tests · b1f6d53b
      Thomas Haller authored
      The defaults for test timeouts in meson is 30 seconds. That is not long
      enough when running
      
        $ NMTST_USE_VALGRIND=1 ninja -C build test
      
      Note that meson supports --timeout-multiplier, and automatically
      increases the timeout when running under valgrind. However, meson
      does not understand that we are running tests under valgrind via
      NMTST_USE_VALGRIND=1 environment variable.
      
      Timeouts are really not expected to be reached and are a mean of last
      resort. Hence, increasing the timeout to a large value is likely to
      have no effect or to fix test failures where the timeout was too rigid.
      It's unlikely that the test indeed hangs and the increase of timeout
      causes a unnecessary increase of waittime before aborting.
      b1f6d53b
  24. 09 Feb, 2019 1 commit
  25. 08 Feb, 2019 2 commits
    • Thomas Haller's avatar
      build: re-enable "-Wmissing-braces" warning · c537e5fd
      Thomas Haller authored
      We should always get the nesting in struct initializers right.
      Everyhing else is error-prone, and the warning is good.
      
      Enable it.
      c537e5fd
    • Thomas Haller's avatar
      build/meson: disable "-Wgnu-variable-sized-type-not-at-end warning" · 7b18bd1f
      Thomas Haller authored
      It's not useful for us.
      
          In file included from ../src/systemd/src/libsystemd/sd-event/sd-event.c:14:
          ../src/systemd/src/libsystemd/sd-event/event-source.h:195:36: error: field 'buffer' with variable sized type 'union inotify_event_buffer' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
                  union inotify_event_buffer buffer;
                                             ^
      7b18bd1f
  26. 06 Feb, 2019 2 commits
  27. 05 Feb, 2019 1 commit
    • Thomas Haller's avatar
      build/meson: always set SESSION_TRACKING_SYSTEMD define · 15995c97
      Thomas Haller authored
      Like we do with autotools, otherwise we get a warning:
      
          [576/1030] Compiling C object src/25a6634@@NetworkManager@sta/nm-session-monitor.c.o.
          ../src/nm-session-monitor.c:31:5: warning: "SESSION_TRACKING_SYSTEMD" is not defined, evaluates to 0 [-Wundef]
           #if SESSION_TRACKING_SYSTEMD && SESSION_TRACKING_ELOGIND
               ^~~~~~~~~~~~~~~~~~~~~~~~
      15995c97