1. 16 Apr, 2019 1 commit
    • Lubomir Rintel's avatar
      all: goodbye libnm-glib · 5801f89f
      Lubomir Rintel authored
      This removes libnm-glib, libnm-glib-vpn, and libnm-util for good.
      The it has been replaced with libnm since NetworkManager 1.0, disabled
      by default since 1.12 and no up-to-date distributions ship it for years
      now.
      
      Removing the libraries allows us to:
      
      * Remove the horrible hacks that were in place to deal with accidental use
        of both the new and old library in a single process.
      * Relief the translators of maintenance burden of similar yet different
        strings.
      * Get rid of known bad code without chances of ever getting fixed
        (libnm-glib/nm-object.c and libnm-glib/nm-object-cache.c)
      * Generally lower the footprint of the releases and our workspace
      
      If there are some really really legacy users; they can just build
      libnm-glib and friends from the NetworkManager-1.16 distribution. The
      D-Bus API is stable and old libnm-glib will keep working forever.
      
      https://github.com/NetworkManager/NetworkManager/pull/308
      5801f89f
  2. 11 Apr, 2019 1 commit
  3. 20 Mar, 2019 1 commit
  4. 24 Oct, 2018 1 commit
    • Thomas Haller's avatar
      build: fix build_clean.sh script to enable ibft · b660a41c
      Thomas Haller authored
      autotools build has/had a bug, where ibft test files would only be disted
      if the ibft plugin was enabled.
      
      Regardless of that, `build_clean.sh --release` is our suggested way to
      create a release tarball. It should always enable the ibft plugin.
      
      It didn't do so, due to a bug.
      b660a41c
  5. 14 Sep, 2018 6 commits
    • Thomas Haller's avatar
      contrib/rpm: fix handling of --with test default · d1fecaa2
      Thomas Haller authored
      Seems rpmbuild does not honor the latest occurance with
      
        --with test --without test
      
      to disable tests. Work around that.
      
      Fixes: ad850c4f
      (cherry picked from commit cc8c2071)
      d1fecaa2
    • Thomas Haller's avatar
      contrib/rpm: fix handling of --with test default · cc8c2071
      Thomas Haller authored
      Seems rpmbuild does not honor the latest occurance with
      
        --with test --without test
      
      to disable tests. Work around that.
      
      Fixes: ad850c4f
      cc8c2071
    • Thomas Haller's avatar
      contrib/rpm: disable tests by default and use fatal-warnings with tests · fd2e8179
      Thomas Haller authored
      In general, when we build a package, we want no compiler warnings
      and all unit tests to pass.
      
      That is in particular true when building a package for the distribution
      in koji. When builing in koji, we (rightly) cannot pass rpmbuild options, so
      the default whether tests/compiler-warnings are fatal matter very much.
      
      One could argue: let's have the tests/compiler-warnings fatal and fail the build.
      During a build in koji for a Fedora release, we want them all pass. And if somebody
      does a manual build, the person can patch the spec file (or use rpmbuild
      flags).
      
      However, note how commit "f7b5e48c contrib/rpm: don't force fatal warnings
      with tests" already disabled fatal compiler warnings. Why? It seems
      compiler warnings should be even more stable than our unit tests, as long
      as you target a particular Fedora release and compiler version. So this
      was done to support rebuilding an SRPM for a different Fedora release,
      or to be more graceful during early development phase of a Fedora
      release, where things are not as stable yet.
      
      The exactly same reasoning applies to treating unit-tests failures as fatal.
      For example, a recent iproute2 issue broke unit tests. That meant, with
      that iproute2 release in build root, the NetworkManager RPM could not be built.
      Very annoying.
      
      Now:
      
      - if "test" is enabled, that means both `make check` and compiler warnings
        are treated fatal. If "test" is disabled, `make check` and compiler
        warnings are still done, just not fatal.
      
      - "test" is now disabled by default via the spec file. They are not fatal
        when building in koji or when rebuilding the package manually.
      
      - tests can be enabled optionally. Note that the "build_clean.sh"
        script enables them by default. So, a user using this script would
        need to explicitly "--without test".
      
      (cherry picked from commit ad850c4f)
      fd2e8179
    • Thomas Haller's avatar
      contrib/rpm: disable tests by default and use fatal-warnings with tests · ad850c4f
      Thomas Haller authored
      In general, when we build a package, we want no compiler warnings
      and all unit tests to pass.
      
      That is in particular true when building a package for the distribution
      in koji. When builing in koji, we (rightly) cannot pass rpmbuild options, so
      the default whether tests/compiler-warnings are fatal matter very much.
      
      One could argue: let's have the tests/compiler-warnings fatal and fail the build.
      During a build in koji for a Fedora release, we want them all pass. And if somebody
      does a manual build, the person can patch the spec file (or use rpmbuild
      flags).
      
      However, note how commit "f7b5e48c contrib/rpm: don't force fatal warnings
      with tests" already disabled fatal compiler warnings. Why? It seems
      compiler warnings should be even more stable than our unit tests, as long
      as you target a particular Fedora release and compiler version. So this
      was done to support rebuilding an SRPM for a different Fedora release,
      or to be more graceful during early development phase of a Fedora
      release, where things are not as stable yet.
      
      The exactly same reasoning applies to treating unit-tests failures as fatal.
      For example, a recent iproute2 issue broke unit tests. That meant, with
      that iproute2 release in build root, the NetworkManager RPM could not be built.
      Very annoying.
      
      Now:
      
      - if "test" is enabled, that means both `make check` and compiler warnings
        are treated fatal. If "test" is disabled, `make check` and compiler
        warnings are still done, just not fatal.
      
      - "test" is now disabled by default via the spec file. They are not fatal
        when building in koji or when rebuilding the package manually.
      
      - tests can be enabled optionally. Note that the "build_clean.sh"
        script enables them by default. So, a user using this script would
        need to explicitly "--without test".
      ad850c4f
    • Thomas Haller's avatar
      contrib/rpm: add --release option to build_clean.sh script · 5f1912f5
      Thomas Haller authored
      The correct way to create a tarball for release is
      
        ./contrib/fedora/rpm/build_clean.sh -r
      
      Just ensure to issue this from a clean shell environment.
      
      (cherry picked from commit 5894da67)
      5f1912f5
    • Thomas Haller's avatar
      contrib/rpm: add --release option to build_clean.sh script · 5894da67
      Thomas Haller authored
      The correct way to create a tarball for release is
      
        ./contrib/fedora/rpm/build_clean.sh -r
      
      Just ensure to issue this from a clean shell environment.
      5894da67
  6. 09 Feb, 2018 1 commit
    • Thomas Haller's avatar
      contrib/rpm: make "snapshot" for package version configurable via script · 86a18b2d
      Thomas Haller authored
      Will be used by CI trigger to name packages that are build during testing
      of a github pull request with the corresponding pull request ID.
      
      "build_clean.sh" now supports a command line option -s|--snapshot. But the
      same paramter can also be set via $NM_BUILD_SNAPSHOT environment
      variable. Using the environment variable is useful to support older versions
      and new versions of "build_clean.sh", so that the script can just ignore the
      snapshot setting if it doesn't understand it yet.
      86a18b2d
  7. 21 Dec, 2017 1 commit
    • Thomas Haller's avatar
      settings: drop unmaintained ifnet settings plugin of Gentoo · 0474441e
      Thomas Haller authored
      Even Gentoo disables this plugin since before 0.9.8 release
      of NetworkManager. Time to say goodbye.
      
      If somebody happens to show up to maintain it, we may resurrect it
      later.
      
      If "$distro_plugins=ifnet" was set, configure.ac would use that
      to autodetect --with-hostname-persist=gentoo. Replace that autodetect
      part by checking for /etc/gentoo-release file.
      0474441e
  8. 25 Jul, 2017 1 commit
    • Thomas Haller's avatar
      contrib/rpm: skip tests for -Q build option · c528a895
      Thomas Haller authored
      Previously, the --quick option only mattered when creating
      the source tarball, to run `make dist` instead of the slower
      `make distcheck`.
      
      Extend its meaning to also skip unit tests while building the RPM.
      You still can enable them with
      
        $ ./contrib/fedora/rpm/build_clean.sh -Q -w test
      c528a895
  9. 24 Mar, 2017 1 commit
    • Thomas Haller's avatar
      build: configure explicit paths for dist tarball during "build_clean.sh" · 29a47f40
      Thomas Haller authored
      "build_clean.sh" is used to generate a distribution tarball. The tarball
      contains pregenerated man pages with default values for paths, which in
      turn depend on the configure options when creating the tarball.
      
      Previously, the man page would have paths like "usr/local/etc/NetworkManager/...",
      which doesn't seem the best choice for a default man page.
      
      Explicitly set the installation paths.
      
      Also, --disable-dependency-tracking in this mode. It may speed up the
      build.
      29a47f40
  10. 15 Feb, 2017 1 commit
    • Thomas Haller's avatar
      contrib/rpm: add explict configure options for building NetworkManager in "build_clean.sh" · 432717cf
      Thomas Haller authored
      When we create a source tarball, documentation and other generated files
      are disted. Those files depend on the configure options when creating
      the tarball. For example, the generated man pages contain the compile time
      configurable default values.
      
      For that reason, it is generally better to regenerate the documentation when
      building NetworkManager. However, let's set explict configure options to
      have a more reproducible way to generate the tarball.
      
      When doing a release, you should not just call `make dist`. Instead, the
      proper way of creating an official source tarball is:
      
        $ ./contrib/fedora/rpm/build_clean.sh --srpm
      432717cf
  11. 28 Nov, 2016 1 commit
    • Thomas Haller's avatar
      build: fix gtk-doc/introspection handling for build · a80ba4ea
      Thomas Haller authored
      - `make dist` requires --enable-gtk-doc --enable-introspection --with-libnm-glib
      - --enable-gtk-doc requires --enable-introspection
      - --with-nmcli requires either --enable-introspection or pregenerated
         settings-docs.c files from the dist tarball. It does not require
         --enable-gtk-doc.
      
      There is a bit of a problem in that --enable-introspection requires
      now xsltproc. However, gobject-introspection does itself not depend
      on xsltproc. So, more correct might be a special --enable-doc argument,
      that combines --enable-introspection --with-xsltproc. Anyway, that
      seems to make it more complicated then it already is so just implicitly
      (and surprisingly?) require xsltproc with --enable-introspection.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=775003
      a80ba4ea
  12. 20 Nov, 2016 1 commit
  13. 14 Oct, 2016 1 commit
  14. 01 Apr, 2016 1 commit
    • Thomas Haller's avatar
      contrib/rpm: improve build_clean.sh to explicitly set $SOURCE_FROM_GIT · 6fb80e10
      Thomas Haller authored
      Presiouvly, when there was a tarball file in the top git-tree, it would
      have been choosen and no easy way to overwrite the decision to build
      from a git-archive. Now you can safely build current HEAD by simply calling
      
        ./contrib/fedora/rpm/build_clean.sh -g
      
      Contrary to the regular build which calls `make dist`, this doesn't
      require a clean working copy and no need to purge it with git-clean.
      6fb80e10
  15. 17 Feb, 2016 1 commit
  16. 02 Feb, 2016 2 commits
  17. 24 Dec, 2015 1 commit
    • Thomas Haller's avatar
      build: rename directory "include" to "shared" · db80ec05
      Thomas Haller authored
      Up to now, the "include" directory contained (only) header files that were
      used project-wide by libs, core, clients, et al.
      
      Since the directory now also contains a non-header file, the "include"
      name is misleading. Instead of adding yet another directory that is
      project-wide, with non-header-only content, rename the "include"
      directory to "shared".
      db80ec05
  18. 19 Dec, 2014 1 commit
  19. 03 Dec, 2014 1 commit
  20. 07 Nov, 2014 1 commit
  21. 03 Oct, 2014 1 commit
  22. 13 Aug, 2014 1 commit
  23. 04 Jul, 2014 1 commit
  24. 18 Jun, 2014 1 commit
  25. 31 May, 2014 1 commit
  26. 14 May, 2014 1 commit
  27. 07 May, 2014 1 commit