1. 16 Apr, 2019 1 commit
    • Lubomir Rintel's avatar
      all: goodbye libnm-glib · 5801f89f
      Lubomir Rintel authored
      This removes libnm-glib, libnm-glib-vpn, and libnm-util for good.
      The it has been replaced with libnm since NetworkManager 1.0, disabled
      by default since 1.12 and no up-to-date distributions ship it for years
      now.
      
      Removing the libraries allows us to:
      
      * Remove the horrible hacks that were in place to deal with accidental use
        of both the new and old library in a single process.
      * Relief the translators of maintenance burden of similar yet different
        strings.
      * Get rid of known bad code without chances of ever getting fixed
        (libnm-glib/nm-object.c and libnm-glib/nm-object-cache.c)
      * Generally lower the footprint of the releases and our workspace
      
      If there are some really really legacy users; they can just build
      libnm-glib and friends from the NetworkManager-1.16 distribution. The
      D-Bus API is stable and old libnm-glib will keep working forever.
      
      https://github.com/NetworkManager/NetworkManager/pull/308
      5801f89f
  2. 11 Apr, 2019 1 commit
  3. 09 Apr, 2019 3 commits
  4. 04 Apr, 2019 1 commit
    • Thomas Haller's avatar
      contrib/rpm: disable NDEBUG for meson builds · ef338667
      Thomas Haller authored
      For better or worse, our release builds commonly do not disable assertions.
      That means,
      
       - NDEBUG is not set, and assert() is in effect
       - G_DISABLE_ASSERT is not set, and g_assert() is in effect
       - G_DISABLE_CHECKS is not set, and g_return*() is in effect.
      
      On the other hand, NM_MORE_ASSERTS is not enabled by default and nm_assert()
      is stripped away. That is the actual purpose of nm_assert(): it is
      commonly disabled on release builds, while all other assertions are
      enabled.
      
      Note that it is fully supported to build NetworkManager with all kind of
      assertions disabled. However, such a configuration is not much tested
      and I would not recommend it for that reason.
      
      %meson expands to
      
        $ /usr/bin/meson --buildtype=plain --prefix=/usr --libdir=/usr/lib64 --libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin --includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man --infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc --localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload --auto-features=enabled -Db_ndebug=true . x86_64-redhat-linux-gnu $OTHER_ARGS
      
      thus passing -DNDEBUG to the meson build. Override that.
      ef338667
  5. 03 Apr, 2019 1 commit
  6. 20 Mar, 2019 1 commit
  7. 19 Mar, 2019 1 commit
    • Lubomir Rintel's avatar
      all: goodbye libnm-glib · 1de8383a
      Lubomir Rintel authored
      This removes libnm-glib, libnm-glib-vpn, and libnm-util for good.
      The it has been replaced with libnm since NetworkManager 1.0, disabled
      by default since 1.12 and no up-to-date distributions ship it for years
      now.
      
      Removing the libraries allows us to:
      
      * Remove the horrible hacks that were in place to deal with accidental use
        of both the new and old library in a single process.
      * Relief the translators of maintenance burden of similar yet different
        strings.
      * Get rid of known bad code without chances of ever getting fixed
        (libnm-glib/nm-object.c and libnm-glib/nm-object-cache.c)
      * Generally lower the footprint of the releases and our workspace
      
      If there are some really really legacy users; they can just build
      libnm-glib and friends from the NetworkManager-1.16 distribution. The
      D-Bus API is stable and old libnm-glib will keep working forever.
      
      https://github.com/NetworkManager/NetworkManager/pull/308
      1de8383a
  8. 07 Mar, 2019 16 commits
  9. 08 Feb, 2019 2 commits
  10. 07 Feb, 2019 2 commits
    • Thomas Haller's avatar
      contrib: install python3-gobject as REQUIRED_PACKAGES · 6505a781
      Thomas Haller authored
      To run the tests with python3, we need python3-gobject.
      
      Note that "contrib/fedora/REQUIRED_PACKAGES" is called by
      "contrib/scripts/nm-ci-run.sh" script to install the packages
      in Fedora.
      6505a781
    • Thomas Haller's avatar
      contrib/rpm: quote snapshot/git_sha variables in spec-file · a0b976ac
      Thomas Haller authored
      Otherwise the following fails:
      
          $ ./contrib/fedora/rpm/build_clean.sh -g -s x.1
          ...
          error: parse error in expression
          error: /data/src/_NetworkManager/contrib/fedora/rpm/NetworkManager.20190207-165257.XOkW4i/SPECS/NetworkManager.spec:35: bad %if condition
          ERROR: rpmbuild FAILED
      
      Even with the fix, not all characters are allowed:
      
          $ ./contrib/fedora/rpm/build_clean.sh -g -s x-1
          ...
          error: line 112: Illegal char '-' (0x2d) in: Release: 22165.x-1.25b13e2053.fc29
          ERROR: rpmbuild FAILED
      a0b976ac
  11. 04 Feb, 2019 1 commit
  12. 07 Jan, 2019 1 commit
  13. 20 Dec, 2018 1 commit
    • Inigo Martínez's avatar
      build: meson: Remove polkit_dir option · 4b32bbc8
      Inigo Martínez authored
      meson is able to get variables defined in pkg-config files such as
      directory paths. PolicyKit defines in its pkg-config file the path to
      the directory where `policy` files are present.
      
      This removes the `polkit_dir` option to ease the move to start using
      those variables. The `polkit` variable has also been converted to
      boolean.
      
      Fedora spec script has also been updated accordingly.
      4b32bbc8
  14. 11 Dec, 2018 1 commit
    • Thomas Haller's avatar
      contrib/rpm: adjust match-device spec for 00-server-dhcp-client-id.conf · 3627601b
      Thomas Haller authored
      For older NetworkManager versions, a match spec that only contained except:
      specifiers could never yield a positive match. That is not very useful and
      got fixed by commit 242de347adbf653a709607979d36a0da1ca3ff0b (core: fix
      device spec matching for a list of "except:").
      
      Still, adjust the configuration snippet so that it also works with
      configurations that predate the fix.
      3627601b
  15. 09 Nov, 2018 1 commit
    • Beniamino Galvani's avatar
      rpm: disable ebpf support on RHEL · 570c41aa
      Beniamino Galvani authored
      The ebpf syscall doesn't work on RHEL even if the linux/bpf.h header
      is available: let's explicitly disable it.
      
      On Fedora explicitly enable eBPF instead of autodetecting it.
      570c41aa
  16. 07 Nov, 2018 1 commit
  17. 01 Nov, 2018 1 commit
    • Thomas Haller's avatar
      contrib/rpm: add "00-server-dhcp-client-id.conf" · 7a46ccff
      Thomas Haller authored
      While this is packaged in "NetworkManager-config-server.rpm"
      sub-package, it's not in "00-server.conf" file. The reason
      is that a convenient way to disable configuration from
      "/usr/lib/NetworkManager/conf.d", is by putting a (possibly empty)
      file into /etc directory with the same name. If the sub-package
      only provides one large "00-server.conf" file, this is no longer
      possible at a granular level.
      7a46ccff
  18. 24 Oct, 2018 1 commit
    • Thomas Haller's avatar
      build: fix build_clean.sh script to enable ibft · b660a41c
      Thomas Haller authored
      autotools build has/had a bug, where ibft test files would only be disted
      if the ibft plugin was enabled.
      
      Regardless of that, `build_clean.sh --release` is our suggested way to
      create a release tarball. It should always enable the ibft plugin.
      
      It didn't do so, due to a bug.
      b660a41c
  19. 22 Oct, 2018 2 commits
  20. 12 Oct, 2018 1 commit
    • Michael Biebl's avatar
      systemd: don't make NetworkManager D-Bus activatable · 90f71c0f
      Michael Biebl authored
      If the NetworkManager daemon has been stopped manually we don't want it
      to be autostarted by a client request.
      
      [lkundrak@v3.sk: The auto-activation is probably more surprising than useful.
      Services that need NetworkManager API should depend on NetworkManager service
      directly.
      
      I have no idea what purpose does the D-Bus service file serve nowadays,
      but it looks rather hacky (really, activating /bin/false) and the comment
      in it suggests that the autoactivating behavior was not intended anyway.
      Debian has been shipping this for quite some time and no complains have been
      heard.]
      
      https://github.com/NetworkManager/NetworkManager/pull/230
      90f71c0f