1. 16 Jun, 2016 1 commit
    • Thomas Haller's avatar
      shared: move shared files to subdirectory "shared/nm-utils/" · 4b288136
      Thomas Haller authored
      The "shared" directory contains files that are possibly used by all components
      of NetworkManager repository.
      
      Some of these files are even copied as-is to other projects (VPN plugins, nm-applet)
      and used there without modification. Move those files to a separate directory.
      By moving them to a common directory, it is clearer that they belong
      together. Also, you can easier compare the copied versions to their
      original via
      
        $ diff -r ./shared/nm-utils/ /path/to/nm-vpn-plugin/shared/nm-utils/
      4b288136
  2. 15 Jun, 2016 12 commits
  3. 10 Jun, 2016 1 commit
  4. 09 Jun, 2016 3 commits
    • Thomas Haller's avatar
    • Thomas Haller's avatar
      build: remove assertion messages in non-debug build · 00f58adb
      Thomas Haller authored
      Assertions like g_assert*() and g_return_*() contain the stringified
      test expression. This string ends up in the binary and increases its
      size.
      
      We usually don't have failing assertions. These string are a waste,
      instead the file and line number shall suffice.
      
      It reduces the striped size of the NetworkManager binary from 2500k
      to 2392k, that is -108k, -4.3%.
      
      This changes
      
       - "g_assert (1 == 2);"
         from: NetworkManager:ERROR:source.c:347:some_function: assertion failed: (1 == 2)
         to:   NetworkManager:ERROR:source.c:347:<unknown-fcn>: assertion failed: (<dropped>)
      
       - "g_return_if_fail (1 == 2);"
         from: (process:21024): NetworkManager-CRITICAL **: some_function: assertion '1 == 2' failed
         to:   (process:21024): NetworkManager-CRITICAL **: ((source.c:347)): assertion '<dropped>' failed
      
      When doing a non-debug build, those string are now removed. Debug-builds
      can be enabled by setting --with-more-assert=$LEVEL to larger then zero.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=767296
      00f58adb
    • Thomas Haller's avatar
      tests: add macro NMTST_G_RETURN_MSG for expecting g_return*() failures · fa973afa
      Thomas Haller authored
      A failure to g_return*() by default prints a g_critical() with stringifing the
      condition. Add a macro NMTST_G_RETURN_MSG() that reproduces that line to more
      accurately match the failure message.
      fa973afa
  5. 07 Jun, 2016 6 commits
  6. 06 Jun, 2016 6 commits
  7. 05 Jun, 2016 2 commits
  8. 03 Jun, 2016 9 commits