1. 23 Apr, 2018 15 commits
    • Beniamino Galvani's avatar
      core: fix bus initialization order · 4672499b
      Beniamino Galvani authored
      We currently start the bus manager only after the creation of a
      NMManager because the NMManager is needed to handle set-property bus
      calls. However, objects created by NMManager
      (e.g. NMDnsSystemdResolved) need a bus connection and so their
      initialization currently fail.
      
      To fix this, split nm_dbus_manager_start() in two parts: first only
      create the connection and acquire the bus.  After this step the
      NMManager can be set up. In the second step, set NMManager as the
      set-property handler and start exporting objects on the bus.
      
      Fixes: 297d4985
      4672499b
    • Beniamino Galvani's avatar
      libnm-core: fix validation of connection.mdns setting · 0498c548
      Beniamino Galvani authored
      Commit 9d92848a ("libnm: rename MDns flag UNKNOWN to DEFAULT")
      changed the enum order without updating verify().
      
      Fixes: 9d92848a
      0498c548
    • Beniamino Galvani's avatar
      core: fix misspellings of 'acquire' · ff9ecbad
      Beniamino Galvani authored
      ff9ecbad
    • Thomas Haller's avatar
    • Thomas Haller's avatar
      cli: sort DHCP options in connection show output · f2109cb8
      Thomas Haller authored
      Otherwise, the output is unstable and changes every time.
      f2109cb8
    • Thomas Haller's avatar
      5e69b8b9
    • Thomas Haller's avatar
      core: sort DHCP options that are exported on D-Bus · e96b1270
      Thomas Haller authored
      Otherwise, the order is undefined and unstable. If you call
      GetManagedObjects() on D-Bus multiple times, it's a very nice
      property if the diff is small and not full not noise.
      e96b1270
    • Thomas Haller's avatar
      86b54a65
    • Thomas Haller's avatar
      systemd: merge branch systemd into master · 93298449
      Thomas Haller authored
      93298449
    • Thomas Haller's avatar
      5d5b9d7c
    • Thomas Haller's avatar
      systemd: update code from upstream (2018-04-23) · c4dd6208
      Thomas Haller authored
      This is a direct dump from systemd git.
      
      ======
      
      SYSTEMD_DIR=../systemd
      COMMIT=41d0da0f6a800b7f1d56d6d15cf90edb6c062050
      
      (
        cd "$SYSTEMD_DIR"
        git checkout "$COMMIT"
        git reset --hard
        git clean -fdx
      )
      
      git ls-files :/src/systemd/src/ \
                   :/shared/nm-utils/siphash24.c \
                   :/shared/nm-utils/siphash24.h \
                   :/shared/nm-utils/unaligned.h | \
        xargs -d '\n' rm -f
      
      nm_copy_sd() {
          mkdir -p "./src/systemd/$(dirname "$1")"
          cp "$SYSTEMD_DIR/$1" "./src/systemd/$1"
      }
      
      nm_copy_sd_shared() {
          mkdir -p "./shared/nm-utils/"
          cp "$SYSTEMD_DIR/$1" "./shared/nm-utils/${1##*/}"
      }
      
      nm_copy_sd "src/basic/alloc-util.c"
      nm_copy_sd "src/basic/alloc-util.h"
      nm_copy_sd "src/basic/async.h"
      nm_copy_sd "src/basic/escape.c"
      nm_copy_sd "src/basic/escape.h"
      nm_copy_sd "src/basic/ether-addr-util.c"
      nm_copy_sd "src/basic/ether-addr-util.h"
      nm_copy_sd "src/basic/extract-word.c"
      nm_copy_sd "src/basic/extract-word.h"
      nm_copy_sd "src/basic/fileio.c"
      nm_copy_sd "src/basic/fileio.h"
      nm_copy_sd "src/basic/fd-util.c"
      nm_copy_sd "src/basic/fd-util.h"
      nm_copy_sd "src/basic/fs-util.c"
      nm_copy_sd "src/basic/fs-util.h"
      nm_copy_sd "src/basic/hash-funcs.c"
      nm_copy_sd "src/basic/hash-funcs.h"
      nm_copy_sd "src/basic/hashmap.c"
      nm_copy_sd "src/basic/hashmap.h"
      nm_copy_sd "src/basic/hexdecoct.c"
      nm_copy_sd "src/basic/hexdecoct.h"
      nm_copy_sd "src/basic/hostname-util.c"
      nm_copy_sd "src/basic/hostname-util.h"
      nm_copy_sd "src/basic/in-addr-util.c"
      nm_copy_sd "src/basic/in-addr-util.h"
      nm_copy_sd "src/basic/io-util.c"
      nm_copy_sd "src/basic/io-util.h"
      nm_copy_sd "src/basic/list.h"
      nm_copy_sd "src/basic/log.h"
      nm_copy_sd "src/basic/macro.h"
      nm_copy_sd "src/basic/mempool.h"
      nm_copy_sd "src/basic/mempool.c"
      nm_copy_sd "src/basic/parse-util.c"
      nm_copy_sd "src/basic/parse-util.h"
      nm_copy_sd "src/basic/path-util.c"
      nm_copy_sd "src/basic/path-util.h"
      nm_copy_sd "src/basic/prioq.h"
      nm_copy_sd "src/basic/prioq.c"
      nm_copy_sd "src/basic/process-util.h"
      nm_copy_sd "src/basic/process-util.c"
      nm_copy_sd "src/basic/random-util.c"
      nm_copy_sd "src/basic/random-util.h"
      nm_copy_sd "src/basic/refcnt.h"
      nm_copy_sd "src/basic/set.h"
      nm_copy_sd "src/basic/signal-util.h"
      nm_copy_sd_shared "src/basic/siphash24.c"
      nm_copy_sd_shared "src/basic/siphash24.h"
      nm_copy_sd "src/basic/socket-util.c"
      nm_copy_sd "src/basic/socket-util.h"
      nm_copy_sd "src/basic/sparse-endian.h"
      nm_copy_sd "src/basic/stdio-util.h"
      nm_copy_sd "src/basic/string-table.c"
      nm_copy_sd "src/basic/string-table.h"
      nm_copy_sd "src/basic/string-util.c"
      nm_copy_sd "src/basic/string-util.h"
      nm_copy_sd "src/basic/strv.c"
      nm_copy_sd "src/basic/strv.h"
      nm_copy_sd "src/basic/time-util.c"
      nm_copy_sd "src/basic/time-util.h"
      nm_copy_sd "src/basic/umask-util.h"
      nm_copy_sd_shared "src/basic/unaligned.h"
      nm_copy_sd "src/basic/utf8.c"
      nm_copy_sd "src/basic/utf8.h"
      nm_copy_sd "src/basic/util.c"
      nm_copy_sd "src/basic/util.h"
      nm_copy_sd "src/libsystemd-network/arp-util.c"
      nm_copy_sd "src/libsystemd-network/arp-util.h"
      nm_copy_sd "src/libsystemd-network/dhcp6-internal.h"
      nm_copy_sd "src/libsystemd-network/dhcp6-lease-internal.h"
      nm_copy_sd "src/libsystemd-network/dhcp6-network.c"
      nm_copy_sd "src/libsystemd-network/dhcp6-option.c"
      nm_copy_sd "src/libsystemd-network/dhcp6-protocol.h"
      nm_copy_sd "src/libsystemd-network/dhcp-identifier.c"
      nm_copy_sd "src/libsystemd-network/dhcp-identifier.h"
      nm_copy_sd "src/libsystemd-network/dhcp-internal.h"
      nm_copy_sd "src/libsystemd-network/dhcp-lease-internal.h"
      nm_copy_sd "src/libsystemd-network/dhcp-network.c"
      nm_copy_sd "src/libsystemd-network/dhcp-option.c"
      nm_copy_sd "src/libsystemd-network/dhcp-packet.c"
      nm_copy_sd "src/libsystemd-network/dhcp-protocol.h"
      nm_copy_sd "src/libsystemd-network/lldp-internal.h"
      nm_copy_sd "src/libsystemd-network/lldp-neighbor.c"
      nm_copy_sd "src/libsystemd-network/lldp-neighbor.h"
      nm_copy_sd "src/libsystemd-network/lldp-network.c"
      nm_copy_sd "src/libsystemd-network/lldp-network.h"
      nm_copy_sd "src/libsystemd-network/network-internal.c"
      nm_copy_sd "src/libsystemd-network/network-internal.h"
      nm_copy_sd "src/libsystemd-network/sd-dhcp6-client.c"
      nm_copy_sd "src/libsystemd-network/sd-dhcp6-lease.c"
      nm_copy_sd "src/libsystemd-network/sd-dhcp-client.c"
      nm_copy_sd "src/libsystemd-network/sd-dhcp-lease.c"
      nm_copy_sd "src/libsystemd-network/sd-ipv4ll.c"
      nm_copy_sd "src/libsystemd-network/sd-ipv4acd.c"
      nm_copy_sd "src/libsystemd-network/sd-lldp.c"
      nm_copy_sd "src/libsystemd/sd-event/sd-event.c"
      nm_copy_sd "src/libsystemd/sd-id128/id128-util.c"
      nm_copy_sd "src/libsystemd/sd-id128/id128-util.h"
      nm_copy_sd "src/libsystemd/sd-id128/sd-id128.c"
      nm_copy_sd "src/shared/dns-domain.c"
      nm_copy_sd "src/shared/dns-domain.h"
      nm_copy_sd "src/systemd/_sd-common.h"
      nm_copy_sd "src/systemd/sd-dhcp6-client.h"
      nm_copy_sd "src/systemd/sd-dhcp6-lease.h"
      nm_copy_sd "src/systemd/sd-dhcp-client.h"
      nm_copy_sd "src/systemd/sd-dhcp-lease.h"
      nm_copy_sd "src/systemd/sd-event.h"
      nm_copy_sd "src/systemd/sd-ndisc.h"
      nm_copy_sd "src/systemd/sd-id128.h"
      nm_copy_sd "src/systemd/sd-ipv4acd.h"
      nm_copy_sd "src/systemd/sd-ipv4ll.h"
      nm_copy_sd "src/systemd/sd-lldp.h"
      c4dd6208
    • Lubomir Rintel's avatar
      n-acd: don't use a return value in deallocator · de8bf742
      Lubomir Rintel authored
      ...so that its prototype is compatible with GDestroyNotify:
      
      src/devices/nm-acd-manager.c: In function ‘destroy_address_info’:
      /usr/include/glib-2.0/glib/gmem.h:120:31: error: cast between incompatible function types from ‘NAcd * (*)(NAcd *)’ {aka ‘struct NAcd * (*)(struct NAcd *)’} to ‘void (*)(void *)’ [-Werror=cast-function-type]
           GDestroyNotify _destroy = (GDestroyNotify) (destroy);                      \
                                     ^
      src/devices/nm-acd-manager.c:430:2: note: in expansion of macro ‘g_clear_pointer’
        g_clear_pointer (&info->acd, n_acd_free);
        ^~~~~~~~~~~~~~~
      
      The same change was done upstream, so the subsequent subtree pull of n-acd
      won't mess this up.
      de8bf742
    • Lubomir Rintel's avatar
      test-common: drop unused variables · c8989691
      Lubomir Rintel authored
      src/platform/tests/test-common.c:1500:17: error: unused variable 'dev' [-Werror,-Wunused-variable]
                      gs_free char *dev = NULL;
                                    ^
      src/platform/tests/test-common.c:1501:17: error: unused variable 'local' [-Werror,-Wunused-variable]
                      gs_free char *local = NULL, *remote = NULL;
                                    ^
      src/platform/tests/test-common.c:1501:32: error: unused variable 'remote' [-Werror,-Wunused-variable]
                      gs_free char *local = NULL, *remote = NULL;
                                                   ^
      Fixes: bd8ab54b
      c8989691
    • Lubomir Rintel's avatar
      auth-manager: drop an unused variable · 40ce80cb
      Lubomir Rintel authored
      src/nm-auth-manager.c:673:24: error: unused variable 'error_disposing' [-Werror,-Wunused-variable]
              gs_free_error GError *error_disposing = NULL;
                                    ^
      
      Fixes: 2ea2df31
      40ce80cb
    • Lubomir Rintel's avatar
      acd-manager: drop an unused variable · 30814288
      Lubomir Rintel authored
      src/devices/nm-acd-manager.c:299:16: error: unused variable 'timeout_str' [-Werror,-Wunused-variable]
              gs_free char *timeout_str = NULL;
                            ^
      Fixes: 9f79ae68
      30814288
  2. 21 Apr, 2018 3 commits
  3. 20 Apr, 2018 8 commits
  4. 19 Apr, 2018 14 commits