Commit c274b565 authored by Thomas Haller's avatar Thomas Haller

cli: avoid out-of-bounds-read for show_device_info()

Probably not critical, because it will still include
the terminating NULL, and just continue to fill the
temporary buffer with static addresses.

Found by coverity.

Fixes: bfb9fd0d
parent 62d4dba7
......@@ -1113,8 +1113,8 @@ show_device_info (NMDevice *device, NmCli *nmc)
(const NMMetaAbstractInfo *const*) nmc_fields_dev_show_general,
FALSE, NULL, NULL);
row = g_new0 (NmcOutputField, _NM_META_SETTING_TYPE_NUM + 1);
for (i = 0; i < _NM_META_SETTING_TYPE_NUM; i++)
row = g_new0 (NmcOutputField, G_N_ELEMENTS (nmc_fields_dev_show_general));
for (i = 0; i < G_N_ELEMENTS (nmc_fields_dev_show_general); i++)
row[i].info = (const NMMetaAbstractInfo *) &nmc_fields_dev_show_general[i];
print_required_fields (&nmc->nmc_config, NMC_OF_FLAG_MAIN_HEADER_ONLY,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment