Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
NetworkManager
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
146
Issues
146
List
Boards
Labels
Service Desk
Milestones
Merge Requests
11
Merge Requests
11
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Packages & Registries
Packages & Registries
Container Registry
Analytics
Analytics
CI / CD
Repository
Value Stream
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
NetworkManager
NetworkManager
Commits
c1017d04
Commit
c1017d04
authored
Dec 19, 2013
by
Dan Winship
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
tui: rename nmt_newt_error_dialog() to nmt_newt_message_dialog()
parent
eb9cd6da
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
28 additions
and
31 deletions
+28
-31
tui/newt/nmt-newt-utils.c
tui/newt/nmt-newt-utils.c
+7
-9
tui/newt/nmt-newt-utils.h
tui/newt/nmt-newt-utils.h
+2
-2
tui/nmt-connect-connection-list.c
tui/nmt-connect-connection-list.c
+1
-1
tui/nmt-editor.c
tui/nmt-editor.c
+10
-10
tui/nmtui-connect.c
tui/nmtui-connect.c
+1
-1
tui/nmtui-edit.c
tui/nmtui-edit.c
+5
-6
tui/nmtui-hostname.c
tui/nmtui-hostname.c
+2
-2
No files found.
tui/newt/nmt-newt-utils.c
View file @
c1017d04
...
...
@@ -146,18 +146,16 @@ nmt_newt_finished (void)
}
/**
* nmt_newt_
error
_dialog:
* nmt_newt_
message
_dialog:
* @message: a printf()-style message format
* @...: arguments
*
* Displays the given message in a dialog box with a single "OK"
* button, and returns after the user clicks "OK".
*
* FIXME: it's not just for errors any more!
*/
void
nmt_newt_
error
_dialog
(
const
char
*
message
,
...)
nmt_newt_
message
_dialog
(
const
char
*
message
,
...)
{
va_list
ap
;
char
*
msg
,
*
msg_lc
,
*
ok_lc
;
...
...
@@ -284,7 +282,7 @@ nmt_newt_edit_string (const char *data)
fd
=
g_file_open_tmp
(
"XXXXXX.json"
,
&
filename
,
&
error
);
if
(
fd
==
-
1
)
{
nmt_newt_
error
_dialog
(
_
(
"Could not create temporary file: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Could not create temporary file: %s"
),
error
->
message
);
g_error_free
(
error
);
return
NULL
;
}
...
...
@@ -316,19 +314,19 @@ nmt_newt_edit_string (const char *data)
newtResume
();
if
(
error
)
{
nmt_newt_
error
_dialog
(
_
(
"Could not create temporary file: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Could not create temporary file: %s"
),
error
->
message
);
g_error_free
(
error
);
goto
done
;
}
if
(
!
g_spawn_check_exit_status
(
status
,
&
error
))
{
nmt_newt_
error
_dialog
(
_
(
"Editor failed: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Editor failed: %s"
),
error
->
message
);
g_error_free
(
error
);
goto
done
;
}
if
(
!
g_file_get_contents
(
filename
,
&
new_data
,
NULL
,
&
error
))
{
nmt_newt_
error
_dialog
(
_
(
"Could not re-read file: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Could not re-read file: %s"
),
error
->
message
);
g_error_free
(
error
);
goto
done
;
}
...
...
tui/newt/nmt-newt-utils.h
View file @
c1017d04
...
...
@@ -37,8 +37,8 @@ typedef enum {
char
*
nmt_newt_locale_to_utf8
(
const
char
*
str_lc
);
char
*
nmt_newt_locale_from_utf8
(
const
char
*
str_utf8
);
void
nmt_newt_
error
_dialog
(
const
char
*
message
,
...);
void
nmt_newt_
message
_dialog
(
const
char
*
message
,
...);
int
nmt_newt_choice_dialog
(
const
char
*
button1
,
const
char
*
button2
,
const
char
*
message
,
...
...
tui/nmt-connect-connection-list.c
View file @
c1017d04
...
...
@@ -702,7 +702,7 @@ nmt_connect_connection_list_activated (NmtNewtWidget *widget)
activate_nmt_connection_async
(
NMT_CONNECT_CONNECTION_LIST
(
widget
),
nmtconn
,
activate_complete
,
&
op
);
if
(
!
nmt_sync_op_wait_boolean
(
&
op
,
&
error
))
{
nmt_newt_
error
_dialog
(
_
(
"Could not activate connection: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Could not activate connection: %s"
),
error
->
message
);
g_error_free
(
error
);
}
}
...
...
tui/nmt-editor.c
View file @
c1017d04
...
...
@@ -78,12 +78,12 @@ nmt_editor_new (NMConnection *connection)
s_con
=
nm_connection_get_setting_connection
(
connection
);
if
(
s_con
)
{
nmt_newt_
error
_dialog
(
_
(
"Could not create editor for connection '%s' of type '%s'."
),
nm_connection_get_id
(
connection
),
nm_setting_connection_get_connection_type
(
s_con
));
nmt_newt_
message
_dialog
(
_
(
"Could not create editor for connection '%s' of type '%s'."
),
nm_connection_get_id
(
connection
),
nm_setting_connection_get_connection_type
(
s_con
));
}
else
{
nmt_newt_
error
_dialog
(
_
(
"Could not create editor for invalid connection '%s'."
),
nm_connection_get_id
(
connection
));
nmt_newt_
message
_dialog
(
_
(
"Could not create editor for invalid connection '%s'."
),
nm_connection_get_id
(
connection
));
}
return
NULL
;
...
...
@@ -131,7 +131,7 @@ save_connection_and_exit (NmtNewtButton *button,
if
(
!
nm_connection_replace_settings_from_connection
(
priv
->
orig_connection
,
priv
->
edit_connection
,
&
error
))
{
nmt_newt_
error
_dialog
(
_
(
"Error saving connection: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Error saving connection: %s"
),
error
->
message
);
g_error_free
(
error
);
return
;
}
...
...
@@ -141,8 +141,8 @@ save_connection_and_exit (NmtNewtButton *button,
nm_remote_connection_commit_changes
(
NM_REMOTE_CONNECTION
(
priv
->
orig_connection
),
connection_updated
,
&
op
);
if
(
!
nmt_sync_op_wait_boolean
(
&
op
,
&
error
))
{
nmt_newt_
error
_dialog
(
_
(
"Unable to save connection: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Unable to save connection: %s"
),
error
->
message
);
g_error_free
(
error
);
return
;
}
...
...
@@ -155,8 +155,8 @@ save_connection_and_exit (NmtNewtButton *button,
nm_remote_settings_add_connection
(
nm_settings
,
priv
->
orig_connection
,
connection_added
,
&
op
);
if
(
!
nmt_sync_op_wait_boolean
(
&
op
,
&
error
))
{
nmt_newt_
error
_dialog
(
_
(
"Unable to add new connection: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Unable to add new connection: %s"
),
error
->
message
);
g_error_free
(
error
);
return
;
}
...
...
tui/nmtui-connect.c
View file @
c1017d04
...
...
@@ -69,7 +69,7 @@ nmt_connect_connection (const char *identifier)
nmt_connect_connection_list_activate_async
(
NMT_CONNECT_CONNECTION_LIST
(
list
),
identifier
,
connect_complete
,
&
op
);
if
(
!
nmt_sync_op_wait_boolean
(
&
op
,
&
error
))
{
nmt_newt_
error
_dialog
(
_
(
"Could not activate connection: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Could not activate connection: %s"
),
error
->
message
);
g_error_free
(
error
);
nmtui_quit
();
}
...
...
tui/nmtui-edit.c
View file @
c1017d04
...
...
@@ -440,9 +440,8 @@ connection_deleted_callback (NMRemoteConnection *connection,
ConnectionDeleteData
*
data
=
user_data
;
if
(
error
)
{
nmt_newt_error_dialog
(
_
(
"OK"
),
_
(
"Unable to delete connection: %s"
),
error
->
message
);
nmt_newt_message_dialog
(
_
(
"Unable to delete connection: %s"
),
error
->
message
);
}
else
data
->
got_callback
=
TRUE
;
...
...
@@ -484,8 +483,8 @@ nmt_remove_connection (NMRemoteConnection *connection)
nm_remote_connection_delete
(
connection
,
connection_deleted_callback
,
&
data
);
if
(
!
nmt_sync_op_wait_boolean
(
&
data
.
op
,
&
error
))
{
nmt_newt_
error
_dialog
(
_
(
"Could not delete connection: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Could not delete connection: %s"
),
error
->
message
);
g_error_free
(
error
);
}
...
...
@@ -517,7 +516,7 @@ nmtui_edit (int argc, char **argv)
}
if
(
!
conn
)
{
nmt_newt_
error
_dialog
(
"%s: no such connection '%s'
\n
"
,
argv
[
0
],
argv
[
1
]);
nmt_newt_
message
_dialog
(
"%s: no such connection '%s'
\n
"
,
argv
[
0
],
argv
[
1
]);
nmtui_quit
();
return
;
}
...
...
tui/nmtui-hostname.c
View file @
c1017d04
...
...
@@ -111,9 +111,9 @@ nmtui_hostname (int argc, char **argv)
nm_remote_settings_save_hostname
(
nm_settings
,
hostname
,
hostname_set
,
&
op
);
if
(
nmt_sync_op_wait_boolean
(
&
op
,
&
error
))
{
/* Translators: this indicates the result. ie, "I have set the hostname to ..." */
nmt_newt_
error
_dialog
(
_
(
"Set hostname to '%s'"
),
hostname
);
nmt_newt_
message
_dialog
(
_
(
"Set hostname to '%s'"
),
hostname
);
}
else
{
nmt_newt_
error
_dialog
(
_
(
"Unable to set hostname: %s"
),
error
->
message
);
nmt_newt_
message
_dialog
(
_
(
"Unable to set hostname: %s"
),
error
->
message
);
g_error_free
(
error
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment