Commit aed6e284 authored by Thomas Haller's avatar Thomas Haller
Browse files

trivial: avoid XXX tag and replace by NOTE or FIXME

XXX was used to either raise attention (NOTE) or to indicate
that this is ugly code that should be fixed (FIXME). The usage
was inconsistent.

Let's avoid XXX and use either NOTE or FIXME.
parent b411b54e
......@@ -2,7 +2,7 @@ AC_PREREQ([2.63])
dnl The NM version number
dnl
dnl XXX: When incrementing version also:
dnl NOTE: When incrementing version also:
dnl - add corresponding NM_VERSION_x_y_z macros in
dnl "shared/nm-version-macros.h.in"
dnl - update number in meson.build
......
......@@ -302,7 +302,7 @@ foreach_item_helper (NMSettingVpn *self,
const char *value;
value = g_hash_table_lookup (hash, keys[i]);
/* XXX: note that we call the function with a clone of @key,
/* NOTE: note that we call the function with a clone of @key,
* not with the actual key from the dictionary.
*
* The @value on the other hand, is actually inside our dictionary,
......
......@@ -608,8 +608,9 @@ handle_object_property (NMObject *self, const char *property_name, GVariant *val
object = g_dbus_object_manager_get_object (priv->object_manager, path);
if (!object) {
/* This is a server bug -- a dangling object path for an object
* that does not exist. */
/* XXX: We've ignored this before and the server hits the condition
* that does not exist.
*
* NOTE: We've ignored this before and the server hits the condition
* more often that it should. Given we're able to recover from
* ther error, let's lower the severity of the log message to
* avoid unnecessarily bothering the user. This can be removed
......
project(
'NetworkManager', 'c',
# XXX: When incrementing version also:
# NOTE: When incrementing version also:
# - add corresponding NM_VERSION_x_y_z macros in
# "shared/nm-version-macros.h.in"
# - update number in configure.ac
......
......@@ -433,7 +433,7 @@ create_device (NMDeviceFactory *factory,
NM_DEVICE_TYPE_DESC, "InfiniBand",
NM_DEVICE_DEVICE_TYPE, NM_DEVICE_TYPE_INFINIBAND,
NM_DEVICE_LINK_TYPE, NM_LINK_TYPE_INFINIBAND,
/* XXX: Partition should probably be a different link type! */
/* NOTE: Partition should probably be a different link type! */
NM_DEVICE_INFINIBAND_IS_PARTITION, is_partition,
NULL);
}
......
......@@ -98,9 +98,9 @@ ip6tnl_flags_setting_to_plat (NMIPTunnelFlags flags)
G_STATIC_ASSERT (NM_IP_TUNNEL_FLAG_IP6_RCV_DSCP_COPY == IP6_TNL_F_RCV_DSCP_COPY);
G_STATIC_ASSERT (NM_IP_TUNNEL_FLAG_IP6_USE_ORIG_FWMARK == IP6_TNL_F_USE_ORIG_FWMARK);
/* XXX: "accidentally", the numeric values correspond.
* For flags added in the future, that might no longer
* be the case. */
/* NOTE: "accidentally", the numeric values correspond.
* For flags added in the future, that might no longer
* be the case. */
return flags & _NM_IP_TUNNEL_FLAG_ALL_IP6TNL;
}
......
......@@ -7906,7 +7906,7 @@ addrconf6_start_with_link_ready (NMDevice *self)
g_clear_object (&priv->con_ip6_config);
}
/* XXX: These sysctls would probably be better set by the lndp ndisc itself. */
/* FIXME: These sysctls would probably be better set by the lndp ndisc itself. */
switch (nm_ndisc_get_node_type (priv->ndisc)) {
case NM_NDISC_NODE_TYPE_HOST:
/* Accepting prefixes from discovered routers. */
......
......@@ -418,7 +418,7 @@ get_best_ip_device (NMPolicy *self,
r = nm_device_get_best_default_route (device, addr_family);
if (r) {
/* XXX: the best route might have rt_source NM_IP_CONFIG_SOURCE_VPN,
/* NOTE: the best route might have rt_source NM_IP_CONFIG_SOURCE_VPN,
* which means it was injected by a VPN, not added by device.
*
* In this case, is it really the best device? Why do we even need the best
......
......@@ -406,7 +406,7 @@ typedef union {
* do not exist from the point-of-view of platform users.
* Such a route is not alive, according to nmp_object_is_alive().
*
* XXX: currently we ignore all flags except RTM_F_CLONED
* NOTE: currently we ignore all flags except RTM_F_CLONED
* and RTNH_F_ONLINK for IPv4.
* We also may not properly consider the flags as part of the ID
* in route-cmp. */ \
......
......@@ -2685,7 +2685,7 @@ _autoconnect_retries_set (NMSettingsConnection *self,
if (retries)
priv->autoconnect_retries_blocked_until = 0;
else {
/* XXX: the blocked time must be identical for all connections, otherwise
/* NOTE: the blocked time must be identical for all connections, otherwise
* the tracking of resetting the retry count in NMPolicy needs adjustment
* in _connection_autoconnect_retries_set() (as it would need to re-evaluate
* the next-timeout everytime a connection gets blocked). */
......
......@@ -934,7 +934,7 @@ next:
: ""));
break;
case PARSE_LINE_TYPE_FLAG:
/* XXX: the flag (for "onlink") only allows to explictly set "TRUE".
/* NOTE: the flag (for "onlink") only allows to explictly set "TRUE".
* There is no way to express an explicit "FALSE" setting
* of this attribute, hence, the file format cannot encode
* that configuration. */
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment