all: drop unnecessary includes of <errno.h> and <string.h>

"nm-macros-interal.h" already includes <errno.h> and <string.h>.
No need to include it everywhere else too.

clients/cli/agent.c

@@ -25,7 +25,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <errno.h>
 #include <readline/readline.h>
 #include <readline/history.h>
 

clients/cli/common.c

@@ -25,7 +25,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <errno.h>
 #include <sys/ioctl.h>
 #include <readline/readline.h>
 #include <readline/history.h>

clients/cli/connections.c

@@ -22,10 +22,8 @@
 #include "connections.h"
 
 #include <stdio.h>
-#include <string.h>
 #include <stdlib.h>
 #include <unistd.h>
-#include <errno.h>
 #include <signal.h>
 #include <netinet/ether.h>
 #include <readline/readline.h>

clients/cli/devices.c

@@ -22,9 +22,7 @@
 #include "devices.h"
 
 #include <stdio.h>
-#include <string.h>
 #include <stdlib.h>
-#include <errno.h>
 #include <readline/readline.h>
 
 #include "nm-secret-agent-simple.h"

clients/cli/general.c

@@ -21,7 +21,6 @@
 
 #include "general.h"
 
-#include <string.h>
 #include <stdlib.h>
 
 #include "nm-common-macros.h"

clients/cli/nmcli.c

@@ -24,7 +24,6 @@
 #include "nmcli.h"
 
 #include <stdio.h>
-#include <string.h>
 #include <stdlib.h>
 #include <signal.h>
 #include <termios.h>

clients/cli/polkit-agent.c

@@ -22,7 +22,6 @@
 #include "polkit-agent.h"
 
 #include <stdio.h>
-#include <string.h>
 #include <sys/types.h>
 #include <unistd.h>
 

clients/cli/utils.c

@@ -23,9 +23,7 @@
 #include "utils.h"
 
 #include <stdio.h>
-#include <string.h>
 #include <stdlib.h>
-#include <errno.h>
 #include <sys/socket.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>

clients/common/nm-polkit-listener.c

@@ -35,7 +35,6 @@
 
 #include "nm-polkit-listener.h"
 
-#include <string.h>
 #include <stdio.h>
 #include <stdlib.h>
 

clients/common/nm-secret-agent-simple.c

@@ -35,7 +35,6 @@
 
 #include <gio/gunixoutputstream.h>
 #include <gio/gunixinputstream.h>
-#include <string.h>
 
 #include "nm-vpn-service-plugin.h"
 #include "nm-vpn-helpers.h"

clients/common/nm-vpn-helpers.c

@@ -25,8 +25,6 @@
 
 #include "nm-vpn-helpers.h"
 
-#include <string.h>
-
 #include "nm-utils.h"
 
 /*****************************************************************************/

clients/tui/newt/nmt-newt-button-box.c

@@ -31,9 +31,8 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nmt-newt-button-box.h"
+
 #include "nmt-newt-button.h"
 
 G_DEFINE_TYPE (NmtNewtButtonBox, nmt_newt_button_box, NMT_TYPE_NEWT_CONTAINER)

clients/tui/newt/nmt-newt-container.c

@@ -28,9 +28,8 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nmt-newt-container.h"
+
 #include "nmt-newt-component.h"
 
 G_DEFINE_ABSTRACT_TYPE (NmtNewtContainer, nmt_newt_container, NMT_TYPE_NEWT_WIDGET)

clients/tui/newt/nmt-newt-entry.c

@@ -28,8 +28,6 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nmt-newt-entry.h"
 #include "nmt-newt-form.h"
 #include "nmt-newt-hacks.h"

clients/tui/newt/nmt-newt-form.c

@@ -27,7 +27,6 @@
 #include "nm-default.h"
 
 #include <fcntl.h>
-#include <string.h>
 #include <unistd.h>
 
 #include "nmt-newt-form.h"

clients/tui/newt/nmt-newt-grid.c

@@ -42,8 +42,6 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nmt-newt-grid.h"
 
 G_DEFINE_TYPE (NmtNewtGrid, nmt_newt_grid, NMT_TYPE_NEWT_CONTAINER)

clients/tui/newt/nmt-newt-label.c

@@ -27,9 +27,8 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nmt-newt-label.h"
+
 #include "nmt-newt-utils.h"
 
 G_DEFINE_TYPE (NmtNewtLabel, nmt_newt_label, NMT_TYPE_NEWT_COMPONENT)

clients/tui/newt/nmt-newt-section.c

@@ -37,9 +37,8 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nmt-newt-section.h"
+
 #include "nmt-newt-grid.h"
 #include "nmt-newt-label.h"
 #include "nmt-newt-utils.h"

clients/tui/newt/nmt-newt-stack.c

@@ -31,8 +31,6 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nmt-newt-stack.h"
 
 G_DEFINE_TYPE (NmtNewtStack, nmt_newt_stack, NMT_TYPE_NEWT_CONTAINER)

clients/tui/newt/nmt-newt-textbox.c

@@ -26,9 +26,8 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nmt-newt-textbox.h"
+
 #include "nmt-newt-utils.h"
 
 G_DEFINE_TYPE (NmtNewtTextbox, nmt_newt_textbox, NMT_TYPE_NEWT_COMPONENT)

clients/tui/newt/nmt-newt-utils.c

@@ -23,7 +23,6 @@
 
 #include "nm-default.h"
 
-#include <errno.h>
 #include <stdarg.h>
 #include <unistd.h>
 #include <sys/wait.h>

clients/tui/nm-editor-bindings.c

@@ -27,12 +27,11 @@
 
 #include "nm-default.h"
 
+#include "nm-editor-bindings.h"
+
 #include <arpa/inet.h>
 #include <netinet/in.h>
 #include <stdlib.h>
-#include <string.h>
-
-#include "nm-editor-bindings.h"
 
 static void
 value_transform_string_int (const GValue *src_value,

clients/tui/nmt-address-list.c

@@ -30,12 +30,12 @@
 
 #include "nm-default.h"
 
+#include "nmt-address-list.h"
+
 #include <arpa/inet.h>
 #include <netinet/in.h>
 #include <stdlib.h>
-#include <string.h>
 
-#include "nmt-address-list.h"
 #include "nmt-ip-entry.h"
 
 G_DEFINE_TYPE (NmtAddressList, nmt_address_list, NMT_TYPE_WIDGET_LIST)

clients/tui/nmt-device-entry.c

@@ -36,12 +36,12 @@
 
 #include "nm-default.h"
 
-#include <string.h>
+#include "nmt-device-entry.h"
+
 #include <sys/socket.h>
 #include <linux/if_arp.h>
 
 #include "nmtui.h"
-#include "nmt-device-entry.h"
 
 G_DEFINE_TYPE (NmtDeviceEntry, nmt_device_entry, NMT_TYPE_EDITOR_GRID)
 

clients/tui/nmt-editor-grid.c

@@ -39,8 +39,6 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nmt-editor-grid.h"
 
 G_DEFINE_TYPE (NmtEditorGrid, nmt_editor_grid, NMT_TYPE_NEWT_CONTAINER)

clients/tui/nmt-mac-entry.c

@@ -30,8 +30,6 @@
 
 #include "nmt-mac-entry.h"
 
-#include <string.h>
-
 #include "nm-common-macros.h"
 
 G_DEFINE_TYPE (NmtMacEntry, nmt_mac_entry, NMT_TYPE_NEWT_ENTRY)

clients/tui/nmt-utils.c

@@ -23,8 +23,6 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nmt-utils.h"
 
 /**

clients/tui/nmt-widget-list.c

@@ -32,12 +32,12 @@
 
 #include "nm-default.h"
 
+#include "nmt-widget-list.h"
+
 #include <arpa/inet.h>
 #include <netinet/in.h>
 #include <stdlib.h>
-#include <string.h>
 
-#include "nmt-widget-list.h"
 #include "nmt-newt.h"
 
 G_DEFINE_TYPE (NmtWidgetList, nmt_widget_list, NMT_TYPE_NEWT_GRID)

clients/tui/nmtui.c

@@ -26,14 +26,14 @@
 
 #include "nm-default.h"
 
+#include "nmtui.h"
+
 #include <locale.h>
 #include <stdlib.h>
-#include <string.h>
 
 #include "nmt-newt.h"
 #include "nm-editor-bindings.h"
 
-#include "nmtui.h"
 #include "nmtui-edit.h"
 #include "nmtui-connect.h"
 #include "nmtui-hostname.h"

dispatcher/nm-dispatcher-utils.c

@@ -20,7 +20,7 @@
 
 #include "nm-default.h"
 
-#include <string.h>
+#include "nm-dispatcher-utils.h"
 
 #include "nm-dbus-interface.h"
 #include "nm-connection.h"
@@ -31,8 +31,6 @@
 #include "nm-dispatcher-api.h"
 #include "nm-utils.h"
 
-#include "nm-dispatcher-utils.h"
-
 /*****************************************************************************/
 
 static gboolean

dispatcher/nm-dispatcher.c

@@ -24,12 +24,10 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <stdlib.h>
-#include <string.h>
 #include <sys/types.h>
 #include <signal.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
-#include <errno.h>
 #include <arpa/inet.h>
 #include <glib-unix.h>
 

dispatcher/tests/test-dispatcher-envp.c

@@ -22,7 +22,6 @@
 
 #include <arpa/inet.h>
 #include <stdlib.h>
-#include <string.h>
 
 #include "nm-dispatcher-utils.h"
 #include "nm-dispatcher-api.h"

libnm-core/nm-connection.c

@@ -24,7 +24,6 @@
 
 #include "nm-connection.h"
 
-#include <string.h>
 #include <arpa/inet.h>
 
 #include "nm-connection-private.h"

libnm-core/nm-crypto.c

@@ -25,7 +25,6 @@
 
 #include "nm-crypto.h"
 
-#include <string.h>
 #include <strings.h>
 #include <unistd.h>
 #include <stdlib.h>

libnm-core/nm-dbus-utils.c

@@ -20,8 +20,6 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nm-core-internal.h"
 
 typedef struct {

libnm-core/nm-errors.c

@@ -20,9 +20,8 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-
 #include "nm-errors.h"
+
 #include "nm-vpn-dbus-interface.h"
 #include "nm-core-internal.h"
 

libnm-core/nm-keyfile-utils.c

@@ -20,10 +20,10 @@
 
 #include "nm-default.h"
 
+#include "nm-keyfile-utils.h"
+
 #include <stdlib.h>
-#include <string.h>
 
-#include "nm-keyfile-utils.h"
 #include "nm-keyfile-internal.h"
 #include "nm-setting-wired.h"
 #include "nm-setting-wireless.h"

libnm-core/nm-keyfile.c

@@ -23,14 +23,12 @@
 
 #include "nm-keyfile-internal.h"
 
-#include <errno.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <sys/stat.h>
 #include <unistd.h>
 #include <sys/types.h>
 #include <arpa/inet.h>
-#include <string.h>
 #include <linux/pkt_sched.h>
 
 #include "nm-utils/nm-secret-utils.h"

libnm-core/nm-property-compare.c

@@ -22,11 +22,10 @@
 
 #include "nm-default.h"
 
-#include <string.h>
-#include <netinet/in.h>
-
 #include "nm-property-compare.h"
 
+#include <netinet/in.h>
+
 static int
 _nm_property_compare_collection (GVariant *value1, GVariant *value2)
 {

libnm-core/nm-setting-8021x.c

@@ -24,8 +24,6 @@
 
 #include "nm-setting-8021x.h"
 
-#include <string.h>
-
 #include "nm-utils/nm-secret-utils.h"
 #include "nm-utils.h"
 #include "nm-crypto.h"

libnm-core/nm-setting-adsl.c

@@ -23,8 +23,6 @@
 
 #include "nm-setting-adsl.h"
 
-#include <string.h>
-
 #include "nm-setting-ppp.h"
 #include "nm-setting-private.h"
 #include "nm-utils.h"

libnm-core/nm-setting-bluetooth.c

@@ -24,7 +24,6 @@
 
 #include "nm-setting-bluetooth.h"
 
-#include <string.h>
 #include <net/ethernet.h>
 
 #include "nm-connection-private.h"

libnm-core/nm-setting-bond.c

@@ -23,9 +23,7 @@
 
 #include "nm-setting-bond.h"
 
-#include <string.h>
 #include <stdlib.h>
-#include <errno.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
 

libnm-core/nm-setting-bridge-port.c

@@ -23,7 +23,6 @@
 
 #include "nm-setting-bridge-port.h"
 
-#include <string.h>
 #include <ctype.h>
 #include <stdlib.h>
 

libnm-core/nm-setting-bridge.c

@@ -23,7 +23,6 @@
 
 #include "nm-setting-bridge.h"
 
-#include <string.h>
 #include <ctype.h>
 #include <stdlib.h>
 

libnm-core/nm-setting-cdma.c

@@ -23,8 +23,6 @@
 
 #include "nm-setting-cdma.h"
 
-#include <string.h>
-
 #include "nm-utils.h"
 #include "nm-setting-private.h"
 #include "nm-core-enum-types.h"

libnm-core/nm-setting-connection.c

@@ -24,8 +24,6 @@
 
 #include "nm-setting-connection.h"
 
-#include <string.h>
-
 #include "nm-utils.h"
 #include "nm-utils-private.h"
 #include "nm-core-enum-types.h"

libnm-core/nm-setting-dcb.c

@@ -23,8 +23,6 @@
 
 #include "nm-setting-dcb.h"
 
-#include <string.h>
-
 #include "nm-utils.h"
 #include "nm-utils-private.h"
 #include "nm-setting-private.h"

libnm-core/nm-setting-gsm.c

@@ -24,8 +24,6 @@
 
 #include "nm-setting-gsm.h"
 
-#include <string.h>
-
 #include "nm-utils.h"
 #include "nm-setting-private.h"
 #include "nm-core-enum-types.h"

libnm-core/nm-setting-ip-config.c

@@ -24,7 +24,6 @@
 
 #include "nm-setting-ip-config.h"
 
-#include <string.h>
 #include <arpa/inet.h>
 
 #include "nm-setting-ip4-config.h"

libnm-core/nm-setting-ip4-config.c

@@ -23,8 +23,6 @@
 
 #include "nm-setting-ip4-config.h"
 
-#include <string.h>
-
 #include "nm-setting-private.h"
 
 /**

libnm-core/nm-setting-ip6-config.c

@@ -23,7 +23,6 @@
 
 #include "nm-setting-ip6-config.h"
 
-#include <string.h>
 #include <arpa/inet.h>
 
 #include "nm-setting-private.h"

libnm-core/nm-setting-macsec.c

@@ -23,7 +23,6 @@
 #include "nm-setting-macsec.h"
 
 #include <stdlib.h>
-#include <string.h>
 
 #include "nm-utils/nm-secret-utils.h"
 

libnm-core/nm-setting-macvlan.c

@@ -24,7 +24,6 @@
 #include "nm-setting-macvlan.h"
 
 #include <stdlib.h>
-#include <string.h>
 
 #include "nm-utils.h"
 #include "nm-setting-connection.h"

libnm-core/nm-setting-olpc-mesh.c

@@ -24,8 +24,6 @@
 
 #include "nm-setting-olpc-mesh.h"
 
-#include <string.h>
-
 #include "nm-utils.h"
 #include "nm-utils-private.h"
 #include "nm-setting-private.h"

libnm-core/nm-setting-pppoe.c

@@ -24,8 +24,6 @@
 
 #include "nm-setting-pppoe.h"
 
-#include <string.h>
-
 #include "nm-setting-ppp.h"
 #include "nm-setting-private.h"
 #include "nm-core-enum-types.h"

libnm-core/nm-setting-serial.c

@@ -24,8 +24,6 @@
 
 #include "nm-setting-serial.h"
 
-#include <string.h>
-
 #include "nm-setting-private.h"
 
 /**

libnm-core/nm-setting-team-port.c

@@ -23,7 +23,6 @@
 
 #include "nm-setting-team-port.h"
 
-#include <string.h>
 #include <ctype.h>
 #include <stdlib.h>
 

libnm-core/nm-setting-team.c

@@ -23,7 +23,6 @@
 
 #include "nm-setting-team.h"
 
-#include <string.h>
 #include <stdlib.h>
 
 #include "nm-utils.h"

libnm-core/nm-setting-tun.c

@@ -24,7 +24,6 @@
 #include "nm-setting-tun.h"
 
 #include <stdlib.h>
-#include <string.h>
 
 #include "nm-utils.h"
 #include "nm-setting-connection.h"

libnm-core/nm-setting-vlan.c

@@ -24,7 +24,6 @@
 #include "nm-setting-vlan.h"