coverity: fix various warnings detected with Coverity

These are (most likely) only warnings and not severe bugs.
Some of these changes are mostly made to get a clean run of
Coverity without any warnings.

Error found by running Coverity scan

https://bugzilla.redhat.com/show_bug.cgi?id=1025894Co-Authored-By: Jiří Klimeš <jklimes@redhat.com>
Signed-off-by: Thomas Haller <thaller@redhat.com>

cli/src/connections.c

@@ -358,6 +358,7 @@ nmc_connection_detail (NMConnection *connection, NmCli *nmc)
 		nmc->return_value = NMC_RESULT_ERROR_USER_INPUT;
 		return FALSE;
 	}
+	g_assert (print_settings_array);
 
 	/* Main header */
 	nmc->print_fields.header_name = _("Connection details");
@@ -388,8 +389,7 @@ nmc_connection_detail (NMConnection *connection, NmCli *nmc)
 		}
 	}
 
-	if (print_settings_array)
-		g_array_free (print_settings_array, TRUE);
+	g_array_free (print_settings_array, TRUE);
 
 	return TRUE;
 }
@@ -859,6 +859,7 @@ nmc_active_connection_detail (NMActiveConnection *acon, NmCli *nmc)
 		nmc->return_value = NMC_RESULT_ERROR_USER_INPUT;
 		return FALSE;
 	}
+	g_assert (print_groups);
 
 	/* Main header */
 	nmc->print_fields.header_name = _("Active connection details");
@@ -978,8 +979,7 @@ nmc_active_connection_detail (NMActiveConnection *acon, NmCli *nmc)
 		}
 	}
 
-	if (print_groups)
-		g_array_free (print_groups, TRUE);
+	g_array_free (print_groups, TRUE);
 
 	return TRUE;
 }
@@ -5589,6 +5589,8 @@ connection_remove_setting (NMConnection *connection, NMSetting *setting)
 {
 	gboolean mandatory;
 
+	g_return_val_if_fail (setting, FALSE);
+
 	mandatory = is_setting_mandatory (connection, setting);
 	if (!mandatory) {
 		nm_connection_remove_setting (connection, G_OBJECT_TYPE (setting));
@@ -6268,6 +6270,7 @@ editor_menu_main (NmCli *nmc, NMConnection *connection, const char *connection_t
 						if (s_tmp) {
 							/* Remove setting from the connection */
 							connection_remove_setting (connection, s_tmp);
+							/* coverity[copy_paste_error] - suppress Coverity COPY_PASTE_ERROR defect */
 							if (ss == menu_ctx.curr_setting) {
 								/* If we removed the setting we are in, go up */
 								menu_switch_to_level0 (&menu_ctx, BASE_PROMPT, nmc->editor_prompt_color);
@@ -6382,14 +6385,14 @@ editor_menu_main (NmCli *nmc, NMConnection *connection, const char *connection_t
 			if (   menu_ctx.curr_setting
 			    && (!cmd_arg || strcmp (cmd_arg, "all") != 0)) {
 				GError *tmp_err = NULL;
-				nm_setting_verify (menu_ctx.curr_setting, NULL, &tmp_err);
+				(void) nm_setting_verify (menu_ctx.curr_setting, NULL, &tmp_err);
 				printf (_("Verify setting '%s': %s\n"),
 				        nm_setting_get_name (menu_ctx.curr_setting),
 				        tmp_err ? tmp_err->message : "OK");
 				g_clear_error (&tmp_err);
 			} else {
 				GError *tmp_err = NULL;
-				nm_connection_verify (connection, &tmp_err);
+				(void) nm_connection_verify (connection, &tmp_err);
 				printf (_("Verify connection: %s\n"),
 				        tmp_err ? tmp_err->message : "OK");
 				g_clear_error (&tmp_err);
@@ -6939,8 +6942,7 @@ do_connection_edit (NmCli *nmc, int argc, char **argv)
 	return nmc->return_value;
 
 error:
-	if (connection)
-		g_object_unref (connection);
+	g_assert (!connection);
 	g_free (type_ask);
 
 	nmc->should_wait = FALSE;

cli/src/devices.c

@@ -424,7 +424,7 @@ fill_output_access_point (gpointer data, gpointer user_data)
 	freq = nm_access_point_get_frequency (ap);
 	mode = nm_access_point_get_mode (ap);
 	bitrate = nm_access_point_get_max_bitrate (ap);
-	strength = CLAMP (nm_access_point_get_strength (ap), 0, 100);
+	strength = MIN (nm_access_point_get_strength (ap), 100);
 
 	/* Convert to strings */
 	ssid_str = nm_utils_ssid_to_utf8 (ssid);

cli/src/settings.c

@@ -1056,8 +1056,8 @@ nmc_property_connection_get_permissions (NMSetting *setting)
 
 	perm = g_string_new (NULL);
 	for (i = 0; i < nm_setting_connection_get_num_permissions (s_con); i++) {
-		nm_setting_connection_get_permission (s_con, i, &perm_type, &perm_item, NULL);
-		g_string_append_printf (perm, "%s:%s,", perm_type, perm_item);
+		if (nm_setting_connection_get_permission (s_con, i, &perm_type, &perm_item, NULL))
+			g_string_append_printf (perm, "%s:%s,", perm_type, perm_item);
 	}
 	if (perm->len > 0)
 		g_string_truncate (perm, perm->len-1); /* remove trailing , */

cli/src/utils.c

@@ -131,7 +131,7 @@ nmc_parse_args (nmc_arg_t *arg_arr, gboolean last, int *argc, char ***argv, GErr
 			if (have_mandatory && !last)
 				return TRUE;
 
-			if (p && p->name)
+			if (p->name)
 				g_set_error (error, NMCLI_ERROR, NMC_RESULT_ERROR_USER_INPUT,
 				             _("Error: Argument '%s' was expected, but '%s' provided."), p->name, **argv);
 			else

examples/C/glib/list-connections-dbus-glib.c

@@ -40,13 +40,19 @@ list_connections (DBusGProxy *proxy)
 	int i;
 	GError *error = NULL;
 	GPtrArray *con_array;
+	gboolean success;
 
 	/* Call ListConnections D-Bus method */
-	dbus_g_proxy_call (proxy, "ListConnections", &error,
-	                   /* No input arguments */
-	                   G_TYPE_INVALID,
-	                   DBUS_TYPE_G_ARRAY_OF_OBJECT_PATH, &con_array, /* Return values */
-	                   G_TYPE_INVALID);
+	success = dbus_g_proxy_call (proxy, "ListConnections", &error,
+	                             /* No input arguments */
+	                             G_TYPE_INVALID,
+	                             DBUS_TYPE_G_ARRAY_OF_OBJECT_PATH, &con_array, /* Return values */
+	                             G_TYPE_INVALID);
+	if (!success) {
+		printf ("ListConnections failed: %s", error->message);
+		g_error_free (error);
+		return;
+	}
 
 	for (i = 0; con_array && i < con_array->len; i++) {
 		char *connection_path = g_ptr_array_index (con_array, i);

libnm-glib/nm-client.c

@@ -1824,8 +1824,13 @@ static void
 constructed (GObject *object)
 {
 	NMClientPrivate *priv = NM_CLIENT_GET_PRIVATE (object);
+	GError *error = NULL;
 
-	nm_utils_init (NULL);
+	if (!nm_utils_init (&error)) {
+		g_warning ("Couldn't initilize nm-utils/crypto system: %d %s",
+		           error->code, error->message);
+		g_clear_error (&error);
+	}
 
 	G_OBJECT_CLASS (nm_client_parent_class)->constructed (object);
 

libnm-util/nm-setting-bond.c

@@ -245,13 +245,13 @@ validate_list (const char *name, const char *value, const BondDefault *def)
 {
 	guint i;
 
-	for (i = 0; def->list && i < G_N_ELEMENTS (def->list) && def->list[i]; i++) {
+	for (i = 0; i < G_N_ELEMENTS (def->list) && def->list[i]; i++) {
 		if (g_strcmp0 (def->list[i], value) == 0)
 			return TRUE;
 	}
 
 	/* empty validation list means all values pass */
-	return (def->list == NULL || def->list[0] == NULL) ? TRUE : FALSE;
+	return def->list[0] == NULL ? TRUE : FALSE;
 }
 
 static gboolean

libnm-util/nm-setting-vlan.c

@@ -250,7 +250,6 @@ nm_setting_vlan_add_priority_str (NMSettingVlan *setting,
                                   NMVlanPriorityMap map,
                                   const char *str)
 {
-	NMSettingVlanPrivate *priv = NULL;
 	GSList *list = NULL, *iter = NULL;
 	PriorityMap *item = NULL;
 
@@ -258,7 +257,6 @@ nm_setting_vlan_add_priority_str (NMSettingVlan *setting,
 	g_return_val_if_fail (map == NM_VLAN_INGRESS_MAP || map == NM_VLAN_EGRESS_MAP, FALSE);
 	g_return_val_if_fail (str && str[0], FALSE);
 
-	priv = NM_SETTING_VLAN_GET_PRIVATE (setting);
 	list = get_map (setting, map);
 
 	item = priority_map_new_from_str (map, str);

libnm-util/nm-setting-wireless.c

@@ -146,7 +146,7 @@ match_cipher (const char *cipher,
  *
  * Returns: %TRUE if the given settings are compatible with the access point's
  * security flags and mode, %FALSE if they are not.
- */ 
+ */
 gboolean
 nm_setting_wireless_ap_security_compatible (NMSettingWireless *s_wireless,
                                             NMSettingWirelessSecurity *s_wireless_sec,
@@ -155,15 +155,12 @@ nm_setting_wireless_ap_security_compatible (NMSettingWireless *s_wireless,
                                             NM80211ApSecurityFlags ap_rsn,
                                             NM80211Mode ap_mode)
 {
-	NMSettingWirelessPrivate *priv;
 	const char *key_mgmt = NULL, *cipher;
 	guint32 num, i;
 	gboolean found = FALSE;
 
 	g_return_val_if_fail (NM_IS_SETTING_WIRELESS (s_wireless), FALSE);
 
-	priv = NM_SETTING_WIRELESS_GET_PRIVATE (s_wireless);
-
 	if (!s_wireless_sec) {
 		if (   (ap_flags & NM_802_11_AP_FLAGS_PRIVACY)
 		    || (ap_wpa != NM_802_11_AP_SEC_NONE)

libnm-util/nm-utils.c

@@ -416,7 +416,7 @@ nm_utils_same_ssid (const GByteArray * ssid1,
 
 	if (ssid1 == ssid2)
 		return TRUE;
-	if ((ssid1 && !ssid2) || (!ssid1 && ssid2))
+	if (!ssid1 || !ssid2)
 		return FALSE;
 
 	ssid1_len = ssid1->len;
@@ -724,6 +724,7 @@ nm_utils_security_valid (NMUtilsSecurityType type,
 			/* Ad-Hoc WPA APs won't necessarily have the PSK flag set, and
 			 * they don't have any pairwise ciphers. */
 			if (adhoc) {
+				/* coverity[dead_error_line] */
 				if (   (ap_wpa & NM_802_11_AP_SEC_GROUP_TKIP)
 				    && (wifi_caps & NM_WIFI_DEVICE_CAP_CIPHER_TKIP))
 					return TRUE;
@@ -752,6 +753,7 @@ nm_utils_security_valid (NMUtilsSecurityType type,
 			/* Ad-Hoc WPA APs won't necessarily have the PSK flag set, and
 			 * they don't have any pairwise ciphers, nor any RSA flags yet. */
 			if (adhoc) {
+				/* coverity[dead_error_line] */
 				if (wifi_caps & NM_WIFI_DEVICE_CAP_CIPHER_TKIP)
 					return TRUE;
 				if (wifi_caps & NM_WIFI_DEVICE_CAP_CIPHER_CCMP)

src/config/nm-config.c

@@ -147,7 +147,7 @@ nm_config_get_connectivity_interval (NMConfig *config)
 	/* We store interval as signed internally to track whether it's
 	 * set or not, but report as unsigned to callers.
 	 */
-	return CLAMP (NM_CONFIG_GET_PRIVATE (config)->connectivity_interval, 0, G_MAXINT32);
+	return MAX (NM_CONFIG_GET_PRIVATE (config)->connectivity_interval, 0);
 }
 
 const char *

src/config/tests/test-config.c

@@ -35,6 +35,7 @@ setup_config (const char *config_file, const char *config_dir, ...)
 	char **argv, *arg;
 	int argc;
 	GOptionContext *context;
+	gboolean success;
 
 	args = g_ptr_array_new ();
 	g_ptr_array_add (args, "test-config");
@@ -53,9 +54,12 @@ setup_config (const char *config_file, const char *config_dir, ...)
 
 	context = g_option_context_new (NULL);
 	g_option_context_add_main_entries (context, nm_config_get_options (), NULL);
-	g_option_context_parse (context, &argc, &argv, NULL);
+	success = g_option_context_parse (context, &argc, &argv, NULL);
 	g_option_context_free (context);
 
+	if (!success)
+		g_printerr ("Invalid options.\n");
+
 	g_ptr_array_free (args, TRUE);
 }
 
@@ -87,10 +91,12 @@ test_config_simple (void)
 	g_free (value);
 
 	value = nm_config_get_value (config, "extra-section", "no-key", &error);
+	g_assert (!value);
 	g_assert_error (error, G_KEY_FILE_ERROR, G_KEY_FILE_ERROR_KEY_NOT_FOUND);
 	g_clear_error (&error);
 
 	value = nm_config_get_value (config, "no-section", "no-key", &error);
+	g_assert (!value);
 	g_assert_error (error, G_KEY_FILE_ERROR, G_KEY_FILE_ERROR_GROUP_NOT_FOUND);
 	g_clear_error (&error);
 
@@ -105,6 +111,7 @@ test_config_non_existent (void)
 
 	setup_config (SRCDIR "/no-such-file", "/no/such/dir", NULL);
 	config = nm_config_new (&error);
+	g_assert (!config);
 	g_assert_error (error, G_KEY_FILE_ERROR, G_KEY_FILE_ERROR_NOT_FOUND);
 }
 
@@ -116,6 +123,7 @@ test_config_parse_error (void)
 
 	setup_config (SRCDIR "/bad.conf", "/no/such/dir", NULL);
 	config = nm_config_new (&error);
+	g_assert (!config);
 	g_assert_error (error, G_KEY_FILE_ERROR, G_KEY_FILE_ERROR_PARSE);
 }
 
@@ -266,6 +274,7 @@ test_config_confdir_parse_error (void)
 	/* Using SRCDIR as the conf dir will pick up bad.conf */
 	setup_config (SRCDIR "/NetworkManager.conf", SRCDIR, NULL);
 	config = nm_config_new (&error);
+	g_assert (!config);
 	g_assert_error (error, G_KEY_FILE_ERROR, G_KEY_FILE_ERROR_PARSE);
 }
 

src/devices/nm-device-ethernet.c

@@ -228,7 +228,6 @@ constructor (GType type,
 			 GObjectConstructParam *construct_params)
 {
 	GObject *object;
-	NMDeviceEthernetPrivate *priv;
 	NMDevice *self;
 	int ifindex;
 
@@ -237,7 +236,6 @@ constructor (GType type,
 	                                                                        construct_params);
 	if (object) {
 		self = NM_DEVICE (object);
-		priv = NM_DEVICE_ETHERNET_GET_PRIVATE (self);
 		ifindex = nm_device_get_ifindex (self);
 
 		g_assert (   nm_platform_link_get_type (ifindex) == NM_LINK_TYPE_ETHERNET
@@ -1262,7 +1260,7 @@ update_connection (NMDevice *device, NMConnection *connection)
 	/* If the device reports a permanent address, use that for the MAC address
 	 * and the current MAC, if different, is the cloned MAC.
 	 */
-	if (priv->perm_hw_addr && memcmp (priv->perm_hw_addr, null_mac, ETH_ALEN)) {
+	if (memcmp (priv->perm_hw_addr, null_mac, ETH_ALEN)) {
 		array = g_byte_array_sized_new (ETH_ALEN);
 		g_byte_array_append (array, priv->perm_hw_addr, ETH_ALEN);
 		g_object_set (s_wired, NM_SETTING_WIRED_MAC_ADDRESS, array, NULL);

src/devices/nm-device-infiniband.c

@@ -68,22 +68,19 @@ constructor (GType type,
 			 GObjectConstructParam *construct_params)
 {
 	GObject *object;
-	NMDeviceInfinibandPrivate *priv;
 	NMDevice *self;
 
 	object = G_OBJECT_CLASS (nm_device_infiniband_parent_class)->constructor (type,
-	                                                                        n_construct_params,
-	                                                                        construct_params);
+	                                                                          n_construct_params,
+	                                                                          construct_params);
 	if (!object)
 		return NULL;
 
 	self = NM_DEVICE (object);
-	priv = NM_DEVICE_INFINIBAND_GET_PRIVATE (self);
 
 	nm_log_dbg (LOGD_HW | LOGD_INFINIBAND, "(%s): kernel ifindex %d",
-	            nm_device_get_iface (NM_DEVICE (self)),
-	            nm_device_get_ifindex (NM_DEVICE (self)));
-
+	            nm_device_get_iface (self),
+	            nm_device_get_ifindex (self));
 	return object;
 }
 

src/devices/nm-device-vlan.c

@@ -318,7 +318,7 @@ update_connection (NMDevice *device, NMConnection *connection)
 		g_object_set (s_vlan, NM_SETTING_VLAN_INTERFACE_NAME, nm_device_get_iface (device), NULL);
 	}
 
-	nm_platform_vlan_get_info (ifindex, &parent_ifindex, &vlan_id);
+	(void) nm_platform_vlan_get_info (ifindex, &parent_ifindex, &vlan_id);
 	if (priv->vlan_id != vlan_id) {
 		priv->vlan_id = vlan_id;
 		g_object_notify (G_OBJECT (device), NM_DEVICE_VLAN_ID);

src/dhcp-manager/nm-dhcp-client.c

@@ -328,7 +328,7 @@ machine_id_parse (const char *in, uuid_t uu)
 	g_return_val_if_fail (in != NULL, FALSE);
 	g_return_val_if_fail (strlen (in) == 32, FALSE);
 
-	for (i = 0; i < 32; i++, cp++) {
+	for (i = 0; i < 32; i++) {
 		if (!g_ascii_isxdigit (in[i]))
 			return FALSE;
 	}
@@ -521,7 +521,9 @@ nm_dhcp_client_stop_existing (const char *pid_file, const char *binary_name)
 		}
 	}
 
-	remove (pid_file);
+	if (remove (pid_file) == -1)
+		nm_log_dbg (LOGD_DHCP, "Could not remove dhcp pid file \"%s\": %d (%s)", pid_file, errno, g_strerror (errno));
+
 	g_free (proc_path);
 	g_free (pid_contents);
 	g_free (proc_contents);

src/dhcp-manager/nm-dhcp-dhclient.c

@@ -526,9 +526,11 @@ stop (NMDHCPClient *client, gboolean release, const GByteArray *duid)
 	NM_DHCP_CLIENT_CLASS (nm_dhcp_dhclient_parent_class)->stop (client, release, duid);
 
 	if (priv->conf_file)
-		remove (priv->conf_file);
+		if (remove (priv->conf_file) == -1)
+			nm_log_dbg (LOGD_DHCP, "Could not remove dhcp config file \"%s\": %d (%s)", priv->conf_file, errno, g_strerror (errno));
 	if (priv->pid_file) {
-		remove (priv->pid_file);
+		if (remove (priv->pid_file) == -1)
+			nm_log_dbg (LOGD_DHCP, "Could not remove dhcp pid file \"%s\": %d (%s)", priv->pid_file, errno, g_strerror (errno));
 		g_free (priv->pid_file);
 		priv->pid_file = NULL;
 	}

src/dhcp-manager/nm-dhcp-dhcpcd.c

@@ -96,12 +96,11 @@ ip4_start (NMDHCPClient *client,
 	GPid pid = -1;
 	GError *error = NULL;
 	char *pid_contents = NULL, *binary_name, *cmd_str;
-	const char *iface, *uuid;
+	const char *iface;
 
 	g_return_val_if_fail (priv->pid_file == NULL, -1);
 
 	iface = nm_dhcp_client_get_iface (client);
-	uuid = nm_dhcp_client_get_uuid (client);
 
 	priv->pid_file = g_strdup_printf (NMSTATEDIR "/dhcpcd-%s.pid", iface);
 
@@ -175,7 +174,8 @@ stop (NMDHCPClient *client, gboolean release, const GByteArray *duid)
 	NM_DHCP_CLIENT_CLASS (nm_dhcp_dhcpcd_parent_class)->stop (client, release, duid);
 
 	if (priv->pid_file)
-		remove (priv->pid_file);
+		if (remove (priv->pid_file) == -1)
+			nm_log_dbg (LOGD_DHCP, "Could not remove dhcp pid file \"%s\": %d (%s)", priv->pid_file, errno, g_strerror (errno));
 
 	/* FIXME: implement release... */
 }

src/dhcp-manager/nm-dhcp-manager.c

@@ -193,17 +193,13 @@ nm_dhcp_manager_handle_event (DBusGProxy *proxy,
                               GHashTable *options,
                               gpointer user_data)
 {
-	NMDHCPManager *manager;
-	NMDHCPManagerPrivate *priv;
+	NMDHCPManager *manager = NM_DHCP_MANAGER (user_data);
 	NMDHCPClient *client;
 	char *iface = NULL;
 	char *pid_str = NULL;
 	char *reason = NULL;
 	unsigned long temp;
 
-	manager = NM_DHCP_MANAGER (user_data);
-	priv = NM_DHCP_MANAGER_GET_PRIVATE (manager);
-
 	iface = get_option (options, "interface");
 	if (iface == NULL) {
 		nm_log_warn (LOGD_DHCP, "DHCP event didn't have associated interface.");
@@ -299,8 +295,10 @@ get_client_type (const char *client, GError **error)
 	/* If a client was disabled at build-time, its *_PATH define will be
 	 * an empty string.
 	 */
+	/* coverity[array_null] */
 	if (DHCLIENT_PATH && strlen (DHCLIENT_PATH))
 		dhclient_path = nm_dhcp_dhclient_get_path (DHCLIENT_PATH);
+	/* coverity[array_null] */
 	if (DHCPCD_PATH && strlen (DHCPCD_PATH))
 		dhcpcd_path = nm_dhcp_dhcpcd_get_path (DHCPCD_PATH);
 

src/dns-manager/nm-dns-utils.c

@@ -46,7 +46,10 @@ add_ip4_to_rdns_array (guint32 ip, GPtrArray *domains) /* network byte order */
 	else if (defprefix == 24)
 		str = g_strdup_printf ("%u.%u.%u.in-addr.arpa", p[2] & 0xFF, p[1] & 0xFF, p[0] & 0xFF);
 
-	g_return_if_fail (str != NULL);
+	if (!str) {
+		g_return_if_fail (str != NULL);
+		return;
+	}
 
 	/* Suppress duplicates */
 	for (i = 0; i < domains->len; i++) {

src/modem-manager/nm-modem-manager.c

@@ -187,23 +187,22 @@ poke_modem_cb (gpointer user_data)
 	NMModemManager *self = NM_MODEM_MANAGER (user_data);
 	DBusGConnection *g_connection;
 	DBusGProxy *proxy;
-	DBusGProxyCall *call;
 
 	g_connection = nm_dbus_manager_get_connection (self->priv->dbus_mgr);
 	proxy = dbus_g_proxy_new_for_name (g_connection,
-									   MM_OLD_DBUS_SERVICE,
-									   MM_OLD_DBUS_PATH,
-									   MM_OLD_DBUS_INTERFACE);
+	                                   MM_OLD_DBUS_SERVICE,
+	                                   MM_OLD_DBUS_PATH,
+	                                   MM_OLD_DBUS_INTERFACE);
 
 	nm_log_dbg (LOGD_MB, "Requesting to (re)launch modem-manager...");
 
-	call = dbus_g_proxy_begin_call_with_timeout (proxy,
-	                                             "EnumerateDevices",
-	                                             mm_poke_cb,
-	                                             NULL,
-	                                             NULL,
-	                                             5000,
-	                                             G_TYPE_INVALID);
+	dbus_g_proxy_begin_call_with_timeout (proxy,
+	                                      "EnumerateDevices",
+	                                      mm_poke_cb,
+	                                      NULL,
+	                                      NULL,
+	                                      5000,
+	                                      G_TYPE_INVALID);
 	return TRUE;
 }
 

src/nm-dbus-manager.c

@@ -23,6 +23,7 @@
 #include <unistd.h>
 #include <sys/stat.h>
 #include <sys/types.h>
+#include <errno.h>
 
 #include "NetworkManager.h"
 #include "nm-dbus-manager.h"
@@ -476,7 +477,8 @@ nm_dbus_manager_init (NMDBusManager *self)
 
 #if HAVE_DBUS_GLIB_100
 	/* Set up our main private DBus socket */
-	mkdir (NMRUNDIR, 0700);
+	if (mkdir (NMRUNDIR, 0700) == -1)
+		nm_log_warn (LOGD_CORE, "Error creating directory \"%s\": %d (%s)", NMRUNDIR, errno, g_strerror (errno));
 	priv->priv_server = private_server_new (PRIV_SOCK_PATH, PRIV_SOCK_TAG, self);
 	if (priv->priv_server) {
 		priv->private_servers = g_slist_append (priv->private_servers, priv->priv_server);

src/nm-dispatcher.c

@@ -213,8 +213,8 @@ dispatcher_done_cb (DBusGProxy *proxy, DBusGProxyCall *call, gpointer user_data)
 			err = g_value_get_string (tmp);
 
 			if (result != DISPATCH_RESULT_SUCCESS) {
-				nm_log_warn (LOGD_CORE, "Dispatcher script %s: %s",
-				             dispatch_result_to_string (result), err);
+				nm_log_warn (LOGD_CORE, "Dispatcher script \"%s\" failed with %s: %s",
+				             script, dispatch_result_to_string (result), err);
 			}
 
 next:
@@ -282,7 +282,6 @@ _dispatcher_call (DispatcherAction action,
 	GHashTable *device_dhcp6_props;
 	GHashTable *vpn_ip4_props;
 	GHashTable *vpn_ip6_props;
-	DBusGProxyCall *call;
 	DispatchInfo *info;
 
 	/* All actions except 'hostname' require a device */
@@ -339,23 +338,23 @@ _dispatcher_call (DispatcherAction action,
 	info->user_data = user_data;
 
 	/* Send the action to the dispatcher */
-	call = dbus_g_proxy_begin_call_with_timeout (proxy, "Action",
-	                                             dispatcher_done_cb,
-	                                             info,
-	                                             (GDestroyNotify) dispatcher_info_free,
-	                                             15000,
-	                                             G_TYPE_STRING, action_to_string (action),
-	                                             DBUS_TYPE_G_MAP_OF_MAP_OF_VARIANT, connection_hash,
-	                                             DBUS_TYPE_G_MAP_OF_VARIANT, connection_props,
-	                                             DBUS_TYPE_G_MAP_OF_VARIANT, device_props,
-	                                             DBUS_TYPE_G_MAP_OF_VARIANT, device_ip4_props,
-	                                             DBUS_TYPE_G_MAP_OF_VARIANT, device_ip6_props,
-	                                             DBUS_TYPE_G_MAP_OF_VARIANT, device_dhcp4_props,
-	                                             DBUS_TYPE_G_MAP_OF_VARIANT, device_dhcp6_props,
-	                                             G_TYPE_STRING, vpn_iface ? vpn_iface : "",
-	                                             DBUS_TYPE_G_MAP_OF_VARIANT, vpn_ip4_props,
-	                                             DBUS_TYPE_G_MAP_OF_VARIANT, vpn_ip6_props,
-	                                             G_TYPE_INVALID);
+	dbus_g_proxy_begin_call_with_timeout (proxy, "Action",
+	                                      dispatcher_done_cb,
+	                                      info,
+	                                      (GDestroyNotify) dispatcher_info_free,
+	                                      15000,
+	                                      G_TYPE_STRING, action_to_string (action),
+	                                      DBUS_TYPE_G_MAP_OF_MAP_OF_VARIANT, connection_hash,
+	                                      DBUS_TYPE_G_MAP_OF_VARIANT, connection_props,
+	                                      DBUS_TYPE_G_MAP_OF_VARIANT, device_props,
+	                                      DBUS_TYPE_G_MAP_OF_VARIANT, device_ip4_props,
+	                                      DBUS_TYPE_G_MAP_OF_VARIANT, device_ip6_props,
+	                                      DBUS_TYPE_G_MAP_OF_VARIANT, device_dhcp4_props,
+	                                      DBUS_TYPE_G_MAP_OF_VARIANT, device_dhcp6_props,
+	                                      G_TYPE_STRING, vpn_iface ? vpn_iface : "",
+	                                      DBUS_TYPE_G_MAP_OF_VARIANT, vpn_ip4_props,
+	                                      DBUS_TYPE_G_MAP_OF_VARIANT, vpn_ip6_props,
+	                                      G_TYPE_INVALID);
 	g_hash_table_destroy (connection_hash);
 	g_hash_table_destroy (connection_props);
 	g_hash_table_destroy (device_props);

src/nm-manager.c

@@ -2662,6 +2662,10 @@ _internal_activate_device (NMManager *self, NMActiveConnection *active, GError *
 	NMConnection *connection;
 	NMConnection *master_connection = NULL;
 
+	g_return_val_if_fail (NM_IS_MANAGER (self), FALSE);
+	g_return_val_if_fail (NM_IS_ACTIVE_CONNECTION (active), FALSE);
+	g_return_val_if_fail (error == NULL || *error == NULL, FALSE);
+
 	g_assert (NM_IS_VPN_CONNECTION (active) == FALSE);
 
 	connection = nm_active_connection_get_connection (active);
@@ -2937,8 +2941,8 @@ _internal_activation_auth_done (NMActiveConnection *active,
 	if (success) {
 		if (_internal_activate_generic (self, active, &error))
 			return;
-		g_assert (error);
 	}
+	g_assert (error_desc || error);
 
 	active_connection_remove (self, active);
 	nm_log_warn (LOGD_CORE, "Failed to activate '%s': %s",
@@ -2955,7 +2959,6 @@ nm_manager_activate_connection (NMManager *self,
                                 NMAuthSubject *subject,
                                 GError **error)
 {
-	NMManagerPrivate *priv;
 	NMActiveConnection *active;
 
 	g_return_val_if_fail (self != NULL, NULL);
@@ -2963,8 +2966,6 @@ nm_manager_activate_connection (NMManager *self,
 	g_return_val_if_fail (error != NULL, NULL);
 	g_return_val_if_fail (*error == NULL, NULL);
 
-	priv = NM_MANAGER_GET_PRIVATE (self);
-
 	active = _new_active_connection (self,
 	                                 connection,
 	                                 specific_object,

src/nm-policy.c

@@ -677,7 +677,7 @@ update_ip4_routing (NMPolicy *policy, gboolean force_update)
 		int mss = nm_ip4_config_get_mss (ip4_config);
 
 		if (!nm_platform_ip4_route_add (ip_ifindex, 0, 0, int_gw, 0, mss)) {
-			nm_platform_ip4_route_add (parent_ifindex, gw_addr, 32, 0, 0, parent_mss);