Commit 58b030f3 authored by Thomas Haller's avatar Thomas Haller

contrib/rpm: always run tests and enable more compiler warnings in package build

- always enable more compiler warnings. They are not marked as breaking
  the build anyway.

- also, always build with '--with-tests=yes'. Note that our autotools is
  actually very nice. Even if you build '--with-tests=no', you still can
  run `make check` and the tests are build on demand. The only
  difference here is whether the tests are build during `make` or during
  `make check`. While little difference, build everything during the
  `make` step.

- when running tests, use `make -k check`. Even if they fail, we want to
  run the entire test suite.

- also running tests are disabled, still run them. But don't let them
  fail the build.
parent aa8a7559
......@@ -540,12 +540,8 @@ intltoolize --automake --copy --force
--with-systemdsystemunitdir=%{systemd_dir} \
--with-system-ca-path=/etc/pki/tls/cert.pem \
--with-dbus-sys-dir=%{dbus_sys_dir} \
%if %{with test}
--with-tests=yes \
%else
--enable-more-warnings=yes \
--with-tests=no \
%endif
--with-valgrind=no \
--enable-ifcfg-rh=yes \
%if %{with ppp}
......@@ -605,7 +601,9 @@ touch %{buildroot}%{_sbindir}/ifup %{buildroot}%{_sbindir}/ifdown
%check
%if %{with test}
make %{?_smp_mflags} check
make -k %{?_smp_mflags} check
%else
make -k %{?_smp_mflags} check || :
%endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment