Verified Commit 098e713c authored by Thomas Haller's avatar Thomas Haller

libnm: hide nm_setting_ip_config_next_valid_dns_option() function from headers

nm_setting_ip_config_next_valid_dns_option() API was added in libnm 1.2, but
it was never exported in the ABI of libnm. It thus was unusable, and any user
trying to link against it would have been unable to do so.

Hide the API now entirely. It doesn't seem a very nice API. If we want to
allow the user to validate option names, we should expose such a function
to validate an option (not to fetch the next valid option from a

Fixes: 019943bb ('libnm-core: add dns-options property to NMSettingIPConfig')
(cherry picked from commit e8e5c124)
(cherry picked from commit 04946f71)
parent 72bc477e
Pipeline #207015 passed with stage
in 48 minutes and 52 seconds
......@@ -441,6 +441,9 @@ gboolean _nm_utils_dns_option_validate (const char *option, char **out_name,
const NMUtilsDNSOptionDesc *option_descs);
gssize _nm_utils_dns_option_find_idx (GPtrArray *array, const char *option);
int nm_setting_ip_config_next_valid_dns_option (NMSettingIPConfig *setting,
guint idx);
typedef struct _NMUtilsStrStrDictKey NMUtilsStrStrDictKey;
......@@ -3990,8 +3990,6 @@ nm_setting_ip_config_get_dns_option (NMSettingIPConfig *setting, guint idx)
* Returns: the index, greater or equal than @idx, of the first valid
* DNS option, or -1 if no valid option is found
* Since: 1.2
nm_setting_ip_config_next_valid_dns_option (NMSettingIPConfig *setting, guint idx)
......@@ -454,8 +454,6 @@ guint nm_setting_ip_config_get_num_dns_options (NMSettingIPConfig
gboolean nm_setting_ip_config_has_dns_options (NMSettingIPConfig *setting);
const char *nm_setting_ip_config_get_dns_option (NMSettingIPConfig *setting,
guint idx);
int nm_setting_ip_config_next_valid_dns_option (NMSettingIPConfig *setting,
guint idx);
gboolean nm_setting_ip_config_add_dns_option (NMSettingIPConfig *setting,
const char *dns_option);
void nm_setting_ip_config_remove_dns_option (NMSettingIPConfig *setting,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment