Skip to content
  • Thomas Haller's avatar
    libnm: drop API nm_connection_get_setting_{6lowpan,sriov,wpan}() · fe866fbe
    Thomas Haller authored
    Note that NMSettingEthtool and NMSettingMatch don't have such
    functions either.
    
    We have API
    
      nm_connection_get_setting (NMConnection *, GType)
      nm_connection_get_setting_by_name (NMConnection *, const char *)
    
    which can be used generically, meaning: the requested setting type
    is an argument to the function. That is generally more useful and
    flexible.
    
    Don't add API which duplicates existing functionality and is (arguably)
    inferiour. Drop it now. This is an ABI/API break for the current development
    cycle where the 1.14.0 API is still unstable. Indeed it's already after
    1.14-rc1, which is ugly. But it's also unlikely that somebody already uses
    this API/ABI and is badly impacted by this change.
    
    Note that nm_connection_get_setting() and nm_connection_get_setting_by_name()
    are slightly inconvenient in C still, because they usually require a cast.
    We should fix that by changing the return type to "void *". Such
    a change may be possibly any time without breaking API/ABI (almost, it'd
    be an API change when taking a function pointer without casting).
    
    (cherry picked from commit a10156f5)
    fe866fbe