• Thomas Haller's avatar
    format: reformat source tree with clang-format 13.0 · 615221a9
    Thomas Haller authored and Beniamino Galvani's avatar Beniamino Galvani committed
    We use clang-format for automatic formatting of our source files.
    Since clang-format is actively maintained software, the actual
    formatting depends on the used version of clang-format. That is
    unfortunate and painful, but really unavoidable unless clang-format
    would be strictly bug-compatible.
    So the version that we must use is from the current Fedora release, which
    is also tested by our gitlab-ci. Previously, we were using Fedora 34 with
    As Fedora 35 comes along, we need to update our formatting as Fedora 35
    comes with version "13.0.0~rc1-1.fc35".
    An alternative would be to freeze on version 12, but that has different
    problems (like, it's cumbersome to rebuild clang 12 on Fedora 35 and it
    would be cumbersome for our developers which are on Fedora 35 to use a
    clang that they cannot easily install).
    The (differently painful) solution is to reformat from time to time, as we
    switch to a new Fedora (and thus clang) version.
    Usually we would expect that such a reformatting brings minor changes.
    But this time, the changes are huge. That is mentioned in the release
    notes [1] as
      Makes PointerAligment: Right working with AlignConsecutiveDeclarations. (Fixes https://llvm.org/PR27353)
    [1] https://releases.llvm.org/13.0.0/tools/clang/docs/ReleaseNotes.html#clang-format