• Thomas Haller's avatar
    device: rename device-state-reason argument to out_failure_reason · 437c12fc
    Thomas Haller authored
    This argument is only relevant when the NMActStageReturn argument
    indicates NM_ACT_STAGE_RETURN_FAILURE. In all other cases it is ignored.
    
    Rename the argument to make the meaning clearer. The argument is passed
    through several layers of code, it isn't obvious that this argument only
    matters for the failure case. Also, the distinct name makes it easier
    to distinguish from other uses of the "reason" name.
    
    While at it, do some drive-by cleanup:
    
      - use g_return_*() instead of g_assert() to have a more graceful
        assertion.
      - functions like dhcp4_start() don't need to return a failure reason.
        Most callers don't care, and the caller who does can determine the
        proper reason.
      - allow omitting the out-argument via NM_SET_OUT().
    437c12fc
nm-modem-broadband.c 45.1 KB