Skip to content
  • Benjamin Berg's avatar
    Add calls to g_simple_async_result_set_check_cancellable · 26c215e2
    Benjamin Berg authored and Thomas Haller's avatar Thomas Haller committed
    If an operation is cancelled through the GCancellable, then the idiom is
    that the operation is always cancelled, even if it has finished
    successfully. To ensure this is the case, add calls to
    g_simple_async_result_set_check_cancellable everywhere.
    
    Without this, e.g. gnome-control-center will crash when switching away
    from the power panel quickly, as the NMClient creation finishes
    asynchronously and g-c-c assume that G_IO_ERROR_CANCELLED is returned to
    ensure it doesn't access the now invalid user_data parameter.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=794088
    26c215e2