Skip to content
  • Thomas Haller's avatar
    libnm: sort attribute names in nm_ip_address_get_attribute_names() · 17ff856b
    Thomas Haller authored
    The order in which the attribute names are returns should
    be defined and stable. Sort them and re-use the helper functions.
    
    Sorting is good, because it gives a consistent order. Maybe we don't
    want to commit to this in the API, officially the order is still
    arbitrary. In practice, we rely on the order of attribute names
    when converting the attributes to a string. The same configuration
    should produce the same string representation.
    
    That doesn't mean we commit to a fixed order in the string
    representation. It does not mean, that the order must always be this
    way, we can still change it. But between multiple runs of the same
    binary, the order should be stable.
    
    Note that our hash tables are seeded with a random number. Hence,
    their order is not only abitrary, it is also unstable and changes
    for each run of the application.
    17ff856b