1. 15 Feb, 2020 1 commit
  2. 14 Feb, 2020 2 commits
  3. 05 Feb, 2020 1 commit
  4. 03 Feb, 2020 1 commit
    • Georg Chini's avatar
      sink, source: Fix stream rescue from sinks or sources without port · bdc6b6ff
      Georg Chini authored
      Currently pa_{sink,source}_move_streams_to_default_{sink,source}() check the
      availability of the old sink or source. The sink or source is only marked as
      unavailable if the active port of a sink or source is not available.
      Therefore sinks or sources without port are always considered available,
      even if they are in the process of being unlinked and streams are not
      rescued.
      
      This patch removes the availability check because it is unnecessary. The
      functions are only called if the sink or source becomes unavailable or if
      the default sink or source changes, therefore the default_sink_changed or
      default_source_changed argument can be used as an indicator if the old
      sink or source is still present. In the case that the old default sink or
      source becomes unavailable, the function will be called twice, once when
      the default sink or source changes and once when the old sink or source
      is unlinked.
      bdc6b6ff
  5. 30 Jan, 2020 2 commits
  6. 23 Jan, 2020 1 commit
  7. 20 Jan, 2020 1 commit
    • Nick Moriarty's avatar
      Permit root-owned home directory · 97d0eda2
      Nick Moriarty authored
      On certain types of filesystem (especially NFS appliances which support
      multiple operating systems), the user's home directory may report as
      being owned by root rather than the user, yet still permit the user to
      create and modify files normally (which will be owned by them).
      
      Our users have home directories hosted on a NetApp storage appliance
      which uses mixed-mode ACLs but where the home directory is set up with
      NTFS ACLs at the top level.  This means they have the expected effective
      permissions, but the ownership reports as root.  This could also be the
      case if the filesystem were using NFS4 ACLs or similar.
      97d0eda2
  8. 16 Jan, 2020 2 commits
  9. 13 Jan, 2020 1 commit
    • Georg Chini's avatar
      virtual sources: Propagate asyncmsgq change after source-output move · 051f7508
      Georg Chini authored
      Currently, when the master of a virtual source is moved, the change of the
      asyncmsgq is not propagated to other attached virtual sources. This leads
      to a crash when the original master source is no longer available.
      
      This patch fixes the issue by modifying the moving callback to propagate the
      change to attached virtual sources.
      
      Virtual sinks show a similar bug but that will be fixed in a different patch
      series.
      051f7508
  10. 05 Jan, 2020 1 commit
  11. 04 Jan, 2020 1 commit
    • Tanu Kaskinen's avatar
      virtual-source: Don't process the rewind during requesting it · a71136be
      Tanu Kaskinen authored
      The request_rewind() callback of the uplink sink called
      pa_sink_process_rewind(), which is not allowed. Things are supposed to
      happen so that first a rewind is requested, and then during the next
      rtpoll loop the sink will process the request. Calling
      pa_sink_process_rewind() during the request phase caused a crash.
      
      Having a request_rewind() callback is completely unnecessary, because
      it's only useful for forwarding the request to a downstream sink. In
      this case there is no downstream sink.
      
      I also set max_rewind to 0, because the sink doesn't support rewinding.
      
      Fixes: pulseaudio/pulseaudio#775
      a71136be
  12. 02 Jan, 2020 4 commits
    • Ben Buchwald's avatar
      module-jackdbus-detect: Separate sink/source channels arguments · bcc2162f
      Ben Buchwald authored and Tanu Kaskinen's avatar Tanu Kaskinen committed
      If a channels argument is passed module-jackdbus-detect, it is passed to both
      module-jack-sink and module-jack-source when those are started. This is a
      problem if you want a different number of input channels from output channels.
      In particular, if you want more of one than you physically have of the other,
      it will fail. This commit adds separate source_channels and sink_channels
      arguments to be able to specify the channels arguments to module-jack-source
      and module-jack-sink separately. The combined channels argument is kept for
      backwards compatibility and will be used as a default for source_channels and
      sink_channels if either of them is omitted.
      bcc2162f
    • Ben Buchwald's avatar
      module-jackdbus-detect: Allow omitting channels argument · 64211b8f
      Ben Buchwald authored and Tanu Kaskinen's avatar Tanu Kaskinen committed
      module-jackdbus-detect documents the channels argument as optional and "if
      omitted, the sink wil use the number of physical output port and the source
      will use the number of physical input ports registered in the JACK server."
      However, although it would correctly omit the channels argument to
      module-jack-sink and module-jack-source if its channel argument was omitted,
      its argument validation was broken to consider omitting channels an error.
      This commit properly validates the channels argument so omitting it is
      accepted.
      64211b8f
    • pali's avatar
      bluetooth: Print SO_TIMESTAMP warning for SCO source only once · de666447
      pali authored and Tanu Kaskinen's avatar Tanu Kaskinen committed
      de666447
    • pali's avatar
      bluetooth: Implement reading SO_TIMESTAMP for A2DP source · 3f13af50
      pali authored and Tanu Kaskinen's avatar Tanu Kaskinen committed
      3f13af50
  13. 27 Dec, 2019 2 commits
    • Tanu Kaskinen's avatar
      switch-on-connect: Blacklist HDMI devices by default · cdcb0188
      Tanu Kaskinen authored
      As the comment says, switching to HDMI automatically often causes
      problems. Commit bae8c16b
      ("switch-on-connect: Do not ignore HDMI sinks") enabled switching to
      HDMI earlier. It was known already then that HDMI monitors don't
      necessarily have speakers on them, but I accepted the patch on the
      basis that module-switch-on-connect acts only if the card profile is
      switched to HDMI, so if switching to HDMI is wrong, then already the
      profile switch should cause problems. I didn't think of the case where
      the default sink is on some other card, in which case switching the
      profile on the HDMI card doesn't cause problems by itself.
      
      I don't want to revert bae8c16b, because João needs to be able to
      configure their systems to automatically switch to HDMI. Instead, this
      patch utilizes the new blacklisting feature in module-switch-on-connect
      to blacklist HDMI sinks by default. Switching to HDMI can be enabled by
      setting the blacklist modarg to an empty string or something that
      doesn't match HDMI sinks.
      
      Fixes: pulseaudio/pulseaudio#749
      cdcb0188
    • Tanu Kaskinen's avatar
      core-util: Handle zero-length volume string · 4dba56c1
      Tanu Kaskinen authored
      Without checking for zero we end up accessing memory outside the str
      buffer: str[len - 1].
      
      Fixes: pulseaudio/pulseaudio#768
      4dba56c1
  14. 23 Dec, 2019 7 commits
  15. 22 Dec, 2019 5 commits
  16. 21 Dec, 2019 4 commits
  17. 20 Dec, 2019 2 commits
  18. 18 Dec, 2019 2 commits