1. 05 Aug, 2019 6 commits
  2. 28 Jul, 2019 1 commit
  3. 25 Jul, 2019 3 commits
  4. 24 Jul, 2019 3 commits
    • pali's avatar
      bluetooth: Fix usage of RTP structures in SBC codec · 9e70d052
      pali authored
      Rename struct rtp_payload to rtp_sbc_payload as it is specific for SBC
      codec payload.
      Add proper checks for endianity in rtp.h header and use uint8_t type
      where appropriated.
      Field frame_count is only 4 bit number, so add checks to prevent overflow.
      And because is_fragmented field is not parsed by decoder there is no
      support for decoding fragmented SBC frames. So throw an error in this case.
    • pali's avatar
      bluetooth: Change A2DP codec API of reset() method to indicate failure · 064277b4
      pali authored
      SBC codec reset() method may fail, so propagate this failure to caller.
    • pali's avatar
      bluetooth: Fix usage of MTU, buffer sizes and return values of encode/decode methods · 018b38ec
      pali authored
      Add explanation why minimal bitpool value is used in SBC codec as initial
      bitpool value for A2DP source.
      Set buffer size for reading/writing from/to A2DP socket to exact link MTU
      value. This would ensure that A2DP codec does not produce larger packet as
      maximal possible size which can be sent.
      Because A2DP socket is of SOCK_SEQPACKET type, it is guaranteed that
      we do not read two packets via one read/recvmsg call.
      Properly check for all return values of encode/encode methods of A2DP codec
      functions. They may fail at different levels. Also encode or decode API
      method may return zero length buffer (e.g. because of algorithmic delay of
      codec), so do not fail in this case.
  5. 23 Jul, 2019 1 commit
    • Georg Chini's avatar
      Commit fd9e3452 removed -ffast-math from the compile flags. Under some · 3929798a
      Georg Chini authored
      conditions this may lead to massive slowdown of floating point operations
      when underflows or denormals are encountered. In particular, this problem
      was observed with the soxr resampler after applying
      Therefore this patch adds -ffast-math to the link flags of the pulseaudio
      daemon. Linking with -ffast-math adds a procedure set_fast_math() to the
      startup code of the daemon. On x86, the procedure sets bit 6 and 15 of the
      mxcsr register. When these bits are set, denormals and results of
      underflowing operations are truncated to 0.
  6. 20 Jul, 2019 1 commit
  7. 16 Jul, 2019 1 commit
  8. 15 Jul, 2019 1 commit
    • Arun Raghavan's avatar
      svolume: Mark channel parameter as earlyclobber · e8fe04b2
      Arun Raghavan authored
      For all our MMX/SSE code, we use a temporary channel variable, assigned
      to the DI register, which is zero'ed as the very first operation in the
      inline assembly code, before any other code is run.
      With GCC 9.1, while using -O2, the DI register is also used for the
      input operand. This is perfectly legal, but causes our code to become
      incorrect because the output operand that is assigned to DI is not
      explicitly marked as being clobbered before inputs are read.
      This change fixes the problem by adding an earlyclobber annotation (&)
      to the DI output argument.
  9. 11 Jul, 2019 3 commits
  10. 05 Jul, 2019 1 commit
  11. 04 Jul, 2019 2 commits
  12. 03 Jul, 2019 2 commits
    • Georg Chini's avatar
      sink-input: fix rewriting render memblockq when nothing should be rewound · 4c6bab43
      Georg Chini authored
      If process_rewind() is called with nbytes = 0, process_rewind() will
      nevertheless request a rewrite of the render memblockq.
      This patch fixes the problem by adding the render memblockq length to the
      rewrite amount only if nbytes > 0.
    • Georg Chini's avatar
      source-output: Fix rewinding bug · 1240afab
      Georg Chini authored
      Currently the rewind logic for the source output is broken if the output
      does not implement a process_rewind() callback. In that case, the read
      index of the delay memblockq is rewound. This is wrong, because the data
      that is going to be re-written was not yet read. Instead the write index
      should be rewound and the read index left untouched. This is the reason
      for the rewind glitches of monitor sources.
  13. 02 Jul, 2019 2 commits
    • Frédéric Danis's avatar
      bluetooth: Fix crash when disabling Bluetooth adapter · f89d64b9
      Frédéric Danis authored
      This crash occurs when PA is connected to a phone through the oFono
      When disabling the Bluetooth adapter, pa_bluetooth_device is removed before
      hf_audio_card. Both keep refs on pa_bluetooth_transport. Those removal will
      call pa_bluetooth_transport_free() from device_free() (bluez5-util.c) and
      hf_audio_card_free() (backend-ofono.c).
      In the end, the call to pa_bluetooth_transport_free() calls
      pa_hasmap_remove() through pa_bluetooth_transport_unlink(), but since
      memory has already been freed, the second try results in a segfault.
      Triggering hf_audio_card removal during pa_bluetooth_device removal allows
      hf_audio_card to be freed at the right time.
    • Frédéric Danis's avatar
      bluetooth: Fix crash in setup_stream() · 661b13d5
      Frédéric Danis authored
      setup_stream() crashes when calling set_nonblock() with an invalid
      On a new call, the ofono backend gets notified of a new connection.
      The ofono backend sets the transport state to playing, and that triggers
      a profile change, which sets up the stream for the first time.
      Then module-bluetooth-policy sets up the loopbacks. The loopbacks get
      fully initialized before the crash.
      After module-bluetooth-policy has done its things, the execution
      continues in the transport state change hook. The next hook user is
      module-bluez5-device, whose handle_transport_state_change() function
      gets called. It will then set up the stream again even though it's
      already set up. I'm not sure if that's a some kind of a bug.
      setup_stream() can handle the case where it's unnecessarily called,
      though, so this second setup is not a big problem.
      The crash happens, because the connection died due to POLLHUP in the IO
      thread before the second setup_stream() call.
  14. 01 Jul, 2019 3 commits
  15. 30 Jun, 2019 1 commit
  16. 23 Jun, 2019 1 commit
  17. 22 Jun, 2019 1 commit
  18. 17 Jun, 2019 1 commit
  19. 16 Jun, 2019 1 commit
    • Tanu Kaskinen's avatar
      a2dp-codec-sbc: get rid of compiler warnings · 4e08c14c
      Tanu Kaskinen authored
      The warnings:
      modules/bluetooth/a2dp-codec-sbc.c: In function ‘default_bitpool’:
      modules/bluetooth/a2dp-codec-sbc.c:161:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
                   switch (mode) {
      modules/bluetooth/a2dp-codec-sbc.c:169:9: note: here
               case SBC_SAMPLING_FREQ_44100:
      modules/bluetooth/a2dp-codec-sbc.c:170:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
                   switch (mode) {
      modules/bluetooth/a2dp-codec-sbc.c:180:9: note: here
               case SBC_SAMPLING_FREQ_48000:
      These were valid warnings in that an invalid channel mode would result
      in unintended fallthroughs, but the end result would anyway been a crash
      in the pa_assert_not_reached() at the end of the function, so
      functionally there's no change.
  20. 15 Jun, 2019 1 commit
  21. 11 Jun, 2019 1 commit
    • Thomas Hutschenreuther's avatar
      atomic: fix load and store for armv7 and higher · d4ff4adc
      Thomas Hutschenreuther authored
      The original atomic implementation in pulseaudio based on
      libatomic stated that the intent was to use full memory barriers.
      According to [1], the load and store implementation based on
      gcc builtins matches sequential consistent (i.e. full memory barrier)
      load and store ordering only for x86.
      I observed random crashes in client applications using memfd srbchannel
      transport on an armv8-aarch64 platform (cortex-a57).
      In all those crashes the first read on the pstream descriptor
      (the size field) was wrong and looked like it contained old data.
      I boiled the relevant parts of the srbchannel implementation down to
      a simple test case and could observe random test failures.
      So I figured that the atomic implementation was broken for armv8
      with respect to cross-cpu memory access ordering consistency.
      In order to come up with a minimal fix, I used the newer
      __atomic_load_n/__atomic_store_n builtins from gcc.
      aarch64-linux-gnu-gcc (Linaro GCC 7.3-2018.05) 7.3.1 20180425
      they compile to
      ldar and stlxr on arm64, which is correct according to [1] and [2].
      The other atomic operations based on __sync builtins don't need
      to be touched since they already are of the full memory barrier
      [1] https://www.cl.cam.ac.uk/~pes20/cpp/cpp0xmappings.html
      [2] <https://community.arm.com/developer/ip-products/processors
  22. 10 Jun, 2019 2 commits
  23. 09 Jun, 2019 1 commit