Skip to content
  • Antonio Ospite's avatar
    tools: play: fix leaving STDIN in non-blocking mode after exit · cfc1be0d
    Antonio Ospite authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
    gst-play-1.0 sets STDIN to non-blocking mode to have the input
    characters read as soon as they arrive.
    
    However, when gst_play_kb_set_key_handler() gets called from
    restore_terminal() it forgets to restore the STDIN blocking status.
    
    This can result in broken behavior for cli command executed in the same
    terminal after gst-play-1.0 exited.
    
    It turns out that putting STDIN in non-blocking mode is not even the
    proper way to achieve the desired effect, instead VMIN and VTIME in
    struct termios should be set to 0.
    
    Let's do that, and don't mess with the STDIN blocking mode now that it's
    not necessary.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=794591
    cfc1be0d